Changeset 222793 in webkit

Timestamp:

Oct 3, 2017 11:48:57 AM (7 years ago)

Author:

Antti Koivisto

Message:

Allow assigning WeakPtr<Derived> to WeakPtr<Base>
​https://bugs.webkit.org/show_bug.cgi?id=177817

Reviewed by Geoff Garen.

Source/WTF:

Add templated copy/move constructors/assignment operators, similar to RefPtr.

• wtf/WeakPtr.h:

(WTF::WeakPtrFactory::createWeakPtr const):
(WTF::weak_reference_upcast):
(WTF::weak_reference_downcast):
(WTF::WeakPtr<T>::WeakPtr):
(WTF::=):
(WTF::makeWeakPtr):

Tools:

• TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::Base::weakPtrFactory):
(TestWebKitAPI::TEST):

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/WeakPtr.h (modified) (7 diffs)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-10-03  Antti Koivisto  <antti@apple.com>
+
+        Allow assigning WeakPtr<Derived> to WeakPtr<Base>
+        https://bugs.webkit.org/show_bug.cgi?id=177817
+
+        Reviewed by Geoff Garen.
+
+        Add templated copy/move constructors/assignment operators, similar to RefPtr.
+
+        * wtf/WeakPtr.h:
+        (WTF::WeakPtrFactory::createWeakPtr const):
+        (WTF::weak_reference_upcast):
+        (WTF::weak_reference_downcast):
+        (WTF::WeakPtr<T>::WeakPtr):
+        (WTF::=):
+        (WTF::makeWeakPtr):
+
 2017-10-03  JF Bastien  <jfbastien@apple.com>
 

trunk/Source/WTF/wtf/WeakPtr.h

@@ -1 +1 @@
 /*
  * Copyright (C) 2013 Google, Inc. All Rights Reserved.
- * Copyright (C) 2015 Apple Inc. All Rights Reserved.
+ * Copyright (C) 2015, 2017 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -62 +62 @@
 };
 
+template<typename T, typename U> WeakReference<T>* weak_reference_upcast(WeakReference<U>*);
+template<typename T, typename U> WeakReference<T>* weak_reference_downcast(WeakReference<U>*);
+
 template<typename T>
 class WeakPtr {
@@ -69 +72 @@
     WeakPtr(std::nullptr_t) { }
     WeakPtr(Ref<WeakReference<T>>&& ref) : m_ref(std::forward<Ref<WeakReference<T>>>(ref)) { }
+    template<typename U> WeakPtr(const WeakPtr<U>&);
+    template<typename U> WeakPtr(WeakPtr<U>&&);
 
     T* get() const { return m_ref ? m_ref->get() : nullptr; }
@@ -74 +79 @@
 
     WeakPtr& operator=(std::nullptr_t) { m_ref = nullptr; return *this; }
+    template<typename U> WeakPtr& operator=(const WeakPtr<U>&);
+    template<typename U> WeakPtr& operator=(WeakPtr<U>&&);
 
     T* operator->() const { return m_ref->get(); }
@@ -81 +88 @@
 
 private:
+    template<typename U> friend class WeakPtr;
+
     RefPtr<WeakReference<T>> m_ref;
 };
@@ -102 +111 @@
         if (!m_ref)
             m_ref = WeakReference<T>::create(&ptr);
-        ASSERT(&ptr == m_ref->get());
-        static_assert(std::is_convertible<U*, T*>::value, "T* must be convertible to U*");
-        return WeakPtr<U>(Ref<WeakReference<U>>(reinterpret_cast<WeakReference<U>&>(*m_ref)));
+        return { makeRef(*weak_reference_downcast<U>(m_ref.get())) };
     }
 
@@ -120 +127 @@
 };
 
-template <typename T> inline WeakPtr<T> makeWeakPtr(T& ref)
+template<typename T, typename U> inline WeakReference<T>* weak_reference_upcast(WeakReference<U>* weakReference)
+{
+    static_assert(std::is_convertible<U*, T*>::value, "U* must be convertible to T*");
+    return reinterpret_cast<WeakReference<T>*>(weakReference);
+}
+
+template<typename T, typename U> inline WeakReference<T>* weak_reference_downcast(WeakReference<U>* weakReference)
+{
+    static_assert(std::is_convertible<T*, U*>::value, "T* must be convertible to U*");
+    return reinterpret_cast<WeakReference<T>*>(weakReference);
+}
+
+template<typename T> template<typename U> inline WeakPtr<T>::WeakPtr(const WeakPtr<U>& o)
+    : m_ref(weak_reference_upcast<T>(o.m_ref.get()))
+{
+}
+
+template<typename T> template<typename U> inline WeakPtr<T>::WeakPtr(WeakPtr<U>&& o)
+    : m_ref(adoptRef(weak_reference_upcast<T>(o.m_ref.leakRef())))
+{
+}
+
+template<typename T> template<typename U> inline WeakPtr<T>& WeakPtr<T>::operator=(const WeakPtr<U>& o)
+{
+    m_ref = weak_reference_upcast<T>(o.m_ref.get());
+    return *this;
+}
+
+template<typename T> template<typename U> inline WeakPtr<T>& WeakPtr<T>::operator=(WeakPtr<U>&& o)
+{
+    m_ref = adoptRef(weak_reference_upcast<T>(o.m_ref.leakRef()));
+    return *this;
+}
+
+template<typename T> inline WeakPtr<T> makeWeakPtr(T& ref)
 {
     return ref.weakPtrFactory().template createWeakPtr<T>(ref);
 }
 
-template <typename T> inline WeakPtr<T> makeWeakPtr(T* ptr)
+template<typename T> inline WeakPtr<T> makeWeakPtr(T* ptr)
 {
     if (!ptr)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-03  Antti Koivisto  <antti@apple.com>
+
+        Allow assigning WeakPtr<Derived> to WeakPtr<Base>
+        https://bugs.webkit.org/show_bug.cgi?id=177817
+
+        Reviewed by Geoff Garen.
+
+        * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
+        (TestWebKitAPI::Base::weakPtrFactory):
+        (TestWebKitAPI::TEST):
+
 2017-10-03  Youenn Fablet  <youenn@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/WeakPtr.cpp

@@ -213 +213 @@
     }
 
+    auto& weakPtrFactory() { return m_weakPtrFactory; }
+
 private:
     WeakPtrFactory<Base> m_weakPtrFactory;
@@ -255 +257 @@
 }
 
+TEST(WTF_WeakPtr, DerivedConstructAndAssign)
+{
+    Derived derived;
+    {
+        WeakPtr<Derived> derivedWeakPtr = makeWeakPtr(derived);
+        WeakPtr<Base> baseWeakPtr { WTFMove(derivedWeakPtr) };
+        EXPECT_EQ(baseWeakPtr.get(), &derived);
+        EXPECT_NULL(derivedWeakPtr.get());
+    }
+
+    {
+        WeakPtr<Derived> derivedWeakPtr = makeWeakPtr(derived);
+        WeakPtr<Base> baseWeakPtr { derivedWeakPtr };
+        EXPECT_EQ(baseWeakPtr.get(), &derived);
+        EXPECT_EQ(derivedWeakPtr.get(), &derived);
+    }
+
+    {
+        WeakPtr<Derived> derivedWeakPtr = makeWeakPtr(derived);
+        WeakPtr<Base> baseWeakPtr;
+        baseWeakPtr = WTFMove(derivedWeakPtr);
+        EXPECT_EQ(baseWeakPtr.get(), &derived);
+        EXPECT_NULL(derivedWeakPtr.get());
+    }
+
+    {
+        WeakPtr<Derived> derivedWeakPtr = makeWeakPtr(derived);
+        WeakPtr<Base> baseWeakPtr;
+        baseWeakPtr = derivedWeakPtr;
+        EXPECT_EQ(baseWeakPtr.get(), &derived);
+        EXPECT_EQ(derivedWeakPtr.get(), &derived);
+    }
+}
+
 } // namespace TestWebKitAPI