Changeset 222833 in webkit

Timestamp:

Oct 4, 2017 12:33:08 AM (7 years ago)

Author:

jdiggs@igalia.com

Message:

AX: [ATK] aria-pressed="mixed" should be exposed via ATK_STATE_INDETERMINATE
​https://bugs.webkit.org/show_bug.cgi?id=177807

Reviewed by Chris Fleizach.

Source/WebCore:

Include toggle buttons in the element types for which the mixed state is checked
and exposed via ATK_STATE_INDETERMINATE if found. Also only do the role checks when
AccessibilityObject::isIndeterminate() has returned false.

Test: accessibility/gtk/aria-pressed-mixed-value.html

• accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(setAtkStateSetFromCoreObject):

LayoutTests:

• accessibility/gtk/aria-pressed-mixed-value-expected.txt: Added.
• accessibility/gtk/aria-pressed-mixed-value.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/gtk/aria-pressed-mixed-value-expected.txt (added)
• LayoutTests/accessibility/gtk/aria-pressed-mixed-value.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-04  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: [ATK] aria-pressed="mixed" should be exposed via ATK_STATE_INDETERMINATE
+        https://bugs.webkit.org/show_bug.cgi?id=177807
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/gtk/aria-pressed-mixed-value-expected.txt: Added.
+        * accessibility/gtk/aria-pressed-mixed-value.html: Added.
+
 2017-10-04  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-04  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        AX: [ATK] aria-pressed="mixed" should be exposed via ATK_STATE_INDETERMINATE
+        https://bugs.webkit.org/show_bug.cgi?id=177807
+
+        Reviewed by Chris Fleizach.
+
+        Include toggle buttons in the element types for which the mixed state is checked
+        and exposed via ATK_STATE_INDETERMINATE if found. Also only do the role checks when
+        AccessibilityObject::isIndeterminate() has returned false.
+
+        Test: accessibility/gtk/aria-pressed-mixed-value.html
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (setAtkStateSetFromCoreObject):
+
 2017-10-04  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp

@@ -955 +955 @@
     if (coreObject->isIndeterminate())
         atk_state_set_add_state(stateSet, ATK_STATE_INDETERMINATE);
-
-    if (coreObject->isCheckboxOrRadio() || coreObject->isMenuItem()) {
+    else if (coreObject->isCheckboxOrRadio() || coreObject->isMenuItem() || coreObject->isToggleButton()) {
         if (coreObject->checkboxOrRadioValue() == ButtonStateMixed)
             atk_state_set_add_state(stateSet, ATK_STATE_INDETERMINATE);