Changeset 222863 in webkit

Timestamp:

Oct 4, 2017, 11:52:08 AM (8 years ago)

Author:

Antti Koivisto

Message:

Add assert verifying all renderers get destroyed
​https://bugs.webkit.org/show_bug.cgi?id=177870

Reviewed by Zalan Bujtas.

• rendering/RenderView.cpp:

(WebCore::RenderView::willBeDestroyed):

Add assert to verify all renderers for this tree have been destroyed before the RenderView is.

• rendering/RenderView.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderView.cpp (modified) (1 diff)
• rendering/RenderView.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-04  Antti Koivisto  <antti@apple.com>
+
+        Add assert verifying all renderers get destroyed
+        https://bugs.webkit.org/show_bug.cgi?id=177870
+
+        Reviewed by Zalan Bujtas.
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::willBeDestroyed):
+
+            Add assert to verify all renderers for this tree have been destroyed before the RenderView is.
+
+        * rendering/RenderView.h:
+
 2017-10-04  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebCore/rendering/RenderView.cpp

@@ -642 +642 @@
 }
 
+void RenderView::willBeDestroyed()
+{
+    RenderBlockFlow::willBeDestroyed();
+
+    ASSERT_WITH_MESSAGE(m_rendererCount == 1, "All other renderers in this render tree should have be destroyed");
+}
+
 void RenderView::absoluteRects(Vector<IntRect>& rects, const LayoutPoint& accumulatedOffset) const
 {

trunk/Source/WebCore/rendering/RenderView.h

@@ -287 +287 @@
     bool isScrollableOrRubberbandableBox() const override;
 
+    void willBeDestroyed() override;
+
 private:
     FrameView& m_frameView;