Changeset 222920 in webkit

Timestamp:

Oct 5, 2017 10:59:49 AM (7 years ago)

Author:

Antti Koivisto

Message:

Move more multicolumn render tree mutation code to RenderTreeUpdater::MultiColumn
​https://bugs.webkit.org/show_bug.cgi?id=177942

Reviewed by Zalan Bujtas.

• rendering/RenderMultiColumnFlow.cpp:

(WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):

Use std::unique_ptr for the spanner map for safe owenership transfer.

(WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
(WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
(WebCore::RenderMultiColumnFlow::fragmentedFlowRelativeWillBeRemoved):
(WebCore::RenderMultiColumnFlow::populate): Deleted.
(WebCore::RenderMultiColumnFlow::evacuateAndDestroy): Deleted.

This code moves to RenderTreeUpdater::MultiColumn.

• rendering/RenderMultiColumnFlow.h:
• style/RenderTreeUpdaterMultiColumn.cpp:

(WebCore::RenderTreeUpdater::MultiColumn::update):
(WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):

Use Hyatt's preferred 'fragmented flow' terminology.

• style/RenderTreeUpdaterMultiColumn.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderMultiColumnFlow.cpp (modified) (6 diffs)
• rendering/RenderMultiColumnFlow.h (modified) (3 diffs)
• style/RenderTreeUpdaterMultiColumn.cpp (modified) (3 diffs)
• style/RenderTreeUpdaterMultiColumn.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-05  Antti Koivisto  <antti@apple.com>
+
+        Move more multicolumn render tree mutation code to RenderTreeUpdater::MultiColumn
+        https://bugs.webkit.org/show_bug.cgi?id=177942
+
+        Reviewed by Zalan Bujtas.
+
+        * rendering/RenderMultiColumnFlow.cpp:
+        (WebCore::RenderMultiColumnFlow::RenderMultiColumnFlow):
+
+            Use std::unique_ptr for the spanner map for safe owenership transfer.
+
+        (WebCore::RenderMultiColumnFlow::fragmentedFlowDescendantInserted):
+        (WebCore::RenderMultiColumnFlow::handleSpannerRemoval):
+        (WebCore::RenderMultiColumnFlow::fragmentedFlowRelativeWillBeRemoved):
+        (WebCore::RenderMultiColumnFlow::populate): Deleted.
+        (WebCore::RenderMultiColumnFlow::evacuateAndDestroy): Deleted.
+
+            This code moves to RenderTreeUpdater::MultiColumn.
+
+        * rendering/RenderMultiColumnFlow.h:
+        * style/RenderTreeUpdaterMultiColumn.cpp:
+        (WebCore::RenderTreeUpdater::MultiColumn::update):
+        (WebCore::RenderTreeUpdater::MultiColumn::createFragmentedFlow):
+        (WebCore::RenderTreeUpdater::MultiColumn::destroyFragmentedFlow):
+
+            Use Hyatt's preferred 'fragmented flow' terminology.
+
+        * style/RenderTreeUpdaterMultiColumn.h:
+
 2017-10-05  Darin Adler  <darin@apple.com>
 

trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp

@@ -41 +41 @@
 RenderMultiColumnFlow::RenderMultiColumnFlow(Document& document, RenderStyle&& style)
     : RenderFragmentedFlow(document, WTFMove(style))
+    , m_spannerMap(std::make_unique<SpannerMap>())
     , m_lastSetWorkedOn(nullptr)
     , m_columnCount(1)
@@ -141 +142 @@
     }
     return nullptr;
-}
-
-void RenderMultiColumnFlow::populate()
-{
-    RenderBlockFlow* multicolContainer = multiColumnBlockFlow();
-    ASSERT(!nextSibling());
-    // Reparent children preceding the flow thread into the flow thread. It's multicol content
-    // now. At this point there's obviously nothing after the flow thread, but renderers (column
-    // sets and spanners) will be inserted there as we insert elements into the flow thread.
-    multicolContainer->moveChildrenTo(this, multicolContainer->firstChild(), this, true);
-    
-    if (multicolContainer->isFieldset()) {
-        // Keep legends out of the flow thread.
-        for (auto& box : childrenOfType<RenderBox>(*this)) {
-            if (box.isLegend())
-                moveChildTo(multicolContainer, &box, true);
-        }
-    }
-}
-
-void RenderMultiColumnFlow::evacuateAndDestroy()
-{
-    RenderBlockFlow* multicolContainer = multiColumnBlockFlow();
-    // Delete the line box tree.
-    deleteLines();
-    moveAllChildrenTo(multicolContainer, true);
-    // Move spanners back to their original DOM position in the tree, and destroy the placeholders.
-    SpannerMap::iterator it;
-    while ((it = m_spannerMap.begin()) != m_spannerMap.end()) {
-        RenderBox* spanner = it->key;
-        auto takenSpanner = multicolContainer->takeChild(*spanner);
-        ASSERT(it->value.get());
-        if (RenderMultiColumnSpannerPlaceholder* placeholder = it->value.get()) {
-            RenderBlockFlow& originalContainer = downcast<RenderBlockFlow>(*placeholder->parent());
-            originalContainer.addChild(WTFMove(takenSpanner), placeholder);
-            placeholder->removeFromParentAndDestroy();
-        }
-        m_spannerMap.remove(it);
-    }
-
-    // Remove all sets.
-    while (RenderMultiColumnSet* columnSet = firstMultiColumnSet())
-        columnSet->removeFromParentAndDestroy();
-    
-    removeFromParentAndDestroy();
 }
 
@@ -417 +373 @@
                 // We have to nuke the placeholder, since the ancestor already lost the mapping to it when
                 // we shifted the placeholder down into this flow thread.
-                placeholder.fragmentedFlow()->m_spannerMap.remove(spanner);
+                placeholder.fragmentedFlow()->spannerMap().remove(spanner);
 
                 spannersToDelete.append(placeholder.parent()->takeChild(placeholder));
@@ -428 +384 @@
             }
             
-            ASSERT(!m_spannerMap.get(placeholder.spanner()));
-            m_spannerMap.add(placeholder.spanner(), makeWeakPtr(placeholder));
+            ASSERT(!spannerMap().get(placeholder.spanner()));
+            spannerMap().add(placeholder.spanner(), makeWeakPtr(placeholder));
             ASSERT(!placeholder.firstChild()); // There should be no children here, but if there are, we ought to skip them.
             continue;
@@ -440 +396 @@
 {
     // The placeholder may already have been removed, but if it hasn't, do so now.
-    if (auto placeholder = m_spannerMap.take(&downcast<RenderBox>(spanner)))
+    if (auto placeholder = spannerMap().take(&downcast<RenderBox>(spanner)))
         placeholder->removeFromParentAndDestroy();
 
@@ -462 +418 @@
         // in the tree.
         ASSERT(relative.isDescendantOf(this));
-        m_spannerMap.remove(downcast<RenderMultiColumnSpannerPlaceholder>(relative).spanner());
+        spannerMap().remove(downcast<RenderMultiColumnSpannerPlaceholder>(relative).spanner());
         return;
     }

trunk/Source/WebCore/rendering/RenderMultiColumnFlow.h

@@ -44 +44 @@
     RenderMultiColumnSet* lastMultiColumnSet() const;
     RenderBox* firstColumnSetOrSpanner() const;
-    bool hasColumnSpanner() const { return !m_spannerMap.isEmpty(); }
+    bool hasColumnSpanner() const { return !m_spannerMap->isEmpty(); }
     static RenderBox* nextColumnSetOrSpannerSiblingOf(const RenderBox*);
     static RenderBox* previousColumnSetOrSpannerSiblingOf(const RenderBox*);
 
-    RenderMultiColumnSpannerPlaceholder* findColumnSpannerPlaceholder(RenderBox* spanner) const { return m_spannerMap.get(spanner).get(); }
+    RenderMultiColumnSpannerPlaceholder* findColumnSpannerPlaceholder(RenderBox* spanner) const { return m_spannerMap->get(spanner).get(); }
 
     void layout() override;
-
-    // Populate the flow thread with what's currently its siblings. Called when a regular block
-    // becomes a multicol container.
-    void populate();
-
-    // Empty the flow thread by moving everything to the parent. Remove all multicol specific
-    // renderers. Then destroy the flow thread. Called when a multicol container becomes a regular
-    // block.
-    void evacuateAndDestroy();
 
     unsigned columnCount() const { return m_columnCount; }
@@ -106 +97 @@
     bool shouldCheckColumnBreaks() const override;
 
+    typedef HashMap<RenderBox*, WeakPtr<RenderMultiColumnSpannerPlaceholder>> SpannerMap;
+    std::unique_ptr<SpannerMap> takeSpannerMap() { return WTFMove(m_spannerMap); }
+
 private:
     bool isRenderMultiColumnFlow() const override { return true; }
@@ -126 +120 @@
     void handleSpannerRemoval(RenderObject& spanner);
     RenderObject* processPossibleSpannerDescendant(RenderObject*& subtreeRoot, RenderObject& descendant);
+
+    SpannerMap& spannerMap() { return *m_spannerMap; }
     
 private:
-    typedef HashMap<RenderBox*, WeakPtr<RenderMultiColumnSpannerPlaceholder>> SpannerMap;
-    SpannerMap m_spannerMap;
+    std::unique_ptr<SpannerMap> m_spannerMap;
 
     // The last set we worked on. It's not to be used as the "current set". The concept of a

trunk/Source/WebCore/style/RenderTreeUpdaterMultiColumn.cpp

@@ -26 +26 @@
 
 #include "RenderBlockFlow.h"
+#include "RenderChildIterator.h"
 #include "RenderMultiColumnFlow.h"
+#include "RenderMultiColumnSet.h"
+#include "RenderMultiColumnSpannerPlaceholder.h"
 
 namespace WebCore {
@@ -33 +36 @@
 {
     bool needsFragmentedFlow = flow.requiresColumns(flow.style().columnCount());
-    auto* multiColumnFlow = flow.multiColumnFlow();
-    if (!needsFragmentedFlow) {
-        if (multiColumnFlow) {
-            flow.clearMultiColumnFlow();
-            multiColumnFlow->evacuateAndDestroy();
-            ASSERT(!flow.multiColumnFlow());
-        }
+    bool hasFragmentedFlow = flow.multiColumnFlow();
+
+    if (!hasFragmentedFlow && needsFragmentedFlow) {
+        createFragmentedFlow(flow);
         return;
     }
-    if (!multiColumnFlow)
-        createFragmentedFlow(flow);
+    if (hasFragmentedFlow && !needsFragmentedFlow) {
+        destroyFragmentedFlow(flow);
+        return;
+    }
 }
 
@@ -54 +56 @@
     auto& fragmentedFlow = *newFragmentedFlow;
     flow.RenderBlock::addChild(WTFMove(newFragmentedFlow));
-    fragmentedFlow.populate(); // Called after the flow thread is inserted so that we are reachable by the flow thread.
+
+    // Reparent children preceding the fragmented flow into the fragmented flow.
+    flow.moveChildrenTo(&fragmentedFlow, flow.firstChild(), &fragmentedFlow, true);
+    if (flow.isFieldset()) {
+        // Keep legends out of the flow thread.
+        for (auto& box : childrenOfType<RenderBox>(fragmentedFlow)) {
+            if (box.isLegend())
+                fragmentedFlow.moveChildTo(&flow, &box, true);
+        }
+    }
+
     flow.setMultiColumnFlow(fragmentedFlow);
 }
 
+void RenderTreeUpdater::MultiColumn::destroyFragmentedFlow(RenderBlockFlow& flow)
+{
+    auto& fragmentedFlow = *flow.multiColumnFlow();
+    flow.clearMultiColumnFlow();
+
+    fragmentedFlow.deleteLines();
+    fragmentedFlow.moveAllChildrenTo(&flow, true);
+
+    // Move spanners back to their original DOM position in the tree, and destroy the placeholders.
+    auto spannerMap = fragmentedFlow.takeSpannerMap();
+    for (auto& spannerAndPlaceholder : *spannerMap) {
+        RenderBox& spanner = *spannerAndPlaceholder.key;
+        auto& placeholder = *spannerAndPlaceholder.value;
+        auto takenSpanner = flow.takeChild(spanner);
+        placeholder.parent()->addChild(WTFMove(takenSpanner), &placeholder);
+        placeholder.removeFromParentAndDestroy();
+    }
+
+    while (auto* columnSet = fragmentedFlow.firstMultiColumnSet())
+        columnSet->removeFromParentAndDestroy();
+
+    fragmentedFlow.removeFromParentAndDestroy();
+}
 
 }

trunk/Source/WebCore/style/RenderTreeUpdaterMultiColumn.h

@@ -38 +38 @@
 private:
     static void createFragmentedFlow(RenderBlockFlow&);
+    static void destroyFragmentedFlow(RenderBlockFlow&);
 };