Changeset 223176 in webkit


Ignore:
Timestamp:
Oct 11, 2017 6:51:58 AM (7 years ago)
Author:
commit-queue@webkit.org
Message:

Rebaseline tests at media/modern-media-controls/media-controller
​https://bugs.webkit.org/show_bug.cgi?id=178129

Patch by Antoine Quint <Antoine Quint> on 2017-10-11
Reviewed by Sam Weinig.

Rebaseline a series of tests to work with the current modern-media-controls codebase. For the most part, this is accounting
for metrics changes and the refactoring of the auto-hide controller code.

  • media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
  • media/modern-media-controls/media-controller/media-controller-auto-hide.html:
  • media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html:
  • media/modern-media-controls/media-controller/media-controller-compact-expected.txt: Removed.
  • media/modern-media-controls/media-controller/media-controller-compact.html: Removed.
  • media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
  • media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:
  • media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt:
  • media/modern-media-controls/media-controller/media-controller-scale-factor.html:
  • media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt: Removed.
  • media/modern-media-controls/media-controller/media-controller-tight-padding.html: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/mac-elcapitan/TestExpectations:
  • platform/mac/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 added
6 deleted
18 edited
6 moved

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r223169 r223176  
     12017-10-11  Antoine Quint  <graouts@apple.com>
     2
     3        Rebaseline tests at media/modern-media-controls/media-controller
     4        https://bugs.webkit.org/show_bug.cgi?id=178129
     5
     6        Reviewed by Sam Weinig.
     7
     8        Rebaseline a series of tests to work with the current modern-media-controls codebase. For the most part, this is accounting
     9        for metrics changes and the refactoring of the auto-hide controller code.
     10
     11        * media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
     12        * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
     13        * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
     14        * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt:
     15        * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt:
     16        * media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
     17        * media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt:
     18        * media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
     19        * media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
     20        * media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
     21        * media/modern-media-controls/media-controller/media-controller-auto-hide.html:
     22        * media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html:
     23        * media/modern-media-controls/media-controller/media-controller-compact-expected.txt: Removed.
     24        * media/modern-media-controls/media-controller/media-controller-compact.html: Removed.
     25        * media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt:
     26        * media/modern-media-controls/media-controller/media-controller-fullscreen-change.html:
     27        * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
     28        * media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
     29        * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle-expected.txt:
     30        * media/modern-media-controls/media-controller/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html:
     31        * media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt:
     32        * media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html:
     33        * media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt:
     34        * media/modern-media-controls/media-controller/media-controller-scale-factor.html:
     35        * media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt: Removed.
     36        * media/modern-media-controls/media-controller/media-controller-tight-padding.html: Removed.
     37        * platform/ios-simulator/TestExpectations:
     38        * platform/mac-elcapitan/TestExpectations:
     39        * platform/mac/TestExpectations:
     40
    1412017-09-27  Frederic Wang  <fwang@igalia.com>
    242

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt

    r223175 r223176  
    55
    66PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
    7 PASS window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded') is false
     7PASS window.internals.shadowRoot(media).querySelector('.media-controls').classList.contains('faded') is false
    88PASS successfullyParsed is true
    99

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-ios-do-not-hide-controls-when-tapping-button.html

    r223175 r223176  
    1 <script src="../../../resources/js-test-pre.js"></script>
    2 <script src="../resources/media-controls-utils.js" type="text/javascript"></script>
     1<script src="../../../../resources/js-test-pre.js"></script>
     2<script src="../../resources/media-controls-utils.js" type="text/javascript"></script>
    33<meta name="viewport" content="width=device-width, initial-scale=1">
    44<body>
    5 <video src="../../content/test.mp4" style="width: 300px; position: absolute; left: 0; top: 0;" type="video/mp4" playsinline muted autoplay controls></video>
     5<video src="../../../content/test.mp4" style="width: 800px; position: absolute; left: 0; top: 0;" type="video/mp4" playsinline muted autoplay controls></video>
    66<script type="text/javascript">
    77
    … …  
    1616        pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
    1717            window.requestAnimationFrame(() => {
    18                 shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
     18                shouldBeFalse("window.internals.shadowRoot(media).querySelector('.media-controls').classList.contains('faded')");
    1919                finishJSTest();
    2020            });
    … …  
    2424
    2525</script>
    26 <script src="../../../resources/js-test-post.js"></script>
     26<script src="../../../../resources/js-test-post.js"></script>
    2727</body>

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio-expected.txt

    r223175 r223176  
    55
    66PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
    7 PASS shadowRoot.querySelector('.media-controls').style.height is "100px"
    8 PASS shadowRoot.querySelector('.media-controls').style.zoom is "0.5"
    9 PASS shadowRoot.querySelector('.media-controls').style.top is "-25px"
     7PASS shadowRoot.querySelector('.media-controls').style.height is "62px"
     8PASS shadowRoot.querySelector('.media-controls').style.transform is "scale(0.5)"
     9PASS shadowRoot.querySelector('.media-controls').style.top is "-15.5px"
    1010
    1111PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-audio.html

    r223175 r223176  
    11<!DOCTYPE html>
    2 <script src="../../../resources/js-test-pre.js"></script>
     2<script src="../../../../resources/js-test-pre.js"></script>
    33<meta name="viewport" content="width=400">
    44<body>
    5 <audio src="../../content/test.mp3" style="position: absolute; top: 100px; left: 0; width: 400px;" controls></audio>
     5<audio src="../../../content/test.mp3" style="position: absolute; top: 100px; left: 0; width: 400px;" controls></audio>
    66<script type="text/javascript">
    77
    … …  
    1515window.requestAnimationFrame(() => {
    1616    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
    17     shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "100px");
    18     shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.zoom", "0.5");
    19     shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "-25px");
     17    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "62px");
     18    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.transform", "scale(0.5)");
     19    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "-15.5px");
    2020
    2121    debug("");
    … …  
    2525
    2626</script>
    27 <script src="../../../resources/js-test-post.js"></script>
     27<script src="../../../../resources/js-test-post.js"></script>
    2828</body>

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor-expected.txt

    r223175 r223176  
    66PASS shadowRoot.querySelector('.media-controls').style.width is "800px"
    77PASS shadowRoot.querySelector('.media-controls').style.height is "600px"
    8 PASS shadowRoot.querySelector('.media-controls').style.zoom is "0.5"
     8PASS shadowRoot.querySelector('.media-controls').style.transform is "scale(0.5)"
    99PASS shadowRoot.querySelector('.media-controls').style.top is "auto"
    1010

  • trunk/LayoutTests/media/modern-media-controls/media-controller/ios/media-controller-scale-factor.html

    r223175 r223176  
    11<!DOCTYPE html>
    2 <script src="../../../resources/js-test-pre.js"></script>
     2<script src="../../../../resources/js-test-pre.js"></script>
    33<meta name="viewport" content="width=400">
    44<body>
    5 <video src="../../content/test.mp4" style="position: absolute; top: 0; left: 0; width: 400px; height: 300px;" controls></video>
     5<video src="../../../content/test.mp4" style="position: absolute; top: 0; left: 0; width: 400px; height: 300px;" controls></video>
    66<script type="text/javascript">
    77
    … …  
    1616    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.width", "800px");
    1717    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.height", "600px");
    18     shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.zoom", "0.5");
     18    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.transform", "scale(0.5)");
    1919    shouldBeEqualToString("shadowRoot.querySelector('.media-controls').style.top", "auto");
    2020
    … …  
    2525
    2626</script>
    27 <script src="../../../resources/js-test-post.js"></script>
     27<script src="../../../../resources/js-test-post.js"></script>
    2828</body>

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt

    r213337 r223176  
    44
    55
    6 PASS !!shadowRoot.querySelector('.controls-bar') became true
    7 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
    8 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
     6PASS !!shadowRoot.querySelector('.media-controls') became true
     7PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
     8PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
    99
    1010PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt

    r213340 r223176  
    44
    55
    6 PASS !!shadowRoot.querySelector('.controls-bar') became true
     6PASS !!shadowRoot.querySelector('.media-controls') became true
    77
    88Video started playing, controls bar should become visible by default.
    9 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
     9PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
    1010
    1111Controls bar should become faded when the auto-hide timer elapses.
    12 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
     12PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
    1313
    1414Mouse moved over the media, controls bar should become visible again.
    15 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
     15PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
    1616
    1717Mouse moved out of the media, controls bar should become faded.
    18 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
     18PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
    1919
    2020PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html

    r213340 r223176  
    1313
    1414media.addEventListener("play", (event) => {
    15     shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
     15    shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
    1616        debug("");
    1717        debug("Video started playing, controls bar should become visible by default.");
    18         shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
     18        shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
    1919            debug("");
    2020            debug("Controls bar should become faded when the auto-hide timer elapses.");
    21             shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
     21            shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    2222                eventSender.mouseMoveTo(100, 100);
    2323                debug("");
    2424                debug("Mouse moved over the media, controls bar should become visible again.");
    25                 shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
     25                shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
    2626                    eventSender.mouseMoveTo(400, 400);
    2727                    debug("");
    2828                    debug("Mouse moved out of the media, controls bar should become faded.");
    29                     shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
     29                    shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    3030                        debug("");
    3131                        media.remove();

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar-expected.txt

    r209430 r223176  
    55
    66Video started playing, controls bar is visible by default.
    7 PASS controlsBar.classList.contains('faded') is false
     7PASS mediaControls.classList.contains('faded') is false
    88
    99Auto-hide timer has elapsed, controls bar should be faded.
    10 PASS controlsBar.classList.contains('faded') is true
     10PASS mediaControls.classList.contains('faded') is true
    1111
    1212Mouse moved over the media, controls bar should be visible.
    13 PASS controlsBar.classList.contains('faded') is false
     13PASS mediaControls.classList.contains('faded') is false
    1414
    1515Auto-hide timer would have elapsed, but the controls bar remains visible since the mouse is over the controls bar.
    16 PASS controlsBar.classList.contains('faded') is false
     16PASS mediaControls.classList.contains('faded') is false
    1717
    1818PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play-expected.txt

    r211374 r223176  
    55
    66Video started playing, controls bar is visible by default.
    7 PASS controlsBar.classList.contains('faded') is false
     7PASS mediaControls.classList.contains('faded') is false
    88
    99Pausing media.
    … …  
    1818
    1919The initial auto-hide timer started when we resumed playback should not have expired or be overriden by the mouse entering and leaving the media, the controls should remain visible.
    20 PASS controlsBar.classList.contains('faded') is false
     20PASS mediaControls.classList.contains('faded') is false
    2121
    2222The initial auto-hide timer started when we resumed playback should now have expired and the controls should be faded.
    23 PASS controlsBar.classList.contains('faded') is true
     23PASS mediaControls.classList.contains('faded') is true
    2424
    2525PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html

    r215916 r223176  
    99description("Testing the controls bar appears when the mouse enters and disappears when the mouse leaves the media.");
    1010
    11 let controlsBar;
     11let mediaControls;
    1212
    1313const media = document.querySelector("video");
    … …  
    1818    media.removeEventListener("play", mediaStartedPlaying);
    1919    baseTime = Date.now();
    20     controlsBar = window.internals.shadowRoot(media).querySelector(".controls-bar");
     20    mediaControls = window.internals.shadowRoot(media).querySelector(".media-controls");
    2121   
    2222    window.requestAnimationFrame(() => {
    2323
    2424        debug("Video started playing, controls bar is visible by default.");
    25         shouldBeFalse("controlsBar.classList.contains('faded')");
     25        shouldBeFalse("mediaControls.classList.contains('faded')");
    2626
    2727        debug("");
    … …  
    5858                debug("");
    5959                debug("The initial auto-hide timer started when we resumed playback should not have expired or be overriden by the mouse entering and leaving the media, the controls should remain visible.");
    60                 shouldBeFalse("controlsBar.classList.contains('faded')");
     60                shouldBeFalse("mediaControls.classList.contains('faded')");
    6161            });
    6262        }, 50);
    … …  
    6666        debug("");
    6767        debug("The initial auto-hide timer started when we resumed playback should now have expired and the controls should be faded.");
    68         shouldBeTrue("controlsBar.classList.contains('faded')");
     68        shouldBeTrue("mediaControls.classList.contains('faded')");
    6969
    7070        debug("");

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause-expected.txt

    r209430 r223176  
    55
    66Video started playing, controls bar is visible by default.
    7 PASS controlsBar.classList.contains('faded') is false
     7PASS mediaControls.classList.contains('faded') is false
    88
    99Auto-hide timer would have elapsed, but media was paused so controls bar should remain visible.
    10 PASS controlsBar.classList.contains('faded') is false
     10PASS mediaControls.classList.contains('faded') is false
    1111
    1212PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html

    r211374 r223176  
    99description("Testing the controls bar remains visible when the media is paused.");
    1010
    11 let controlsBar;
     11let mediaControls;
    1212
    1313document.querySelector("video").addEventListener("play", event => {
    1414    window.requestAnimationFrame(() => {
    1515        const media = event.target;
    16         controlsBar = window.internals.shadowRoot(media).querySelector(".controls-bar");
     16        mediaControls = window.internals.shadowRoot(media).querySelector(".media-controls");
    1717
    1818        debug("Video started playing, controls bar is visible by default.");
    19         shouldBeFalse("controlsBar.classList.contains('faded')");
     19        shouldBeFalse("mediaControls.classList.contains('faded')");
    2020
    2121        media.pause();
    … …  
    2424                debug("");
    2525                debug("Auto-hide timer would have elapsed, but media was paused so controls bar should remain visible.");
    26                 shouldBeFalse("controlsBar.classList.contains('faded')");
     26                shouldBeFalse("mediaControls.classList.contains('faded')");
    2727
    2828                debug("");

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt

    r213342 r223176  
    44
    55
    6 PASS !!shadowRoot.querySelector('.controls-bar') became true
     6PASS !!shadowRoot.querySelector('.media-controls') became true
    77
    88Video started playing, controls bar should become visible by default.
    9 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
     9PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
    1010
    1111Controls bar should fade when the auto-hide timer has elapsed.
    12 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
     12PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
    1313
    1414Mouse moved over the media, controls bar should become visible.
    15 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
     15PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became false
    1616
    1717Controls bar should fade when the auto-hide timer has elapsed.
    18 PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
     18PASS shadowRoot.querySelector('.media-controls').classList.contains('faded') became true
    1919
    2020PASS successfullyParsed is true

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html

    r213342 r223176  
    1313
    1414media.addEventListener("play", (event) => {
    15     shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
     15    shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
    1616        debug("");
    1717        debug("Video started playing, controls bar should become visible by default.");
    18         shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
     18        shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
    1919            debug("");
    2020            debug("Controls bar should fade when the auto-hide timer has elapsed.");
    21             shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
     21            shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    2222                eventSender.mouseMoveTo(100, 100);
    2323                debug("");
    2424                debug("Mouse moved over the media, controls bar should become visible.");
    25                 shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
     25                shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
    2626                    debug("");
    2727                    debug("Controls bar should fade when the auto-hide timer has elapsed.");
    28                     shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
     28                    shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    2929                        debug("");
    3030                        media.remove();

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html

    r213337 r223176  
    1313
    1414media.addEventListener("play", (event) => {
    15     shouldBecomeEqual("!!shadowRoot.querySelector('.controls-bar')", "true", () => {
    16         shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "false", () => {
    17             shouldBecomeEqual("shadowRoot.querySelector('.controls-bar').classList.contains('faded')", "true", () => {
     15    shouldBecomeEqual("!!shadowRoot.querySelector('.media-controls')", "true", () => {
     16        shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "false", () => {
     17            shouldBecomeEqual("shadowRoot.querySelector('.media-controls').classList.contains('faded')", "true", () => {
    1818                debug("");
    1919                media.remove();

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-click-on-video-controls-should-not-pause.html

    r212573 r223176  
    1717    debug("");
    1818    debug("Clicking on video controls");
    19     eventSender.mouseMoveTo(bounds.left + 5, bounds.bottom - 5);
     19    eventSender.mouseMoveTo(bounds.left + 10, bounds.bottom - 10);
    2020    eventSender.mouseDown();
    2121    eventSender.mouseUp();

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt

    r213115 r223176  
    99
    1010Media exited fullscreen
    11 PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Compact
     11PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Inline
    1212PASS mediaController.controls instanceof MacOSInlineMediaControls is true
    1313

  • trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

    r213115 r223176  
    1515
    1616const button = document.body.appendChild(document.createElement("button"));
     17button.textContent = "Enter Fullscreen";
    1718
    1819function enterFullscreen()
    … …  
    4748    } else {
    4849        debug("Media exited fullscreen");
    49         shouldBe("mediaController.layoutTraits", "LayoutTraits.macOS | LayoutTraits.Compact");
     50        shouldBe("mediaController.layoutTraits", "LayoutTraits.macOS | LayoutTraits.Inline");
    5051        shouldBeTrue("mediaController.controls instanceof MacOSInlineMediaControls");
    5152

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r222399 r223176  
    7979media/modern-media-controls/layout-item [ Pass ]
    8080media/modern-media-controls/layout-node [ Pass ]
     81media/modern-media-controls/media-controller [ Pass ]
    8182media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
    8283media/modern-media-controls/media-documents [ Pass ]
    … …  
    116117media/modern-media-controls/button/button-active-state.html [ Skip ]
    117118media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Skip ]
     119media/modern-media-controls/media-controller/ios/media-controller-ios-only-enable-tap-gesture-recognizer-with-fades-when-idle.html [ Skip ]
    118120media/modern-media-controls/mute-support/mute-support-press-on-button.html [ Skip ]
    119121media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
    … …  
    128130media/modern-media-controls/controls-visibility-support/controls-visibility-support-fullscreen-on-video.html [ Skip ]
    129131media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html [ Skip ]
     132media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html [ Skip ]
     133media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
     134media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html [ Skip ]
     135media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html [ Skip ]
     136media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
    130137media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Skip ]
    131138
    … …  
    136143media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
    137144media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
     145media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
     146media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
     147media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Skip ]
     148media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
     149media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
     150media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
     151media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
    138152media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
    139153media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
    … …  
    141155media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
    142156media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
     157
     158webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
    143159
    144160webkit.org/b/172965 media/track/track-cue-overlap-snap-to-lines-not-set.html [ Failure ]

  • trunk/LayoutTests/platform/mac-elcapitan/TestExpectations

    r221758 r223176  
    77media/modern-media-controls/pip-support [ Skip ]
    88media/modern-media-controls/button/button-focus-state.html [ Skip ]
     9media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html [ Skip ]
    910
    1011webkit.org/b/176229 imported/w3c/web-platform-tests/IndexedDB/idbobjectstore-query-exception-order.html [ Pass Failure ]

  • trunk/LayoutTests/platform/mac/TestExpectations

    r223167 r223176  
    15091509media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-top-right-controls-bar-hidden-when-mute-button-disabled.html [ Pass ]
    15101510media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-rtl.html [ Pass ]
     1511media/modern-media-controls/media-controller [ Pass ]
    15111512media/modern-media-controls/media-controls/media-controls-display-above-captions.html [ Pass ]
    15121513media/modern-media-controls/media-documents [ Pass ]
    … …  
    15431544media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
    15441545media/modern-media-controls/placard-support/ipad [ Skip ]
     1546media/modern-media-controls/media-controller/ios [ Skip ]
    15451547media/modern-media-controls/media-documents/ipad [ Skip ]
    15461548media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html [ Skip ]
    15471549media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Skip ]
    15481550media/modern-media-controls/scrubber-support/ipad [ Skip ]
     1551
     1552# These tests are timing-related and can fail due to performance issues on bots
     1553media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Pass Failure ]
     1554media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html [ Pass Failure ]
     1555media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html [ Pass Failure ]
     1556media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Pass Failure ]
     1557media/modern-media-controls/media-controller/media-controller-auto-hide.html [ Pass Failure ]
     1558
     1559webkit.org/b/178126 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
     1560webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
    15491561
    15501562# This test relies on the control overlay not being visible in the top left. But the test now fails on Mac because
Note: See TracChangeset for help on using the changeset viewer.