Changeset 223177 in webkit


Ignore:
Timestamp:
Oct 11, 2017 6:59:44 AM (7 years ago)
Author:
tpopela@redhat.com
Message:

Use https for trac changeset and browser links
https://bugs.webkit.org/show_bug.cgi?id=178167

Reviewed by Alexey Proskuryakov.

Switch the http://trac.webkit.org/changeset and
http://trac.webkit.org/browser links that are printed by webkitpy to
https. Also update the test expectations.

  • Scripts/webkitpy/common/checkout/checkout_unittest.py:
  • Scripts/webkitpy/common/config/committervalidator_unittest.py:

(CommitterValidatorTest.test_flag_permission_rejection_message):

  • Scripts/webkitpy/common/config/urls.py:

(view_source_url):
(view_revision_url):

  • Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:

(BugTest.test_commit_revision):

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

  • Scripts/webkitpy/style/checkers/changelog_unittest.py:

(ChangeLogCheckerTest.test_missing_bug_number):

  • Scripts/webkitpy/tool/bot/feeders_unittest.py:
  • Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  • Scripts/webkitpy/tool/bot/ircbot_unittest.py:

(IRCBotTest.test_rollout):
(IRCBotTest.test_revert):
(IRCBotTest.test_multi_rollout):
(IRCBotTest.test_rollout_with_r_in_svn_revision):
(IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
(IRCBotTest.test_rollout_invalidate_reason):
(test_multi_rollout_invalidate_reason):

  • Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/suggestnominations.py:

(SuggestNominations._count_commit):

  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:

(getTracUrl):
(getSortedKeys):

  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:

(CloseBugForLandDiffTest.test_empty_state):

  • Scripts/webkitpy/tool/steps/commit_unittest.py:

(CommitTest._test_check_test_expectations):

  • Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:

(UpdateChangeLogsForRevertTest):

Location:
trunk/Tools
Files:
22 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r223167 r223177  
     12017-10-11  Tomas Popela  <tpopela@redhat.com>
     2
     3        Use https for trac changeset and browser links
     4        https://bugs.webkit.org/show_bug.cgi?id=178167
     5
     6        Reviewed by Alexey Proskuryakov.
     7
     8        Switch the http://trac.webkit.org/changeset and
     9        http://trac.webkit.org/browser links that are printed by webkitpy to
     10        https. Also update the test expectations.
     11
     12        * Scripts/webkitpy/common/checkout/checkout_unittest.py:
     13        * Scripts/webkitpy/common/config/committervalidator_unittest.py:
     14        (CommitterValidatorTest.test_flag_permission_rejection_message):
     15        * Scripts/webkitpy/common/config/urls.py:
     16        (view_source_url):
     17        (view_revision_url):
     18        * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
     19        (BugTest.test_commit_revision):
     20        * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
     21        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
     22        * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
     23        (MainTest):
     24        (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
     25        * Scripts/webkitpy/style/checkers/changelog_unittest.py:
     26        (ChangeLogCheckerTest.test_missing_bug_number):
     27        * Scripts/webkitpy/tool/bot/feeders_unittest.py:
     28        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
     29        * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
     30        (IRCBotTest.test_rollout):
     31        (IRCBotTest.test_revert):
     32        (IRCBotTest.test_multi_rollout):
     33        (IRCBotTest.test_rollout_with_r_in_svn_revision):
     34        (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
     35        (IRCBotTest.test_rollout_invalidate_reason):
     36        (test_multi_rollout_invalidate_reason):
     37        * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
     38        * Scripts/webkitpy/tool/commands/download_unittest.py:
     39        * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
     40        * Scripts/webkitpy/tool/commands/queues_unittest.py:
     41        * Scripts/webkitpy/tool/commands/suggestnominations.py:
     42        (SuggestNominations._count_commit):
     43        * Scripts/webkitpy/tool/commands/upload_unittest.py:
     44        * Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js:
     45        (getTracUrl):
     46        (getSortedKeys):
     47        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
     48        (CloseBugForLandDiffTest.test_empty_state):
     49        * Scripts/webkitpy/tool/steps/commit_unittest.py:
     50        (CommitTest._test_check_test_expectations):
     51        * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
     52        (UpdateChangeLogsForRevertTest):
     53
    1542017-10-10  Ryosuke Niwa  <rniwa@webkit.org>
    255
  • trunk/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py

    r219483 r223177  
    122122
    123123        "[Win] Build fix after r134209"
    124         http://trac.webkit.org/changeset/170340
     124        https://trac.webkit.org/changeset/170340
    125125
    126126        "[Win] Clean up and refactor WinLauncher"
    127127        https://bugs.webkit.org/show_bug.cgi?id=134209
    128         http://trac.webkit.org/changeset/170339
     128        https://trac.webkit.org/changeset/170339
    129129"""
    130130
     
    287287
    288288"[Win] Build fix after r134209"
    289 http://trac.webkit.org/changeset/170340
     289https://trac.webkit.org/changeset/170340
    290290
    291291"[Win] Clean up and refactor WinLauncher"
    292292https://bugs.webkit.org/show_bug.cgi?id=134209
    293 http://trac.webkit.org/changeset/170339
     293https://trac.webkit.org/changeset/170339
    294294
    295295Patch by Daniel Bates <dabates@apple.com> on 2014-06-23
     
    313313
    314314"[Win] Build fix after r134209"
    315 http://trac.webkit.org/changeset/170340
     315https://trac.webkit.org/changeset/170340
    316316
    317317"[Win] Clean up and refactor WinLauncher"
    318318https://bugs.webkit.org/show_bug.cgi?id=134209
    319 http://trac.webkit.org/changeset/170339
     319https://trac.webkit.org/changeset/170339
    320320
    321321Patch by Daniel Bates <dabates@apple.com> on 2014-06-23
  • trunk/Tools/Scripts/webkitpy/common/config/committervalidator_unittest.py

    r174136 r223177  
    3737        validator = CommitterValidator(MockHost())
    3838        self.assertEqual(validator._contributors_json_path(), "Tools/Scripts/webkitpy/common/config/contributors.json")
    39         expected_messsage = """foo@foo.com does not have review permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
     39        expected_messsage = """foo@foo.com does not have review permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
    4040
    4141- If you do not have review rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
  • trunk/Tools/Scripts/webkitpy/common/config/urls.py

    r202362 r223177  
    3131
    3232def view_source_url(local_path):
    33     return "http://trac.webkit.org/browser/trunk/%s" % local_path
     33    return "https://trac.webkit.org/browser/trunk/%s" % local_path
    3434
    3535
    3636def view_revision_url(revision_number):
    37     return "http://trac.webkit.org/changeset/%s" % revision_number
     37    return "https://trac.webkit.org/changeset/%s" % revision_number
    3838
    3939
  • trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bug_unittest.py

    r174136 r223177  
    5858
    5959        bug = Bug({"comments": [
    60             {"text": "Committed r138776: <http://trac.webkit.org/changeset/138776>"},
     60            {"text": "Committed r138776: <https://trac.webkit.org/changeset/138776>"},
    6161            ]}, bugzilla=None)
    6262        self.assertEqual(bug.commit_revision(), 138776)
    6363
    6464        bug = Bug({"comments": [
    65             {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
     65            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
    6666            ]}, bugzilla=None)
    6767        self.assertEqual(bug.commit_revision(), 138776)
     
    6969        bug = Bug({"comments": [
    7070            {"text": "Comment before"},
    71             {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
     71            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
    7272            {"text": "Comment after"},
    7373            ]}, bugzilla=None)
     
    7676        bug = Bug({"comments": [
    7777            {"text": "Comment before"},
    78             {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <http://trac.webkit.org/changeset/138776>"},
     78            {"text": "(From update of attachment 181269) Clearing flags on attachment: 181269 Committed r138776: <https://trac.webkit.org/changeset/138776>"},
    7979            {"text": "Comment Middle"},
    80             {"text": "(From update of attachment 181280) Clearing flags on attachment: 181280 Committed r138976: <http://trac.webkit.org/changeset/138976>"},
     80            {"text": "(From update of attachment 181280) Clearing flags on attachment: 181280 Committed r138976: <https://trac.webkit.org/changeset/138976>"},
    8181            {"text": "Comment After"},
    8282            ]}, bugzilla=None)
  • trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py

    r220715 r223177  
    182182    "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    183183                  "comment_email": "bar@foo.com",
    184                   "text": "Message1.\nCommitted r35: <http://trac.webkit.org/changeset/35>",
     184                  "text": "Message1.\nCommitted r35: <https://trac.webkit.org/changeset/35>",
    185185                  },
    186186                 ],
     
    198198    "comments":  [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    199199                   "comment_email": "bar@foo.com",
    200                    "text": "Committed r30: <http://trac.webkit.org/changeset/30>",
     200                   "text": "Committed r30: <https://trac.webkit.org/changeset/30>",
    201201                   },
    202202                  {"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    203203                   "comment_email": "bar@foo.com",
    204                    "text": "Committed r31: <http://trac.webkit.org/changeset/31>",
     204                   "text": "Committed r31: <https://trac.webkit.org/changeset/31>",
    205205                   },
    206206                  ],
     
    218218    "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    219219                  "comment_email": "bar@foo.com",
    220                   "text": "Committed r25: <http://trac.webkit.org/changeset/30>",
     220                  "text": "Committed r25: <https://trac.webkit.org/changeset/30>",
    221221                  },
    222222                 {"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    223223                  "comment_email": "bar@foo.com",
    224                   "text": "Rolled out in <http://trac.webkit.org/changeset/26",
     224                  "text": "Rolled out in <https://trac.webkit.org/changeset/26",
    225225                  },
    226226                 ],
     
    239239    "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    240240                  "comment_email": "bar@foo.com",
    241                   "text": "Committed r15: <http://trac.webkit.org/changeset/15>",
     241                  "text": "Committed r15: <https://trac.webkit.org/changeset/15>",
    242242                  },
    243243                 ],
     
    256256    "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    257257                  "comment_email": "bar@foo.com",
    258                   "text": "Committed r95: <http://trac.webkit.org/changeset/95>",
     258                  "text": "Committed r95: <https://trac.webkit.org/changeset/95>",
    259259                  },
    260260                 ],
     
    273273    "comments": [{"comment_date":  datetime.datetime(2011, 6, 11, 9, 4, 3),
    274274                  "comment_email": "bar@foo.com",
    275                   "text": "Message1.\nCommitted r105: <http://trac.webkit.org/changeset/105>",
     275                  "text": "Message1.\nCommitted r105: <https://trac.webkit.org/changeset/105>",
    276276                  },
    277277                 ],
  • trunk/Tools/Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py

    r202362 r223177  
    335335      <tr class="alt">
    336336        <td>Jan 10 15:49</td>
    337         <td><span class="revision" title="Revision 104643"><a href="http://trac.webkit.org/changeset/104643">104643</a></span></td>
     337        <td><span class="revision" title="Revision 104643"><a href="https://trac.webkit.org/changeset/104643">104643</a></span></td>
    338338        <td class="success">failure</td>    <td><a href=".../37604">#37604</a></td>
    339339        <td class="left">Build successful</td>
     
    341341      <tr class="">
    342342        <td>Jan 10 15:32</td>
    343         <td><span class="revision" title="Revision 104636"><a href="http://trac.webkit.org/changeset/104636">104636</a></span></td>
     343        <td><span class="revision" title="Revision 104636"><a href="https://trac.webkit.org/changeset/104636">104636</a></span></td>
    344344        <td class="success">failure</td>    <td><a href=".../37603">#37603</a></td>
    345345        <td class="left">Build successful</td>
     
    347347      <tr class="alt">
    348348        <td>Jan 10 15:18</td>
    349         <td><span class="revision" title="Revision 104635"><a href="http://trac.webkit.org/changeset/104635">104635</a></span></td>
     349        <td><span class="revision" title="Revision 104635"><a href="https://trac.webkit.org/changeset/104635">104635</a></span></td>
    350350        <td class="success">success</td>    <td><a href=".../37602">#37602</a></td>
    351351        <td class="left">Build successful</td>
     
    353353      <tr class="">
    354354        <td>Jan 10 14:51</td>
    355         <td><span class="revision" title="Revision 104633"><a href="http://trac.webkit.org/changeset/104633">104633</a></span></td>
     355        <td><span class="revision" title="Revision 104633"><a href="https://trac.webkit.org/changeset/104633">104633</a></span></td>
    356356        <td class="failure">failure</td>    <td><a href=".../37601">#37601</a></td>
    357357        <td class="left">Failed compile-webkit</td>
     
    364364      <tr class="alt">
    365365        <td>Jan 10 15:49</td>
    366         <td><span class="revision" title="Revision 104643"><a href="http://trac.webkit.org/changeset/104643">104643</a></span></td>
     366        <td><span class="revision" title="Revision 104643"><a href="https://trac.webkit.org/changeset/104643">104643</a></span></td>
    367367        <td class="success">failure</td>
    368368      </tr>
    369369      <tr class="">
    370370        <td>Jan 10 15:32</td>
    371         <td><span class="revision" title="Revision 104636"><a href="http://trac.webkit.org/changeset/104636">104636</a></span></td>
     371        <td><span class="revision" title="Revision 104636"><a href="https://trac.webkit.org/changeset/104636">104636</a></span></td>
    372372        <td class="success">failure</td>
    373373      </tr>
    374374      <tr class="alt">
    375375        <td>Jan 10 15:18</td>
    376         <td><span class="revision" title="Revision 104635"><a href="http://trac.webkit.org/changeset/104635">104635</a></span></td>
     376        <td><span class="revision" title="Revision 104635"><a href="https://trac.webkit.org/changeset/104635">104635</a></span></td>
    377377        <td class="success">failure</td>
    378378      </tr>
    379379      <tr class="">
    380380          <td>Jan 10 11:58</td>
    381           <td><span class="revision" title="Revision ??"><a href="http://trac.webkit.org/changeset/%3F%3F">??</a></span></td>
     381          <td><span class="revision" title="Revision ??"><a href="https://trac.webkit.org/changeset/%3F%3F">??</a></span></td>
    382382          <td class="retry">retry</td>
    383383        </tr>
    384384      <tr class="">
    385385        <td>Jan 10 14:51</td>
    386         <td><span class="revision" title="Revision 104633"><a href="http://trac.webkit.org/changeset/104633">104633</a></span></td>
     386        <td><span class="revision" title="Revision 104633"><a href="https://trac.webkit.org/changeset/104633">104633</a></span></td>
    387387        <td class="failure">failure</td>
    388388      </tr>
  • trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py

    r202362 r223177  
    5454"""
    5555
    56     results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
     56    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
    5757        'metrics': {'Time': {'current': [[1486.0, 1471.0, 1510.0, 1505.0, 1478.0, 1490.0]] * 4}}}
    5858
     
    6969"""
    7070
    71     results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/some-parser.html',
     71    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/some-parser.html',
    7272        'metrics': {'Time': {'current': [[1080.0, 1120.0, 1095.0, 1101.0, 1104.0]] * 4}}}
    7373
     
    111111"""
    112112
    113     results = {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
     113    results = {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
    114114        'metrics': {'Time': {'current': [[1080.0, 1120.0, 1095.0, 1101.0, 1104.0]] * 4}},
    115115        'tests': {
    116116            'subtest': {
    117                 'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
     117                'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
    118118                'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4}}},
    119119            'total-test': {
    120                 'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
     120                'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
    121121                'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4, "aggregators": ["Total"]}},
    122122                'tests': {
    123123                    'subsubtest':
    124                         {'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
     124                        {'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Parser/test-with-subtests.html',
    125125                        'metrics': {'Time': {'current': [[1.0, 2.0, 3.0, 4.0, 5.0]] * 4}}}}}}}
    126126
     
    313313    _event_target_wrapper_and_inspector_results = {
    314314        "Bindings":
    315             {"url": "http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings",
     315            {"url": "https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings",
    316316            "tests": {"event-target-wrapper": EventTargetWrapperTestData.results}},
    317317        "Parser":
    318             {"url": "http://trac.webkit.org/browser/trunk/PerformanceTests/Parser",
     318            {"url": "https://trac.webkit.org/browser/trunk/PerformanceTests/Parser",
    319319            "tests": {"some-parser": SomeParserTestData.results}}}
    320320
     
    512512        self.assertEqual(output['tests'].keys(), ['Bindings', 'Parser'])
    513513        self.assertEqual(sorted(output['tests']['Bindings'].keys()), ['tests', 'url'])
    514         self.assertEqual(output['tests']['Bindings']['url'], 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings')
     514        self.assertEqual(output['tests']['Bindings']['url'], 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings')
    515515        self.assertEqual(output['tests']['Bindings']['tests'].keys(), ['event-target-wrapper'])
    516516        self.assertEqual(output['tests']['Bindings']['tests']['event-target-wrapper'], {
    517             'url': 'http://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
     517            'url': 'https://trac.webkit.org/browser/trunk/PerformanceTests/Bindings/event-target-wrapper.html',
    518518            'metrics': {'Time': {'current': [[1486.0, 1471.0, 1510.0, 1505.0, 1478.0, 1490.0]] * 4}}})
    519519
  • trunk/Tools/Scripts/webkitpy/style/checkers/changelog_unittest.py

    r219483 r223177  
    8787                          '        Example bug'
    8888                          '\n'
    89                           '        http://trac.webkit.org/changeset/12345\n')
     89                          '        https://trac.webkit.org/changeset/12345\n')
    9090        self.assert_error(2, range(2, 5), 'changelog/bugnumber',
    9191                          '2011-01-01  Patrick Gansterer  <paroga@paroga.com>\n'
  • trunk/Tools/Scripts/webkitpy/tool/bot/feeders_unittest.py

    r174248 r223177  
    4242        expected_logs = """Warning, attachment 10001 on bug 50000 has invalid committer (non-committer@example.com)
    4343Warning, attachment 10001 on bug 50000 has invalid committer (non-committer@example.com)
    44 MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-committer@example.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
     44MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-committer@example.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
    4545
    4646- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
  • trunk/Tools/Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py

    r174136 r223177  
    7777
    7878foo/bar.html was authored by test@test.com.
    79 http://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
     79https://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
    8080
    8181FLAKE_MESSAGE
     
    113113
    114114foo/bar.html was authored by abarth@webkit.org.
    115 http://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
     115https://trac.webkit.org/browser/trunk/LayoutTests/foo/bar.html
    116116
    117117The dummy-queue just saw foo/bar.html flake (text diff) while processing attachment 10000 on bug 50000.
  • trunk/Tools/Scripts/webkitpy/tool/bot/ircbot_unittest.py

    r209216 r223177  
    9696
    9797    def test_rollout(self):
    98         expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
     98        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
    9999        OutputCapture().assert_outputs(self, run, args=["rollout 21654 This patch broke the world"], expected_logs=expected_logs)
    100100
    101101    def test_revert(self):
    102         expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
     102        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
    103103        OutputCapture().assert_outputs(self, run, args=["revert 21654 This patch broke the world"], expected_logs=expected_logs)
    104104
    105105    def test_multi_rollout(self):
    106         expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
     106        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
    107107        OutputCapture().assert_outputs(self, run, args=["rollout 21654 21655 21656 This 21654 patch broke the world"], expected_logs=expected_logs)
    108108
    109109    def test_rollout_with_r_in_svn_revision(self):
    110         expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
     110        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
    111111        OutputCapture().assert_outputs(self, run, args=["rollout r21654 This patch broke the world"], expected_logs=expected_logs)
    112112
    113113    def test_multi_rollout_with_r_in_svn_revision(self):
    114         expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
     114        expected_logs = "MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...\nMOCK: irc.post: mock_nick, abarth, darin, eseidel: Created rollout: http://example.com/36936\n"
    115115        OutputCapture().assert_outputs(self, run, args=["rollout r21654 21655 r21656 This r21654 patch broke the world"], expected_logs=expected_logs)
    116116
     
    128128    def test_rollout_invalidate_reason(self):
    129129        # FIXME: I'm slightly confused as to why this doesn't return the USAGE message.
    130         expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654 ...
     130        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654 ...
    131131MOCK: irc.post: mock_nick, abarth, darin, eseidel: Failed to create rollout patch:
    132132MOCK: irc.post: The rollout reason may not begin with - (\"-bad (Requested by mock_nick on #webkit).\").
     
    137137
    138138    def test_multi_rollout_invalidate_reason(self):
    139         expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for http://trac.webkit.org/changeset/21654, http://trac.webkit.org/changeset/21655, and http://trac.webkit.org/changeset/21656 ...
     139        expected_logs = """MOCK: irc.post: mock_nick: Preparing rollout for https://trac.webkit.org/changeset/21654, https://trac.webkit.org/changeset/21655, and https://trac.webkit.org/changeset/21656 ...
    140140MOCK: irc.post: mock_nick, abarth, darin, eseidel: Failed to create rollout patch:
    141141MOCK: irc.post: The rollout reason may not begin with - (\"-bad (Requested by mock_nick on #webkit).\").
  • trunk/Tools/Scripts/webkitpy/tool/bot/sheriff_unittest.py

    r174136 r223177  
    6868        expected_logs = u"""MOCK bug comment: bug_id=1234, cc=['watcher@example.com']
    6969--- Begin comment ---
    70 http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
     70https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
    7171--- End comment ---
    7272
    7373MOCK bug comment: bug_id=1234, cc=['watcher@example.com']
    7474--- Begin comment ---
    75 http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
     75https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
    7676The following tests are not passing:
    7777mock-test-1
     
    8080MOCK bug comment: bug_id=1234, cc=['watcher@example.com']
    8181--- Begin comment ---
    82 http://trac.webkit.org/changeset/4321 might have broken Foo and Bar
     82https://trac.webkit.org/changeset/4321 might have broken Foo and Bar
    8383The following tests are not passing:
    8484mock-test-1
  • trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py

    r221926 r223177  
    147147Running bindings generation tests
    148148Running run-webkit-tests
    149 Committed r49824: <http://trac.webkit.org/changeset/49824>
     149Committed r49824: <https://trac.webkit.org/changeset/49824>
    150150Updating bug 50000
    151151"""
     
    176176Running run-webkit-tests
    177177MOCK run_and_throw_if_fail: ['mock-run-webkit-tests', '--quiet'], cwd=/mock-checkout
    178 Committed r49824: <http://trac.webkit.org/changeset/49824>
    179 Committed r49824: <http://trac.webkit.org/changeset/49824>
     178Committed r49824: <https://trac.webkit.org/changeset/49824>
     179Committed r49824: <https://trac.webkit.org/changeset/49824>
    180180No bug id provided.
    181181"""
     
    193193Running bindings generation tests
    194194Running run-webkit-tests
    195 Committed r49824: <http://trac.webkit.org/changeset/49824>
     195Committed r49824: <https://trac.webkit.org/changeset/49824>
    196196Updating bug 50000
    197197"""
     
    224224Running bindings generation tests
    225225Running run-webkit-tests
    226 Committed r49824: <http://trac.webkit.org/changeset/49824>
     226Committed r49824: <https://trac.webkit.org/changeset/49824>
    227227Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
    228228"""
     
    241241Running bindings generation tests
    242242Running run-webkit-tests
    243 Committed r49824: <http://trac.webkit.org/changeset/49824>
     243Committed r49824: <https://trac.webkit.org/changeset/49824>
    244244Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
    245245Updating working directory
     
    251251Running bindings generation tests
    252252Running run-webkit-tests
    253 Committed r49824: <http://trac.webkit.org/changeset/49824>
     253Committed r49824: <https://trac.webkit.org/changeset/49824>
    254254Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
    255255"""
     
    268268Running bindings generation tests
    269269Running run-webkit-tests
    270 Committed r49824: <http://trac.webkit.org/changeset/49824>
     270Committed r49824: <https://trac.webkit.org/changeset/49824>
    271271Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
    272272Updating working directory
     
    278278Running bindings generation tests
    279279Running run-webkit-tests
    280 Committed r49824: <http://trac.webkit.org/changeset/49824>
     280Committed r49824: <https://trac.webkit.org/changeset/49824>
    281281Not closing bug 50000 as attachment 10000 has review=+.  Assuming there are more patches to land from this bug.
    282282"""
     
    292292MOCK create_bug
    293293bug_title: REGRESSION(r852): Reason
    294 bug_description: http://trac.webkit.org/changeset/852 broke the build:
     294bug_description: https://trac.webkit.org/changeset/852 broke the build:
    295295Reason
    296296component: MOCK component
     
    317317MOCK create_bug
    318318bug_title: REGRESSION(r852): Reason
    319 bug_description: http://trac.webkit.org/changeset/852 broke the build:
     319bug_description: https://trac.webkit.org/changeset/852 broke the build:
    320320Reason
    321321component: MOCK component
     
    342342MOCK create_bug
    343343bug_title: REGRESSION(r852): Reason
    344 bug_description: http://trac.webkit.org/changeset/852 broke the build:
     344bug_description: https://trac.webkit.org/changeset/852 broke the build:
    345345Reason
    346346component: MOCK component
     
    366366MOCK create_bug
    367367bug_title: REGRESSION(r3001): Reason
    368 bug_description: http://trac.webkit.org/changeset/3001 broke the build:
     368bug_description: https://trac.webkit.org/changeset/3001 broke the build:
    369369Reason
    370370component: MOCK component
     
    392392MOCK create_bug
    393393bug_title: REGRESSION(r963): Reason
    394 bug_description: http://trac.webkit.org/changeset/963 broke the build:
     394bug_description: https://trac.webkit.org/changeset/963 broke the build:
    395395Reason
    396396component: MOCK component
     
    419419Was that diff correct?
    420420Building WebKit
    421 Committed r49824: <http://trac.webkit.org/changeset/49824>
     421Committed r49824: <https://trac.webkit.org/changeset/49824>
    422422MOCK reopen_bug 50000 with comment 'Reverted r852 for reason:
    423423
    424424Reason
    425425
    426 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     426Committed r49824: <https://trac.webkit.org/changeset/49824>'
    427427"""
    428428        self.assert_execute_outputs(Rollout(), [852, "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
     
    435435Was that diff correct?
    436436Building WebKit
    437 Committed r49824: <http://trac.webkit.org/changeset/49824>
     437Committed r49824: <https://trac.webkit.org/changeset/49824>
    438438MOCK reopen_bug 50000 with comment 'Reverted r852 and r963 for reason:
    439439
    440440Reason
    441441
    442 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     442Committed r49824: <https://trac.webkit.org/changeset/49824>'
    443443MOCK reopen_bug 50005 with comment 'Reverted r852 and r963 for reason:
    444444
    445445Reason
    446446
    447 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     447Committed r49824: <https://trac.webkit.org/changeset/49824>'
    448448"""
    449449        self.assert_execute_outputs(Rollout(), ["852 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
     
    457457Was that diff correct?
    458458Building WebKit
    459 Committed r49824: <http://trac.webkit.org/changeset/49824>
     459Committed r49824: <https://trac.webkit.org/changeset/49824>
    460460MOCK reopen_bug 50000 with comment 'Reverted r852, r963, and r3001 for reason:
    461461
    462462Reason
    463463
    464 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     464Committed r49824: <https://trac.webkit.org/changeset/49824>'
    465465MOCK reopen_bug 50005 with comment 'Reverted r852, r963, and r3001 for reason:
    466466
    467467Reason
    468468
    469 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     469Committed r49824: <https://trac.webkit.org/changeset/49824>'
    470470MOCK reopen_bug 50004 with comment 'Reverted r852, r963, and r3001 for reason:
    471471
    472472Reason
    473473
    474 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     474Committed r49824: <https://trac.webkit.org/changeset/49824>'
    475475"""
    476476        self.assert_execute_outputs(Rollout(), ["852 3001 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
     
    484484Was that diff correct?
    485485Building WebKit
    486 Committed r49824: <http://trac.webkit.org/changeset/49824>
     486Committed r49824: <https://trac.webkit.org/changeset/49824>
    487487MOCK reopen_bug 50000 with comment 'Reverted r852, r963, and r999 for reason:
    488488
    489489Reason
    490490
    491 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     491Committed r49824: <https://trac.webkit.org/changeset/49824>'
    492492MOCK reopen_bug 50005 with comment 'Reverted r852, r963, and r999 for reason:
    493493
    494494Reason
    495495
    496 Committed r49824: <http://trac.webkit.org/changeset/49824>'
     496Committed r49824: <https://trac.webkit.org/changeset/49824>'
    497497"""
    498498        self.assert_execute_outputs(Rollout(), ["852 999 963", "Reason", "Description"], options=self._default_options(), expected_logs=expected_logs)
  • trunk/Tools/Scripts/webkitpy/tool/commands/newcommitbot_unittest.py

    r211134 r223177  
    8989
    9090Unreviewed, rolling out r142734.
    91 http://trac.webkit.org/changeset/142734
     91https://trac.webkit.org/changeset/142734
    9292https://bugs.webkit.org/show_bug.cgi?id=110018
    9393
     
    125125
    126126Unreviewed, rolling out r134927 and r134944.
    127 http://trac.webkit.org/changeset/134927
    128 http://trac.webkit.org/changeset/134944
     127https://trac.webkit.org/changeset/134927
     128https://trac.webkit.org/changeset/134944
    129129https://bugs.webkit.org/show_bug.cgi?id=103028
    130130
  • trunk/Tools/Scripts/webkitpy/tool/commands/queues_unittest.py

    r205003 r223177  
    137137            "process_work_item": """Warning, attachment 10001 on bug 50000 has invalid committer (non-committer@example.com)
    138138Warning, attachment 10001 on bug 50000 has invalid committer (non-committer@example.com)
    139 MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-committer@example.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
     139MOCK setting flag 'commit-queue' to '-' on attachment '10001' with comment 'Rejecting attachment 10001 from commit-queue.\n\nnon-committer@example.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.
    140140
    141141- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.
  • trunk/Tools/Scripts/webkitpy/tool/commands/suggestnominations.py

    r170637 r223177  
    203203
    204204        if revision.isdigit():
    205             revision = "http://trac.webkit.org/changeset/" + revision
     205            revision = "https://trac.webkit.org/changeset/" + revision
    206206        counter['commits'] += "  commit: %s on %s by %s (%s)\n" % (revision, commit_date, author_name, author_email)
    207207
  • trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py

    r220715 r223177  
    174174MOCK comment
    175175
    176 Committed r9876: <http://trac.webkit.org/changeset/9876>
     176Committed r9876: <https://trac.webkit.org/changeset/9876>
    177177--- End comment ---
    178178
  • trunk/Tools/Scripts/webkitpy/tool/servers/data/rebaselineserver/util.js

    r90336 r223177  
    9191function getTracUrl(layoutTestPath)
    9292{
    93   return 'http://trac.webkit.org/browser/trunk/LayoutTests/' + layoutTestPath;
     93  return 'https://trac.webkit.org/browser/trunk/LayoutTests/' + layoutTestPath;
    9494}
    9595
  • trunk/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py

    r202319 r223177  
    3838        capture = OutputCapture()
    3939        step = CloseBugForLandDiff(MockTool(), MockOptions())
    40         expected_logs = "Committed r49824: <http://trac.webkit.org/changeset/49824>\nNo bug id provided.\n"
     40        expected_logs = "Committed r49824: <https://trac.webkit.org/changeset/49824>\nNo bug id provided.\n"
    4141        capture.assert_outputs(self, step.run, [{"commit_text": "Mock commit text"}], expected_logs=expected_logs)
  • trunk/Tools/Scripts/webkitpy/tool/steps/commit_unittest.py

    r174136 r223177  
    5151
    5252        tool.executive = MockExecutive(should_log=True, should_throw_when_run=False)
    53         expected_logs = "Committed r49824: <http://trac.webkit.org/changeset/49824>\n"
     53        expected_logs = "Committed r49824: <https://trac.webkit.org/changeset/49824>\n"
    5454        capture.assert_outputs(self, step.run, [state], expected_logs=expected_logs)
    5555
     
    5858        }
    5959        expected_logs = """MOCK run_and_throw_if_fail: ['mock-check-webkit-style', '--diff-files', 'platform/chromium/%s'], cwd=/mock-checkout
    60 Committed r49824: <http://trac.webkit.org/changeset/49824>
     60Committed r49824: <https://trac.webkit.org/changeset/49824>
    6161""" % filename
    6262        capture.assert_outputs(self, step.run, [state], expected_logs=expected_logs)
  • trunk/Tools/Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py

    r174136 r223177  
    4848        "Blocked Bug's Description"
    4949        http://bug.example.com/12345
    50         http://trac.webkit.org/changeset/12345
     50        https://trac.webkit.org/changeset/12345
    5151'''
    5252
     
    5959        Reverted changeset:
    6060
    61         http://trac.webkit.org/changeset/12345
     61        https://trac.webkit.org/changeset/12345
    6262'''
    6363
     
    7272        "r12345's Description"
    7373        http://bug.example.com/12345
    74         http://trac.webkit.org/changeset/12345
     74        https://trac.webkit.org/changeset/12345
    7575
    7676        "r12346's Description"
    7777        http://bug.example.com/12346
    78         http://trac.webkit.org/changeset/12346
     78        https://trac.webkit.org/changeset/12346
    7979
    8080        "r12347's Description"
    8181        http://bug.example.com/12347
    82         http://trac.webkit.org/changeset/12347
     82        https://trac.webkit.org/changeset/12347
    8383'''
    8484
     
    9191        Reverted changesets:
    9292
    93         http://trac.webkit.org/changeset/12345
     93        https://trac.webkit.org/changeset/12345
    9494
    95         http://trac.webkit.org/changeset/12346
     95        https://trac.webkit.org/changeset/12346
    9696
    97         http://trac.webkit.org/changeset/12347
     97        https://trac.webkit.org/changeset/12347
    9898'''
    9999
     
    108108        "r12345's Description"
    109109        http://bug.example.com/12345
    110         http://trac.webkit.org/changeset/12345
     110        https://trac.webkit.org/changeset/12345
    111111
    112         http://trac.webkit.org/changeset/12346
     112        https://trac.webkit.org/changeset/12346
    113113
    114114        "r12347's Description"
    115115        http://bug.example.com/12347
    116         http://trac.webkit.org/changeset/12347
     116        https://trac.webkit.org/changeset/12347
    117117'''
    118118
     
    131131        "Blocked Bug's Description"
    132132        http://bug.example.com/12345
    133         http://trac.webkit.org/changeset/12345
     133        https://trac.webkit.org/changeset/12345
    134134"""
    135135
     
    145145        "r12345's Description"
    146146        http://bug.example.com/12345
    147         http://trac.webkit.org/changeset/12345
     147        https://trac.webkit.org/changeset/12345
    148148
    149149        "r12346's Description"
    150150        http://bug.example.com/12346
    151         http://trac.webkit.org/changeset/12346
     151        https://trac.webkit.org/changeset/12346
    152152
    153153        "r12347's Description"
    154154        http://bug.example.com/12347
    155         http://trac.webkit.org/changeset/12347
     155        https://trac.webkit.org/changeset/12347
    156156'''
    157157
Note: See TracChangeset for help on using the changeset viewer.