Changeset 223567 in webkit


Ignore:
Timestamp:
Oct 17, 2017 12:17:33 PM (7 years ago)
Author:
dino@apple.com
Message:

WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
​https://bugs.webkit.org/show_bug.cgi?id=178223
<rdar://problem/34597567>

Reviewed by Antoine Quint.

Source/WebCore:

Remove the limit of 4k on the width/height of the renderbuffer.

Test: fast/canvas/webgl/large-drawing-buffer-resize.html

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::reshape):

LayoutTests:

Test that resizes an already large buffer to make sure it
doesn't get clamped to 4k.

  • fast/canvas/webgl/large-drawing-buffer-resize-expected.txt: Added.
  • fast/canvas/webgl/large-drawing-buffer-resize.html: Added.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r223565 r223567  
     12017-10-16  Dean Jackson  <dino@apple.com>
     2
     3        WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
     4        https://bugs.webkit.org/show_bug.cgi?id=178223
     5        <rdar://problem/34597567>
     6
     7        Reviewed by Antoine Quint.
     8
     9        Test that resizes an already large buffer to make sure it
     10        doesn't get clamped to 4k.
     11
     12        * fast/canvas/webgl/large-drawing-buffer-resize-expected.txt: Added.
     13        * fast/canvas/webgl/large-drawing-buffer-resize.html: Added.
     14
    1152017-10-17  John Wilander  <wilander@apple.com>
    216

  • trunk/LayoutTests/platform/ios/TestExpectations

    r223565 r223567  
    29512951webkit.org/b/177547 imported/w3c/web-platform-tests/fetch/security/dangling-markup-mitigation-data-url.tentative.sub.html [ Pass Failure ]
    29522952
     2953# macOS only test
     2954fast/canvas/webgl/large-drawing-buffer-resize.html [ Skip ]

  • trunk/Source/WebCore/ChangeLog

    r223565 r223567  
     12017-10-16  Dean Jackson  <dino@apple.com>
     2
     3        WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas
     4        https://bugs.webkit.org/show_bug.cgi?id=178223
     5        <rdar://problem/34597567>
     6
     7        Reviewed by Antoine Quint.
     8
     9        Remove the limit of 4k on the width/height of the renderbuffer.
     10
     11        Test: fast/canvas/webgl/large-drawing-buffer-resize.html
     12
     13        * html/canvas/WebGLRenderingContextBase.cpp:
     14        (WebCore::WebGLRenderingContextBase::reshape):
     15
    1162017-10-17  John Wilander  <wilander@apple.com>
    217

  • trunk/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp

    r223563 r223567  
    847847    // know if the underlying FBO uses textures or renderbuffers.
    848848    GC3Dint maxSize = std::min(m_maxTextureSize, m_maxRenderbufferSize);
    849     // Limit drawing buffer size to 4k to avoid memory exhaustion.
    850     const int sizeUpperLimit = 4096;
    851     maxSize = std::min(maxSize, sizeUpperLimit);
    852849    GC3Dint maxWidth = std::min(maxSize, m_maxViewportDims[0]);
    853850    GC3Dint maxHeight = std::min(maxSize, m_maxViewportDims[1]);
Note: See TracChangeset for help on using the changeset viewer.