Changeset 223643 in webkit

Timestamp:

Oct 18, 2017 5:46:15 PM (7 years ago)

Author:

commit-queue@webkit.org

Message:

update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
​https://bugs.webkit.org/show_bug.cgi?id=178381

Patch by Fujii Hironori <Fujii Hironori> on 2017-10-18
Reviewed by Alexey Proskuryakov.

The web server developer.apple.com seems to reject HTTP requests
without Accept header field.

• Scripts/update-webkit-dependency: Add 'Accept' header field to requests.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/update-webkit-dependency (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-18  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        update-webkit-auxiliary-libs can't download WebKitAuxiliaryLibrary.zip due to 403 Forbidden
+        https://bugs.webkit.org/show_bug.cgi?id=178381
+
+        Reviewed by Alexey Proskuryakov.
+
+        The web server developer.apple.com seems to reject HTTP requests
+        without Accept header field.
+
+        * Scripts/update-webkit-dependency: Add 'Accept' header field to requests.
+
 2017-10-18  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/Scripts/update-webkit-dependency

@@ -96 +96 @@
 # to request just the first byte) so that we don't have to retrieve the entire file.
 $ua->max_size(0);
-my $response = $ua->get($libsURL, "Range", "bytes=0-0");
+my $response = $ua->get($libsURL, Accept => '*/*', Range => "bytes=0-0");
 $ua->max_size(undef);
 
@@ -192 +192 @@
 print "Downloading $zipFile...\n\n";
 print "$libsURL\n";
-my $result = getstore($libsURL, File::Spec->catfile($tmpAbsDir, $zipFile));
-die "Couldn't download $zipFile!" if is_error($result);
+my $request = HTTP::Request->new(GET => $libsURL);
+$request->header(Accept => "*/*");
+$response = $ua->request($request, File::Spec->catfile($tmpAbsDir, $zipFile));
+die "Couldn't download $zipFile!" if is_error($response->code);
 
 my $zip = Archive::Zip->new(File::Spec->catfile($tmpAbsDir, $zipFile));
@@ -212 +214 @@
 }
 
-$result = $zip->extractTree("", $tmpAbsDir);
+my $result = $zip->extractTree("", $tmpAbsDir);
 die "Couldn't unzip $zipFile." if $result != AZ_OK;