Changeset 223693 in webkit

Timestamp:

Oct 19, 2017 11:18:32 AM (7 years ago)

Author:

keith_miller@apple.com

Message:

REGRESSION (r223476): WebCore exports symbols with names belonging to other frameworks
​https://bugs.webkit.org/show_bug.cgi?id=178424

Reviewed by David Kilzer.

This patch moves the wrapper function sharing the name of the externed function
to the source file and marks it as always inline. Marking it as inline prevents
the framework from exporting it.

• wtf/cocoa/SoftLinking.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/cocoa/SoftLinking.h (modified) (2 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2017-10-19  Keith Miller  <keith_miller@apple.com>
+
+        REGRESSION (r223476): WebCore exports symbols with names belonging to other frameworks
+        https://bugs.webkit.org/show_bug.cgi?id=178424
+
+        Reviewed by David Kilzer.
+
+        This patch moves the wrapper function sharing the name of the externed function
+        to the source file and marks it as always inline. Marking it as inline prevents
+        the framework from exporting it.
+
+        * wtf/cocoa/SoftLinking.h:
+
 2017-10-18  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WTF/wtf/cocoa/SoftLinking.h

@@ -477 +477 @@
         return softLink##framework##functionName parameterNames; \
     } \
+    } \
+    ALWAYS_INLINE resultType functionName parameterDeclarations \
+    {\
+        return functionNamespace::softLink##framework##functionName parameterNames; \
     }
 
@@ -495 +499 @@
         return softLink##framework##functionName parameterNames; \
     } \
-    } \
-    resultType functionName parameterDeclarations \
-    {\
-        return functionNamespace::softLink##framework##functionName parameterNames; \
     }