Changeset 223710 in webkit

Timestamp:

Oct 19, 2017 1:51:02 PM (7 years ago)

Author:

timothy_horton@apple.com

Message:

Display link bringup can block the main thread for ~150ms during WKWebView init
​https://bugs.webkit.org/show_bug.cgi?id=178524

Reviewed by Dean Jackson.

• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
(WebKit::RemoteLayerTreeDrawingAreaProxy::displayLinkHandler):
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
Lazily initialize the display link at first use.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h (modified) (1 diff)
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm (modified) (4 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2017-10-19  Tim Horton  <timothy_horton@apple.com>
+
+        Display link bringup can block the main thread for ~150ms during WKWebView init
+        https://bugs.webkit.org/show_bug.cgi?id=178524
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
+        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::RemoteLayerTreeDrawingAreaProxy):
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::displayLinkHandler):
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
+        Lazily initialize the display link at first use.
+
 2017-10-19  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h

@@ -73 +73 @@
 #endif
 
+#if PLATFORM(IOS)
+    WKOneShotDisplayLinkHandler *displayLinkHandler();
+#endif
+
     float indicatorScale(WebCore::IntSize contentsSize) const;
     void updateDebugIndicator() override;

trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

@@ -110 +110 @@
     : DrawingAreaProxy(DrawingAreaTypeRemoteLayerTree, webPageProxy)
     , m_remoteLayerTreeHost(*this)
-#if PLATFORM(IOS)
-    , m_displayLinkHandler(adoptNS([[WKOneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this]))
-#endif
 {
 #if USE(IOSURFACE)
@@ -135 +132 @@
 #endif
 }
+
+#if PLATFORM(IOS)
+WKOneShotDisplayLinkHandler *RemoteLayerTreeDrawingAreaProxy::displayLinkHandler()
+{
+    if (!m_displayLinkHandler)
+        m_displayLinkHandler = adoptNS([[WKOneShotDisplayLinkHandler alloc] initWithDrawingAreaProxy:this]);
+    return m_displayLinkHandler.get();
+}
+#endif
 
 void RemoteLayerTreeDrawingAreaProxy::sizeDidChange()
@@ -234 +240 @@
     if (std::exchange(m_didUpdateMessageState, NeedsDidUpdate) == MissedCommit)
         didRefreshDisplay();
-    [m_displayLinkHandler schedule];
+    [displayLinkHandler() schedule];
 #else
     m_didUpdateMessageState = NeedsDidUpdate;
@@ -407 +413 @@
         m_didUpdateMessageState = MissedCommit;
 #if PLATFORM(IOS)
-        [m_displayLinkHandler pause];
+        [displayLinkHandler() pause];
 #endif
         return;