Changeset 223745 in webkit

Timestamp:

Oct 20, 2017 12:35:16 AM (7 years ago)

Author:

Yusuke Suzuki

Message:

[ARM64] static_cast<int32_t>() in BinaryOpNode::emitBytecode() prevents op_unsigned emission
​https://bugs.webkit.org/show_bug.cgi?id=178379

Reviewed by Saam Barati.

We reuse jsNumber's checking mechanism here to precisely check the generated number is within uint32_t
in bytecode compiler. This is reasonable since the NumberNode will generate the exact this JSValue.

• bytecompiler/NodesCodegen.cpp:

(JSC::BinaryOpNode::emitBytecode):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• bytecompiler/NodesCodegen.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-10-20  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [ARM64] static_cast<int32_t>() in BinaryOpNode::emitBytecode() prevents op_unsigned emission
+        https://bugs.webkit.org/show_bug.cgi?id=178379
+
+        Reviewed by Saam Barati.
+
+        We reuse jsNumber's checking mechanism here to precisely check the generated number is within uint32_t
+        in bytecode compiler. This is reasonable since the NumberNode will generate the exact this JSValue.
+
+        * bytecompiler/NodesCodegen.cpp:
+        (JSC::BinaryOpNode::emitBytecode):
+
 2017-10-20  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

@@ -1994 +1994 @@
                 return UInt32Result::UInt32;
             if (node->isNumber() && static_cast<NumberNode*>(node)->isIntegerNode()) {
-                int32_t value = static_cast<int32_t>(static_cast<IntegerNode*>(node)->value());
-                if (value >= 0)
+                auto value = jsNumber(static_cast<NumberNode*>(node)->value());
+                if (value.isInt32() && value.asInt32() >= 0)
                     return UInt32Result::Constant;
             }