Changeset 223765 in webkit

Timestamp:

Oct 20, 2017 9:10:06 AM (7 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r222709 and r223572.
​https://bugs.webkit.org/show_bug.cgi?id=178587

Still getting mac-wk2 EWS bots stuck (Requested by ap on
#webkit).

Reverted changesets:

"Log stack-trace for run-webkit-tests when interrupted"
​https://bugs.webkit.org/show_bug.cgi?id=176393
​https://trac.webkit.org/changeset/222709

"webkitpy: Hang when workers write to the same stack trace
file"
​https://bugs.webkit.org/show_bug.cgi?id=178402
​https://trac.webkit.org/changeset/223572

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/interupt_debugging.py (deleted)
• Scripts/webkitpy/layout_tests/run_webkit_tests.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-20  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r222709 and r223572.
+        https://bugs.webkit.org/show_bug.cgi?id=178587
+
+        Still getting mac-wk2 EWS bots stuck (Requested by ap on
+        #webkit).
+
+        Reverted changesets:
+
+        "Log stack-trace for run-webkit-tests when interrupted"
+        https://bugs.webkit.org/show_bug.cgi?id=176393
+        https://trac.webkit.org/changeset/222709
+
+        "webkitpy: Hang when workers write to the same stack trace
+        file"
+        https://bugs.webkit.org/show_bug.cgi?id=178402
+        https://trac.webkit.org/changeset/223572
+
 2017-10-19  Nan Wang  <n_wang@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

@@ -36 +36 @@
 
 from webkitpy.common.host import Host
-from webkitpy.common.interupt_debugging import log_stack_trace_on_cntrl_c, log_stack_trace_on_term
 from webkitpy.layout_tests.controllers.manager import Manager
 from webkitpy.layout_tests.models.test_run_results import INTERRUPTED_EXIT_STATUS
@@ -74 +73 @@
         print >> stderr, str(e)
         return EXCEPTIONAL_EXIT_STATUS
-
-    stack_trace_path = host.filesystem.join(port.results_directory(), 'python_stack_trace.txt')
-    log_stack_trace_on_cntrl_c(output_file=stack_trace_path)
-    log_stack_trace_on_term(output_file=stack_trace_path)
 
     if options.print_expectations: