Changeset 223881 in webkit

Timestamp:

Oct 24, 2017 12:25:08 AM (6 years ago)

Author:

n_wang@apple.com

Message:

AX: Crash at -[WebAccessibilityObjectWrapper _accessibilityMinValue] + 24
​https://bugs.webkit.org/show_bug.cgi?id=178697

Reviewed by Chris Fleizach.

Source/WebCore:

When we are calling _accessibilityMinValue and _accessibilityMaxValue on iOS,
it might cause crash if the AX object has already been detached. Fixed this
by adding the necessary checks.

Test: accessibility/ios-simulator/slider-min-value-crash.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _accessibilityMinValue]):
(-[WebAccessibilityObjectWrapper _accessibilityMaxValue]):

LayoutTests:

• accessibility/ios-simulator/slider-min-value-crash-expected.txt: Added.
• accessibility/ios-simulator/slider-min-value-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/ios-simulator/slider-min-value-crash-expected.txt (added)
• LayoutTests/accessibility/ios-simulator/slider-min-value-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-24  Nan Wang  <n_wang@apple.com>
+
+        AX: Crash at -[WebAccessibilityObjectWrapper _accessibilityMinValue] + 24
+        https://bugs.webkit.org/show_bug.cgi?id=178697
+
+        Reviewed by Chris Fleizach.
+
+        * accessibility/ios-simulator/slider-min-value-crash-expected.txt: Added.
+        * accessibility/ios-simulator/slider-min-value-crash.html: Added.
+
 2017-10-23  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-24  Nan Wang  <n_wang@apple.com>
+
+        AX: Crash at -[WebAccessibilityObjectWrapper _accessibilityMinValue] + 24
+        https://bugs.webkit.org/show_bug.cgi?id=178697
+
+        Reviewed by Chris Fleizach.
+
+        When we are calling _accessibilityMinValue and _accessibilityMaxValue on iOS, 
+        it might cause crash if the AX object has already been detached. Fixed this 
+        by adding the necessary checks.
+
+        Test: accessibility/ios-simulator/slider-min-value-crash.html
+
+        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
+        (-[WebAccessibilityObjectWrapper _accessibilityMinValue]):
+        (-[WebAccessibilityObjectWrapper _accessibilityMaxValue]):
+
 2017-10-23  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

@@ -1086 +1086 @@
 - (CGFloat)_accessibilityMinValue
 {
+    if (![self _prepareAccessibilityCall])
+        return 0;
+    
     return m_object->minValueForRange();
 }
@@ -1091 +1094 @@
 - (CGFloat)_accessibilityMaxValue
 {
+    if (![self _prepareAccessibilityCall])
+        return 0;
+    
     return m_object->maxValueForRange();
 }