Changeset 223927 in webkit

Timestamp:

Oct 24, 2017, 2:55:36 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
​https://bugs.webkit.org/show_bug.cgi?id=178745

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-10-24
Reviewed by Brian Burg.

• UserInterface/Views/DOMTreeUpdater.js:

(WI.DOMTreeUpdater.prototype._updateModifiedNodes):
An earlier tree element update might have caused this other tree element's
waiting to be updated to actually be removed. So just skip past them.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeUpdater.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-10-24  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Uncaught Exception: TypeError: null is not an object (evaluating 'this.treeOutline.isXMLMimeType')
+        https://bugs.webkit.org/show_bug.cgi?id=178745
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/DOMTreeUpdater.js:
+        (WI.DOMTreeUpdater.prototype._updateModifiedNodes):
+        An earlier tree element update might have caused this other tree element's
+        waiting to be updated to actually be removed. So just skip past them.
+
 2017-10-24  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeUpdater.js

@@ -121 +121 @@
 
         for (let parentTreeElement of parentElementsToUpdate) {
-            parentTreeElement.updateTitle();
-            parentTreeElement.updateChildren();
+            if (parentTreeElement.treeOutline) {
+                parentTreeElement.updateTitle();
+                parentTreeElement.updateChildren();
+            }
         }