Changeset 223931 in webkit

Timestamp:

Oct 24, 2017, 3:11:59 PM (8 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Console Drawer resizing doesn't match cursor position
​https://bugs.webkit.org/show_bug.cgi?id=178753
<rdar://problem/35160484>

Reviewed by Brian Burg.

• UserInterface/Views/ConsoleDrawer.js:

(WI.ConsoleDrawer.prototype._updateDrawerHeight):
Drive-by fix an early return that would never have worked.

• UserInterface/Views/Main.css:

(#content):
Give the #content a flex grow of 1. This causes the space to grow as it
already was but now it does not affect the size of the fixed height sibling.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ConsoleDrawer.js (modified) (1 diff)
• UserInterface/Views/Main.css (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-10-24  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Console Drawer resizing doesn't match cursor position
+        https://bugs.webkit.org/show_bug.cgi?id=178753
+        <rdar://problem/35160484>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/ConsoleDrawer.js:
+        (WI.ConsoleDrawer.prototype._updateDrawerHeight):
+        Drive-by fix an early return that would never have worked.
+
+        * UserInterface/Views/Main.css:
+        (#content):
+        Give the #content a flex grow of 1. This causes the space to grow as it
+        already was but now it does not affect the size of the fixed height sibling.
+
 2017-10-24  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleDrawer.js

@@ -148 +148 @@
         const maximumHeight = this.element.parentNode.offsetHeight - 100;
 
-        height = Number.constrain(height, minimumHeight, maximumHeight);
-        if (height === this.element.style.height)
+        let heightCSSValue = Number.constrain(height, minimumHeight, maximumHeight) + "px";
+        if (this.element.style.height === heightCSSValue)
             return;
 
-        this.element.style.height = height + "px";
+        this.element.style.height = heightCSSValue;
 
         this.dispatchEventToListeners(WI.ConsoleDrawer.Event.Resized);

trunk/Source/WebInspectorUI/UserInterface/Views/Main.css

@@ -152 +152 @@
     display: flex;
     height: 100%; /* This reduces paint areas when typing in the console. http://webkit.org/b/145324 */
+    flex: 1;
 }