Changeset 223992 in webkit

Timestamp:

Oct 25, 2017, 4:21:38 PM (8 years ago)

Author:

Simon Fraser

Message:

Aliasing of text in CSS specs is blocky and ugly
​https://bugs.webkit.org/show_bug.cgi?id=174946
Source/WebCore:

rdar://problem/33594542

Reviewed by Dean Jackson.

The PaintedContentRequest relating to subpixel-antialiased text was failing to be
satisfied if the text content in a composited layer was nested inside descendant
RenderLayers, because RenderLayer::isVisuallyNonEmpty() returned early. If this
function is passed a request, we can't return until we've satisfied the request
(which triggers the checking of descendant layers).

Test: compositing/contents-format/subpixel-antialiased-nested-layer.html

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

LayoutTests:

Reviewed by Dean Jackson.

• compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
• compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (added)
• LayoutTests/compositing/contents-format/subpixel-antialiased-nested-layer.html (added)
• LayoutTests/platform/ios/compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-10-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Aliasing of text in CSS specs is blocky and ugly
+        https://bugs.webkit.org/show_bug.cgi?id=174946
+
+        Reviewed by Dean Jackson.
+
+        * compositing/contents-format/subpixel-antialiased-nested-layer-expected.txt: Added.
+        * compositing/contents-format/subpixel-antialiased-nested-layer.html: Added.
+
 2017-10-25  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-25  Simon Fraser  <simon.fraser@apple.com>
+
+        Aliasing of text in CSS specs is blocky and ugly
+        https://bugs.webkit.org/show_bug.cgi?id=174946
+        rdar://problem/33594542
+
+        Reviewed by Dean Jackson.
+
+        The PaintedContentRequest relating to subpixel-antialiased text was failing to be
+        satisfied if the text content in a composited layer was nested inside descendant
+        RenderLayers, because RenderLayer::isVisuallyNonEmpty() returned early. If this
+        function is passed a request, we can't return until we've satisfied the request
+        (which triggers the checking of descendant layers).
+
+        Test: compositing/contents-format/subpixel-antialiased-nested-layer.html
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::calculateClipRects const):
+
 2017-10-25  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -6453 +6453 @@
 
     if (renderer().isRenderReplaced() || hasOverflowControls()) {
-        if (request)
-            request->setHasPaintedContent();
-        return true;
+        if (!request)
+            return true;
+
+        request->setHasPaintedContent();
+        if (request->isSatisfied())
+            return true;
     }
 
     if (hasVisibleBoxDecorationsOrBackground()) {
-        if (request)
-            request->setHasPaintedContent();
-        return true;
-    }
-    
+        if (!request)
+            return true;
+
+        request->setHasPaintedContent();
+        if (request->isSatisfied())
+            return true;
+    }
+
     PaintedContentRequest localRequest;
     if (!request)