Changeset 224045 in webkit


Ignore:
Timestamp:
Oct 26, 2017 1:22:39 PM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Remove FrameView::serviceScriptedAnimations and Document::serviceScriptedAnimations
https://bugs.webkit.org/show_bug.cgi?id=178879

Patch by Antoine Quint <Antoine Quint> on 2017-10-26
Reviewed by Dean Jackson.

There are no call sites for FrameView::serviceScriptedAnimations() and that method is the
only call site for Document::serviceScriptedAnimations(), so both can go.

  • dom/Document.cpp:

(WebCore::Document::serviceScriptedAnimations): Deleted.

  • dom/Document.h:
  • page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations): Deleted.

  • page/FrameView.h:
Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r224041 r224045  
     12017-10-26  Antoine Quint  <graouts@apple.com>
     2
     3        Remove FrameView::serviceScriptedAnimations and Document::serviceScriptedAnimations
     4        https://bugs.webkit.org/show_bug.cgi?id=178879
     5
     6        Reviewed by Dean Jackson.
     7
     8        There are no call sites for FrameView::serviceScriptedAnimations() and that method is the
     9        only call site for Document::serviceScriptedAnimations(), so both can go.
     10
     11        * dom/Document.cpp:
     12        (WebCore::Document::serviceScriptedAnimations): Deleted.
     13        * dom/Document.h:
     14        * page/FrameView.cpp:
     15        (WebCore::FrameView::serviceScriptedAnimations): Deleted.
     16        * page/FrameView.h:
     17
    1182017-10-26  Chris Dumez  <cdumez@apple.com>
    219
  • trunk/Source/WebCore/dom/Document.cpp

    r224011 r224045  
    63806380}
    63816381
    6382 void Document::serviceScriptedAnimations(double timestamp)
    6383 {
    6384     if (!m_scriptedAnimationController)
    6385         return;
    6386     m_scriptedAnimationController->serviceScriptedAnimations(timestamp);
    6387 }
    6388 
    63896382void Document::clearScriptedAnimationController()
    63906383{
  • trunk/Source/WebCore/dom/Document.h

    r223999 r224045  
    11471147    int requestAnimationFrame(Ref<RequestAnimationFrameCallback>&&);
    11481148    void cancelAnimationFrame(int id);
    1149     void serviceScriptedAnimations(double timestamp);
    11501149
    11511150    EventTarget* errorEventTarget() final;
  • trunk/Source/WebCore/page/FrameView.cpp

    r224032 r224045  
    31933193}
    31943194
    3195 void FrameView::serviceScriptedAnimations()
    3196 {
    3197     for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext()) {
    3198         frame->view()->serviceScrollAnimations();
    3199         frame->animation().serviceAnimations();
    3200     }
    3201 
    3202     if (!frame().document() || !frame().document()->domWindow())
    3203         return;
    3204 
    3205     Vector<RefPtr<Document>> documents;
    3206     for (auto* frame = m_frame.ptr(); frame; frame = frame->tree().traverseNext())
    3207         documents.append(frame->document());
    3208 
    3209     double timestamp = frame().document()->domWindow()->nowTimestamp();
    3210     for (auto& document : documents)
    3211         document->serviceScriptedAnimations(timestamp);
    3212 }
    3213 
    32143195bool FrameView::isTransparent() const
    32153196{
  • trunk/Source/WebCore/page/FrameView.h

    r223853 r224045  
    144144    bool useCustomFixedPositionLayoutRect() const { return false; }
    145145#endif
    146 
    147     WEBCORE_EXPORT void serviceScriptedAnimations();
    148146
    149147    void willRecalcStyle();
Note: See TracChangeset for help on using the changeset viewer.