Changeset 224117 in webkit

Timestamp:

Oct 27, 2017 10:16:46 AM (6 years ago)

Author:

eric.carlson@apple.com

Message:

NowPlayingInfo should contain a unique identifier
​https://bugs.webkit.org/show_bug.cgi?id=178872
<rdar://problem/34924012>

Unreviewed, fix a flakey test.

• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:

(-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
(-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-10-27  Eric Carlson  <eric.carlson@apple.com>
+
+        NowPlayingInfo should contain a unique identifier
+        https://bugs.webkit.org/show_bug.cgi?id=178872
+        <rdar://problem/34924012>
+
+        Unreviewed, fix a flakey test.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
+        (-[NowPlayingTestWebView hasActiveNowPlayingSession]): Update _lastUpdatedElapsedTime.
+        (-[NowPlayingTestWebView _handleActiveNowPlayingSessionInfoResponse:title:duration:elapsedTime:]): Deleted.
+
 2017-10-27  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm

@@ -54 +54 @@
         _lastUpdatedTitle = [title copy];
         _lastUpdatedDuration = duration;
+        _lastUpdatedElapsedTime = elapsedTime;
         _lastUniqueIdentifier = uniqueIdentifier;
 
@@ -75 +76 @@
 }
 
-- (void)_handleActiveNowPlayingSessionInfoResponse:(BOOL)hasActiveSession title:(NSString *)title duration:(double)duration elapsedTime:(double)elapsedTime
-{
-    _hasActiveNowPlayingSession = hasActiveSession;
-    _lastUpdatedTitle = [title copy];
-    _lastUpdatedDuration = duration;
-    _lastUpdatedElapsedTime = elapsedTime;
-
-    _receivedNowPlayingInfoResponse = true;
-}
-
 - (void)setWindowVisible:(BOOL)isVisible
 {