Changeset 224127 in webkit

Timestamp:

Oct 27, 2017 1:17:53 PM (7 years ago)

Author:

graouts@webkit.org

Message:

[Web Animations] Use Seconds vs. MonotonicTime to represent times
​https://bugs.webkit.org/show_bug.cgi?id=178950

Reviewed by Dean Jackson.

Animation start times, all expressed in seconds, in the Web Animations API are relative to the timeline
originTime, itself relative to the page's nagigation time (Performance.navigationTime), so it makes more
sense to use Seconds to represent them as opposed to a MonotonicTime.

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::bindingsStartTime const):
(WebCore::WebAnimation::setBindingsStartTime):

• animation/WebAnimation.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• animation/WebAnimation.cpp (modified) (2 diffs)
• animation/WebAnimation.h (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-10-27  Antoine Quint  <graouts@apple.com>
+
+        [Web Animations] Use Seconds vs. MonotonicTime to represent times
+        https://bugs.webkit.org/show_bug.cgi?id=178950
+
+        Reviewed by Dean Jackson.
+
+        Animation start times, all expressed in seconds, in the Web Animations API are relative to the timeline
+        originTime, itself relative to the page's nagigation time (Performance.navigationTime), so it makes more
+        sense to use Seconds to represent them as opposed to a MonotonicTime.
+
+        * animation/WebAnimation.cpp:
+        (WebCore::WebAnimation::bindingsStartTime const):
+        (WebCore::WebAnimation::setBindingsStartTime):
+        * animation/WebAnimation.h:
+
 2017-10-27  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/animation/WebAnimation.cpp

@@ -62 +62 @@
 {
     if (m_startTime)
-        return m_startTime->secondsSinceEpoch().value();
+        return m_startTime->value();
     return std::nullopt;
 }
@@ -71 +71 @@
         m_startTime = std::nullopt;
     else
-        m_startTime = MonotonicTime::fromRawSeconds(startTime.value());
+        m_startTime = Seconds(startTime.value());
 }
 

trunk/Source/WebCore/animation/WebAnimation.h

@@ -27 +27 @@
 
 #include <wtf/Forward.h>
-#include <wtf/MonotonicTime.h>
 #include <wtf/Optional.h>
 #include <wtf/Ref.h>
 #include <wtf/RefCounted.h>
 #include <wtf/RefPtr.h>
+#include <wtf/Seconds.h>
 
 namespace WebCore {
@@ -48 +48 @@
     std::optional<double> bindingsStartTime() const;
     void setBindingsStartTime(std::optional<double>);
-    std::optional<MonotonicTime> startTime() const { return m_startTime; }
-    void setStartTime(MonotonicTime& startTime) { m_startTime = startTime; }
+    std::optional<Seconds> startTime() const { return m_startTime; }
+    void setStartTime(Seconds startTime) { m_startTime = startTime; }
 
     String description();
@@ -57 +57 @@
     RefPtr<AnimationEffect> m_effect;
     RefPtr<AnimationTimeline> m_timeline;
-    std::optional<MonotonicTime> m_startTime;
+    std::optional<Seconds> m_startTime;
 };