Changeset 224310 in webkit


Ignore:
Timestamp:
Nov 1, 2017 6:59:12 PM (6 years ago)
Author:
timothy_horton@apple.com
Message:

Adjust RenderElement size assertion to be more accurate
https://bugs.webkit.org/show_bug.cgi?id=179146

Reviewed by Simon Fraser.

  • rendering/RenderElement.cpp:

Alignment rules for bitfields differ on different platforms. If we're
more truthful in our mimicing the layout of RenderElement, we can avoid
the assertion firing on more configurations.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r224309 r224310  
     12017-11-01  Tim Horton  <timothy_horton@apple.com>
     2
     3        Adjust RenderElement size assertion to be more accurate
     4        https://bugs.webkit.org/show_bug.cgi?id=179146
     5
     6        Reviewed by Simon Fraser.
     7
     8        * rendering/RenderElement.cpp:
     9        Alignment rules for bitfields differ on different platforms. If we're
     10        more truthful in our mimicing the layout of RenderElement, we can avoid
     11        the assertion firing on more configurations.
     12
    1132017-11-01  Mark Lam  <mark.lam@apple.com>
    214
  • trunk/Source/WebCore/rendering/RenderElement.cpp

    r224279 r224310  
    8282
    8383struct SameSizeAsRenderElement : public RenderObject {
    84     uint32_t bitfields;
     84    unsigned bitfields : 24;
    8585    void* firstChild;
    8686    void* lastChild;
Note: See TracChangeset for help on using the changeset viewer.