Changeset 224332 in webkit

Timestamp:

Nov 2, 2017 8:57:49 AM (6 years ago)

Author:

Antti Koivisto

Message:

Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers
​https://bugs.webkit.org/show_bug.cgi?id=179014

Remove overly optimistic non-critical assertion that is hit on WK1 debug.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderBoxModelObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-11-02  Antti Koivisto  <antti@apple.com>
+
+        Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers
+        https://bugs.webkit.org/show_bug.cgi?id=179014
+
+        Remove overly optimistic non-critical assertion that is hit on WK1 debug.
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::removeAndDestroyAllContinuations):
+
 2017-11-02  Frederic Wang  <fwang@igalia.com>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -2536 +2536 @@
     ASSERT(continuationChainNodeMap().contains(this));
     auto& continuationChainNode = *continuationChainNodeMap().get(this);
-    while (continuationChainNode.next) {
-        ASSERT(!continuationChainNode.next->renderer->firstChild());
+    while (continuationChainNode.next)
         continuationChainNode.next->renderer->removeFromParentAndDestroy();
-    }
     removeFromContinuationChain();
 }