Changeset 224658 in webkit

Timestamp:

Nov 9, 2017 5:48:40 PM (6 years ago)

Author:

Jonathan Bedard

Message:

webkitpy: Unify version parsing code
​https://bugs.webkit.org/show_bug.cgi?id=179426
<rdar://problem/35415191>

Unreviewed fix to r224657.

• Scripts/webkitpy/common/version.py:

(Version.init): Check if an object is iterable.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/version.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2017-11-09  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: Unify version parsing code
+        https://bugs.webkit.org/show_bug.cgi?id=179426
+        <rdar://problem/35415191>
+
+        Unreviewed fix to r224657.
+
+        * Scripts/webkitpy/common/version.py:
+        (Version.__init__): Check if an object is iterable.
+
 2017-11-09  Jonathan Bedard  <jbedard@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/version.py

@@ -21 +21 @@
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
+import collections
 
 class Version(object):
@@ -37 +38 @@
                 self[i] = ver.split('.')[i]
             return
-        elif isinstance(ver, list) or isinstance(ver, Version) or isinstance(ver, tuple):
+        elif isinstance(ver, Version) or isinstance(ver, collections.Iterable):
             for i in xrange(len(ver)):
                 self[i] = ver[i]