Changeset 224975 in webkit


Ignore:
Timestamp:
Nov 17, 2017 11:29:34 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Web Inspector: Remove FIXMEs for GTK+ missing icons
​https://bugs.webkit.org/show_bug.cgi?id=155282
<rdar://problem/25076615>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-11-17
Reviewed by Michael Catanzaro.

  • UserInterface/Views/PathComponentIcons.css:

(.source-icon .icon):
(body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,): Deleted.

  • UserInterface/Views/ResourceIcons.css:

(.large .resource-icon.resource-type-websocket .icon):
(body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,): Deleted.
(body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,): Deleted.
All ports now share the same images.

Location:
trunk/Source/WebInspectorUI
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r224906 r224975  
     12017-11-17  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Remove FIXMEs for GTK+ missing icons
     4        https://bugs.webkit.org/show_bug.cgi?id=155282
     5        <rdar://problem/25076615>
     6
     7        Reviewed by Michael Catanzaro.
     8
     9        * UserInterface/Views/PathComponentIcons.css:
     10        (.source-icon .icon):
     11        (body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,): Deleted.
     12        * UserInterface/Views/ResourceIcons.css:
     13        (.large .resource-icon.resource-type-websocket .icon):
     14        (body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,): Deleted.
     15        (body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,): Deleted.
     16        All ports now share the same images.
     17
    1182017-11-15  Nikita Vasilyev  <nvasilyev@apple.com>
    219

  • trunk/Source/WebInspectorUI/UserInterface/Views/PathComponentIcons.css

    r215920 r224975  
    111111    content: url("../Images/Source.svg");
    112112}
    113 
    114 /* FIXME: <https://webkit.org/b/155282> [GTK] Web Inspector: Add new GTK+ icons for different Heap Allocations Timeline Views (Heap Snapshots) */
    115 body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon,
    116 body:not(.mac-platform, .windows-platform) .heap-snapshot-summary-icon .icon,
    117 body:not(.mac-platform, .windows-platform) .heap-snapshot-instances-icon .icon,
    118 body:not(.mac-platform, .windows-platform) .snapshot-diff-icon .icon {
    119     content: url(../Images/ResultLine.svg);
    120 }

  • trunk/Source/WebInspectorUI/UserInterface/Views/ResourceIcons.css

    r224142 r224975  
    132132    content: image-set(url(../Images/WebSocketLarge.png) 1x, url(../Images/WebSocketLarge@2x.png) 2x);
    133133}
    134 
    135 /* FIXME: <https://webkit.org/b/177642> Web Inspector: Add GTK icons for Beacon / Ping requests */
    136 body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-ping .icon,
    137 body:not(.mac-platform, .windows-platform) .resource-icon.resource-type-beacon .icon {
    138     content: image-set(url(../Images/DocumentGeneric.png) 1x, url(../Images/DocumentGeneric@2x.png) 2x);
    139 }
    140 body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-ping .icon,
    141 body:not(.mac-platform, .windows-platform) .large .resource-icon.resource-type-beacon .icon {
    142     content: image-set(url(../Images/DocumentGenericLarge.png) 1x, url(../Images/DocumentGenericLarge@2x.png) 2x);
    143 }
Note: See TracChangeset for help on using the changeset viewer.