Changeset 225483 in webkit

Timestamp:

Dec 4, 2017 10:55:07 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Add support ​https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
​https://bugs.webkit.org/show_bug.cgi?id=180359

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-04
Reviewed by Chris Dumez.

This algorithm is needed for implementation of claim.
As per specification, it is run for every client unload, hence why this is put in removeClientUsingRegistration.

• workers/service/server/SWServerRegistration.cpp:

(WebCore::SWServerRegistration::removeClientUsingRegistration):
(WebCore::SWServerRegistration::handleClientUnload):

• workers/service/server/SWServerRegistration.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• workers/service/server/SWServerRegistration.cpp (modified) (2 diffs)
• workers/service/server/SWServerRegistration.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-04  Youenn Fablet  <youenn@apple.com>
+
+        Add support https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
+        https://bugs.webkit.org/show_bug.cgi?id=180359
+
+        Reviewed by Chris Dumez.
+
+        This algorithm is needed for implementation of claim.
+        As per specification, it is run for every client unload, hence why this is put in removeClientUsingRegistration.
+
+        * workers/service/server/SWServerRegistration.cpp:
+        (WebCore::SWServerRegistration::removeClientUsingRegistration):
+        (WebCore::SWServerRegistration::handleClientUnload):
+        * workers/service/server/SWServerRegistration.h:
+
 2017-12-04  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/workers/service/server/SWServerRegistration.cpp

@@ -162 +162 @@
     if (iterator->value.isEmpty())
         m_clientsUsingRegistration.remove(iterator);
+
+    handleClientUnload();
 }
 
@@ -282 +284 @@
 }
 
+// https://w3c.github.io/ServiceWorker/#on-client-unload-algorithm
+void SWServerRegistration::handleClientUnload()
+{
+    if (hasClientsUsingRegistration())
+        return;
+    if (isUninstalling() && tryClear())
+        return;
+    tryActivate();
+}
+
 } // namespace WebCore
 

trunk/Source/WebCore/workers/service/server/SWServerRegistration.h

@@ -91 +91 @@
 
     void activate();
+    void handleClientUnload();
 
     ServiceWorkerRegistrationIdentifier m_identifier;