Changeset 225584 in webkit
- Timestamp:
- Dec 6, 2017 11:43:31 AM (6 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r225583 r225584 1 2017-12-06 Dean Jackson <dino@apple.com> 2 3 Some iOS tests failing after ANGLE update 4 https://bugs.webkit.org/show_bug.cgi?id=180487 5 <rdar://problem/35885969> 6 7 Reviewed by Antoine Quint. 8 9 Unskip some WebGL tests. 10 11 * platform/ios/TestExpectations: 12 1 13 2017-12-06 John Wilander <wilander@apple.com> 2 14 -
trunk/LayoutTests/platform/ios/TestExpectations
r225472 r225584 2958 2958 webgl/1.0.3/conformance/glsl/misc/shaders-with-invariance.html [ Failure ] 2959 2959 webgl/1.0.3/conformance/glsl/misc/shaders-with-name-conflicts.html [ Failure ] 2960 webgl/1.0.3/conformance/glsl/misc/struct-nesting-of-variable-names.html [ Failure ]2961 2960 webgl/1.0.3/conformance/renderbuffers/feedback-loop.html [ Failure ] 2962 2961 webgl/1.0.3/conformance/rendering/point-no-attributes.html [ Failure ] … … 3081 3080 3082 3081 # <rdar://problem/33135669> 3083 webgl/1.0.2/conformance/textures/gl-teximage.html [ Failure ]3084 3082 fast/canvas/webgl/gl-teximage.html [ Failure ] 3085 3083 … … 3301 3299 media/modern-media-controls/time-labels-support/elapsed-time.html [ Skip ] 3302 3300 3303 # Skip WebGL while the ANGLE update has caused many failures3304 webgl [ Skip ]3305 3306 3301 # Requries AVFoundation support <rdar://problem/34502208> 3307 3302 http/tests/images/image-supports-video.html -
trunk/Source/ThirdParty/ANGLE/ChangeLog
r225436 r225584 1 2017-12-06 Dean Jackson <dino@apple.com> 2 3 Some iOS tests failing after ANGLE update 4 https://bugs.webkit.org/show_bug.cgi?id=180487 5 <rdar://problem/35885969> 6 7 Reviewed by Antoine Quint. 8 9 The iOS OpenGL compiler doesn't like function declarations with 10 nameless array parameters. See: 11 <rdar://problem/35885989> Nameless array parameters in function declaration cause compiler error 12 13 While that is being fixed, tell ANGLE's translator to not cull 14 the names from parameters. This is not a bug in ANGLE, so we won't 15 fix it upstream at the moment. 16 17 * src/compiler/translator/ParseContext.cpp: 18 (sh::TParseContext::addFunctionPrototypeDeclaration): 19 1 20 2017-12-01 Michael Catanzaro <mcatanzaro@igalia.com> 2 21 -
trunk/Source/ThirdParty/ANGLE/src/compiler/translator/ParseContext.cpp
r225340 r225584 3241 3241 function->setHasPrototypeDeclaration(); 3242 3242 3243 // WebKit note: We currently pass true instead of false for the last parameter 3244 // here because some compilers have an issue with nameless parameters in function 3245 // declarations. 3243 3246 TIntermFunctionPrototype *prototype = 3244 createPrototypeNodeFromFunction(*function, location, false);3247 createPrototypeNodeFromFunction(*function, location, true); 3245 3248 3246 3249 symbolTable.pop();
Note: See TracChangeset
for help on using the changeset viewer.