Changeset 225739 in webkit

Timestamp:

Dec 11, 2017 12:30:25 AM (6 years ago)

Author:

Carlos Garcia Campos

Message:

WebDriver: get active element should return no such element error when there isn't an active element
​https://bugs.webkit.org/show_bug.cgi?id=180421

Reviewed by Brian Burg.

We currently return unknown error.

Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element

• Session.cpp:

(WebDriver::Session::getActiveElement):

Location:

trunk/Source/WebDriver

Files:

• ChangeLog (modified) (1 diff)
• Session.cpp (modified) (1 diff)

trunk/Source/WebDriver/ChangeLog

@@ +1 @@
+2017-12-11  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        WebDriver: get active element should return no such element error when there isn't an active element
+        https://bugs.webkit.org/show_bug.cgi?id=180421
+
+        Reviewed by Brian Burg.
+
+        We currently return unknown error.
+
+        Fixes: imported/w3c/webdriver/tests/element_retrieval/get_active_element.py::test_missing_document_element
+
+        * Session.cpp:
+        (WebDriver::Session::getActiveElement):
+
 2017-12-04  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebDriver/Session.cpp

@@ -997 +997 @@
             RefPtr<JSON::Object> elementObject = createElement(WTFMove(resultValue));
             if (!elementObject) {
-                completionHandler(CommandResult::fail(CommandResult::ErrorCode::UnknownError));
+                completionHandler(CommandResult::fail(CommandResult::ErrorCode::NoSuchElement));
                 return;
             }