Changeset 225747 in webkit


Ignore:
Timestamp:
Dec 11, 2017 10:09:32 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Turn on ENABLE_APPLICATION_MANIFEST
​https://bugs.webkit.org/show_bug.cgi?id=180562
rdar://problem/35924737

Patch by David Quesada <​david_quesada@apple.com> on 2017-12-11
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • loader/LinkLoader.cpp:

(WebCore::createLinkPreloadResourceClient):

  • loader/cached/CachedResourceRequest.cpp:

Add a missing #include that was implicitly added in the unified source when
the feature is disabled.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
Location:
trunk
Files:
17 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r225746 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * platform/ios-wk2/TestExpectations:
     10        * platform/mac-wk2/TestExpectations:
     11
    1122017-12-11  Dean Jackson  <dino@apple.com>
    213

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r225426 r225747  
    6161
    6262webkit.org/b/170713 imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-022.html [ ImageOnlyFailure ]
     63
     64http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ]
     65http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ]
     66applicationmanifest/ [ Pass ]
    6367
    6468#//////////////////////////////////////////////////////////////////////////////////////////

  • trunk/LayoutTests/platform/mac-wk2/TestExpectations

    r225640 r225747  
    5858imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ]
    5959imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ]
     60
     61http/tests/security/contentSecurityPolicy/manifest-src-allowed.html [ Pass ]
     62http/tests/security/contentSecurityPolicy/manifest-src-blocked.html [ Pass ]
     63applicationmanifest/ [ Pass ]
    6064
    6165#//////////////////////////////////////////////////////////////////////////////////////////

  • trunk/Source/JavaScriptCore/ChangeLog

    r225734 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112017-12-10  Filip Pizlo  <fpizlo@apple.com>
    212

  • trunk/Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;

  • trunk/Source/WebCore/ChangeLog

    r225746 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10        * loader/LinkLoader.cpp:
     11        (WebCore::createLinkPreloadResourceClient):
     12        * loader/cached/CachedResourceRequest.cpp:
     13            Add a missing #include that was implicitly added in the unified source when
     14            the feature is disabled.
     15
    1162017-12-11  Dean Jackson  <dino@apple.com>
    217

  • trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;

  • trunk/Source/WebCore/PAL/ChangeLog

    r225698 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112017-12-08  Konstantin Tokarev  <annulen@yandex.ru>
    212

  • trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;

  • trunk/Source/WebCore/loader/LinkLoader.cpp

    r225564 r225747  
    170170    case CachedResource::LinkPrefetch:
    171171#endif
     172#if ENABLE(APPLICATION_MANIFEST)
     173    case CachedResource::ApplicationManifest:
     174#endif
    172175        // None of these values is currently supported as an `as` value.
    173176        ASSERT_NOT_REACHED();
    174 #if ENABLE(APPLICATION_MANIFEST)
    175     case CachedResource::ApplicationManifest:
    176         // FIXME: Support preloading the manifest.
    177         ASSERT_NOT_REACHED();
    178 #endif
    179177    }
    180178    return nullptr;

  • trunk/Source/WebCore/loader/cache/CachedResourceRequest.cpp

    r225472 r225747  
    3737#include "MemoryCache.h"
    3838#include "SecurityPolicy.h"
     39#include "ServiceWorkerRegistrationData.h"
    3940#include <wtf/NeverDestroyed.h>
    4041

  • trunk/Source/WebKit/ChangeLog

    r225746 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112017-12-11  Dean Jackson  <dino@apple.com>
    212

  • trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r225692 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112017-12-08  Yusuke Suzuki  <utatane.tea@gmail.com>
    212

  • trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;

  • trunk/Tools/ChangeLog

    r225742 r225747  
     12017-12-11  David Quesada  <david_quesada@apple.com>
     2
     3        Turn on ENABLE_APPLICATION_MANIFEST
     4        https://bugs.webkit.org/show_bug.cgi?id=180562
     5        rdar://problem/35924737
     6
     7        Reviewed by Geoffrey Garen.
     8
     9        * Configurations/FeatureDefines.xcconfig:
     10
    1112017-12-11  Zan Dobersek  <zdobersek@igalia.com>
    212

  • trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

    r225507 r225747  
    6767ENABLE_APPLE_PAY_SESSION_V3_IF_NOT_YES = ;
    6868
    69 ENABLE_APPLICATION_MANIFEST = ;
     69ENABLE_APPLICATION_MANIFEST = ENABLE_APPLICATION_MANIFEST;
    7070ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
    7171ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
Note: See TracChangeset for help on using the changeset viewer.