Changeset 225809 in webkit

Timestamp:

Dec 12, 2017 3:01:52 PM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Fetch Event header filtering should apply in CORS mode only
​https://bugs.webkit.org/show_bug.cgi?id=180708

Patch by Youenn Fablet <​youenn@apple.com> on 2017-12-12
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:

Source/WebCore:

Covered by no-longer failing test.

• workers/service/context/ServiceWorkerFetch.cpp: cleaning headers only in case of CORS mode.

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2017-12-12  Youenn Fablet  <youenn@apple.com>
+
+        Fetch Event header filtering should apply in CORS mode only
+        https://bugs.webkit.org/show_bug.cgi?id=180708
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt:
+
 2017-12-12  Javier Fernandez  <jfernandez@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event.https-expected.txt

@@ -9 +9 @@
 PASS Service Worker responds to fetch event with null response body 
 PASS Service Worker fetches other file in fetch event 
-FAIL Service Worker responds to fetch event with POST form assert_unreached: unexpected rejection: assert_equals: expected "POST:application/x-www-form-urlencoded:testName1=testValue1&testName2=testValue2" but got "POST:null:testName1=testValue1&testName2=testValue2" Reached unreachable code
+PASS Service Worker responds to fetch event with POST form 
 PASS Multiple calls of respondWith must throw InvalidStateErrors 
 PASS Service Worker event.respondWith must set the used flag 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-12  Youenn Fablet  <youenn@apple.com>
+
+        Fetch Event header filtering should apply in CORS mode only
+        https://bugs.webkit.org/show_bug.cgi?id=180708
+
+        Reviewed by Alex Christensen.
+
+        Covered by no-longer failing test.
+
+        * workers/service/context/ServiceWorkerFetch.cpp: cleaning headers only in case of CORS mode.
+
 2017-12-12  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/workers/service/context/ServiceWorkerFetch.cpp

@@ -99 +99 @@
     // We are intercepting fetch calls after going through the HTTP layer, which adds some specific headers.
     // Let's clean them so that cross origin checks do not fail.
-    cleanRedirectedRequestForAccessControl(request);
+    if (options.mode == FetchOptions::Mode::Cors)
+        cleanRedirectedRequestForAccessControl(request);
 
     auto requestHeaders = FetchHeaders::create(FetchHeaders::Guard::Immutable, HTTPHeaderMap { request.httpHeaderFields() });