Changeset 225814 in webkit

Timestamp:

Dec 12, 2017 3:13:04 PM (6 years ago)

Author:

BJ Burg

Message:

Web Inspector: SyncTestSuite should complain if passed an async setup/test/teardown function
​https://bugs.webkit.org/show_bug.cgi?id=180717

Reviewed by Devin Rousso.

Source/WebInspectorUI:

• UserInterface/Test/TestSuite.js:

(SyncTestSuite.prototype.addTestCase):
Raise an exception if test/setup/teardown is an async function. It won't work.

LayoutTests:

Add new test cases for more strict requirements for test case arguments.

• inspector/unit-tests/sync-test-suite-expected.txt:
• inspector/unit-tests/sync-test-suite.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/inspector/unit-tests/sync-test-suite-expected.txt (modified) (1 diff)
• LayoutTests/inspector/unit-tests/sync-test-suite.html (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Test/TestSuite.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-12-12  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: SyncTestSuite should complain if passed an async setup/test/teardown function
+        https://bugs.webkit.org/show_bug.cgi?id=180717
+
+        Reviewed by Devin Rousso.
+
+        Add new test cases for more strict requirements for test case arguments.
+
+        * inspector/unit-tests/sync-test-suite-expected.txt:
+        * inspector/unit-tests/sync-test-suite.html:
+
 2017-12-12  Antoine Quint  <graouts@apple.com>
 

trunk/LayoutTests/inspector/unit-tests/sync-test-suite-expected.txt

@@ -14 +14 @@
 PASS: should not be able to specify non-Function `teardown` parameter.
 PASS: should not be able to specify non-Function `teardown` parameter.
+PASS: should not be able to specify async `test` parameter.
+PASS: should not be able to specify async `setup` parameter.
+PASS: should not be able to specify async `teardown` parameter.
 PASS: should not be able to run empty test suite.
 

trunk/LayoutTests/inspector/unit-tests/sync-test-suite.html

@@ -136 +136 @@
         ProtocolTest.log("PASS: should not be able to specify non-Function `teardown` parameter.");
     }
+    try {
+        badArgsSuite.addTestCase({
+            name: "foo",
+            async test() {},
+        });
+        ProtocolTest.log("FAIL: should not be able to specify async `test` parameter.");
+    } catch (e) {
+        ProtocolTest.log("PASS: should not be able to specify async `test` parameter.");
+    }
+    try {
+        badArgsSuite.addTestCase({
+            name: "foo",
+            async setup() {},
+            test() {},
+        });
+        ProtocolTest.log("FAIL: should not be able to specify async `setup` parameter.");
+    } catch (e) {
+        ProtocolTest.log("PASS: should not be able to specify async `setup` parameter.");
+    }
+    try {
+        badArgsSuite.addTestCase({
+            name: "foo",
+            test() {},
+            async teardown() {},
+        });
+        ProtocolTest.log("FAIL: should not be able to specify async `teardown` parameter.");
+    } catch (e) {
+        ProtocolTest.log("PASS: should not be able to specify async `teardown` parameter.");
+    }
+
     let runEmptySuite = ProtocolTest.createSyncSuite("SyncTestSuite.RunEmptySuite");
     try {

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-12-12  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: SyncTestSuite should complain if passed an async setup/test/teardown function
+        https://bugs.webkit.org/show_bug.cgi?id=180717
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Test/TestSuite.js:
+        (SyncTestSuite.prototype.addTestCase):
+        Raise an exception if test/setup/teardown is an async function. It won't work.
+
 2017-12-12  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Test/TestSuite.js

@@ -176 +176 @@
 SyncTestSuite = class SyncTestSuite extends TestSuite
 {
+    addTestCase(testcase)
+    {
+        if ([testcase.setup, testcase.teardown, testcase.test].some((fn) => fn && fn[Symbol.toStringTag] === "AsyncFunction"))
+            throw new Error("Tried to pass a test case with an async `setup`, `test`, or `teardown` function, but this is a synchronous test suite.")
+
+        super.addTestCase(testcase);
+    }
+
     runTestCasesAndFinish()
     {