Changeset 226151 in webkit

Timestamp:

Dec 19, 2017, 3:40:16 PM (7 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration
​https://bugs.webkit.org/show_bug.cgi?id=180998
<rdar://problem/36140424>

Reviewed by Matt Baker.

• UserInterface/Models/Resource.js:

(WI.Resource.prototype.get totalDuration):
(WI.Resource.prototype.get duration): Deleted.
Rename and group getters to be clearer.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._entryForResource):
Use the totalDuration for the network table time column.

• UserInterface/Views/ResourceTimelineDataGridNode.js:

(WI.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar graphDataSource.get secondsPerPixel):
Using the download duration was incorrect here.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/Resource.js (modified) (2 diffs)
• UserInterface/Views/NetworkTableContentView.js (modified) (1 diff)
• UserInterface/Views/ResourceTimelineDataGridNode.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2017-12-19  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Network Table - Update the Time column to include the total duration not just the download duration
+        https://bugs.webkit.org/show_bug.cgi?id=180998
+        <rdar://problem/36140424>
+
+        Reviewed by Matt Baker.
+
+        * UserInterface/Models/Resource.js:
+        (WI.Resource.prototype.get totalDuration):
+        (WI.Resource.prototype.get duration): Deleted.
+        Rename and group getters to be clearer.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView.prototype._entryForResource):
+        Use the totalDuration for the network table time column.
+
+        * UserInterface/Views/ResourceTimelineDataGridNode.js:
+        (WI.ResourceTimelineDataGridNode.prototype._mouseoverRecordBar graphDataSource.get secondsPerPixel):
+        Using the download duration was incorrect here.
+
 2017-12-19  Devin Rousso  <webkit@devinrousso.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/Resource.js

@@ -533 +533 @@
     }
 
-    get duration()
-    {
-        return this.timingData.responseEnd - this.timingData.requestStart;
-    }
-
     get latency()
     {
@@ -546 +541 @@
     {
         return this.timingData.responseEnd - this.timingData.responseStart;
+    }
+
+    get totalDuration()
+    {
+        return this.timingData.responseEnd - this.timingData.startTime;
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -1197 +1197 @@
             resourceSize: resource.size,
             transferSize: !isNaN(resource.networkTotalTransferSize) ? resource.networkTotalTransferSize : resource.estimatedTotalTransferSize,
-            time: resource.duration,
+            time: resource.totalDuration,
             protocol: resource.protocol,
             priority: resource.priority,

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js

@@ -385 +385 @@
 
             let graphDataSource = {
-                get secondsPerPixel() { return resource.duration / WI.ResourceTimelineDataGridNode.PopoverGraphColumnWidthPixels; },
+                get secondsPerPixel() { return resource.totalDuration / WI.ResourceTimelineDataGridNode.PopoverGraphColumnWidthPixels; },
                 get zeroTime() { return resource.firstTimestamp; },
                 get startTime() { return resource.firstTimestamp; },