Changeset 226292 in webkit

Timestamp:

Dec 25, 2017 3:35:30 PM (6 years ago)

Author:

mitz@apple.com

Message:

[macOS] On Retina displays, icon used as drag image for large image is scaled down
​https://bugs.webkit.org/show_bug.cgi?id=181154

Reviewed by Wenson Hsieh.

• page/DragController.cpp:

(WebCore::DragController::doImageDrag): When using an icon for the drag image, also adjust

its size for the device scale factor, like we do in the not-icon case.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DragController.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-25  Dan Bernstein  <mitz@apple.com>
+
+        [macOS] On Retina displays, icon used as drag image for large image is scaled down
+        https://bugs.webkit.org/show_bug.cgi?id=181154
+
+        Reviewed by Wenson Hsieh.
+
+        * page/DragController.cpp:
+        (WebCore::DragController::doImageDrag): When using an icon for the drag image, also adjust
+          its size for the device scale factor, like we do in the not-icon case.
+
 2017-12-24  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/WebCore/page/DragController.cpp

@@ -1156 +1156 @@
         if (CachedImage* cachedImage = getCachedImage(element)) {
             dragImage = DragImage { createDragImageIconForCachedImageFilename(cachedImage->response().suggestedFilename()) };
-            if (dragImage)
+            if (dragImage) {
+                dragImage = DragImage { platformAdjustDragImageForDeviceScaleFactor(dragImage.get(), m_page.deviceScaleFactor()) };
                 scaledOrigin = IntPoint(DragIconRightInset - dragImageSize(dragImage.get()).width(), DragIconBottomInset);
+            }
         }
     }