Changeset 226298 in webkit

Timestamp:

Dec 27, 2017 2:52:39 AM (6 years ago)

Author:

zandobersek@gmail.com

Message:

REGRESSION(r225913): about 30 JSC test failures on ARMv7
​https://bugs.webkit.org/show_bug.cgi?id=181162

Reviewed by Michael Catanzaro.

Fast case in DFG::SpeculativeJIT::compileArraySlice() was enabled in
r225913 on all but 32-bit x86 platform. Other 32-bit platforms have the
same lack of GP registers, so the conditional is changed here to only
enable this optimization explicitly on ARM64 and x86-64.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArraySlice):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2017-12-27  Zan Dobersek  <zdobersek@igalia.com>
+
+        REGRESSION(r225913): about 30 JSC test failures on ARMv7
+        https://bugs.webkit.org/show_bug.cgi?id=181162
+
+        Reviewed by Michael Catanzaro.
+
+        Fast case in DFG::SpeculativeJIT::compileArraySlice() was enabled in
+        r225913 on all but 32-bit x86 platform. Other 32-bit platforms have the
+        same lack of GP registers, so the conditional is changed here to only
+        enable this optimization explicitly on ARM64 and x86-64.
+
+        * dfg/DFGSpeculativeJIT.cpp:
+        (JSC::DFG::SpeculativeJIT::compileArraySlice):
+
 2017-12-26  Yusuke Suzuki  <utatane.tea@gmail.com>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

@@ -7636 +7636 @@
         m_jit.move(TrustedImmPtr(0), storageResultGPR);
         // X86 only has 6 GP registers, which is not enough for the fast case here. At least without custom code, which is not currently worth the extra code maintenance.
-        if (!isX86() || isX86_64()) {
+        if (isARM64() || isX86_64()) {
             GPRTemporary scratch(this);
             GPRTemporary scratch2(this);