Changeset 226316 in webkit

Timestamp:

Jan 1, 2018, 12:28:32 PM (7 years ago)

Author:

Simon Fraser

Message:

Bottom right pixel of feDiffuseLighting has the wrong color
​https://bugs.webkit.org/show_bug.cgi?id=181203

Reviewed by Antti Koivisto.

Source/WebCore:

The lower right pixel of a feDiffuseLighting was the wrong color, because the kernel
values didn't match the spec for the bottom right Y values.

Test: svg/filters/feDiffuseLighting-bottomRightPixel.html

• platform/graphics/filters/FELighting.cpp:

(WebCore::FELighting::LightingData::bottomRightNormal const):

LayoutTests:

Test that draws an SVG image into a canvas, and scales it up without interpolation.

• svg/filters/feDiffuseLighting-bottomRightPixel-expected.html: Added.
• svg/filters/feDiffuseLighting-bottomRightPixel.html: Added.
• svg/filters/resources/feDiffuseLighting-rect.svg: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/filters/feDiffuseLighting-bottomRightPixel-expected.html (added)
• LayoutTests/svg/filters/feDiffuseLighting-bottomRightPixel.html (added)
• LayoutTests/svg/filters/feSpotLight-color-expected.svg (modified) (1 diff)
• LayoutTests/svg/filters/feSpotLight-color.svg (modified) (1 diff)
• LayoutTests/svg/filters/resources/feDiffuseLighting-rect.svg (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/graphics/filters/FELighting.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2017-12-31  Simon Fraser  <simon.fraser@apple.com>
+
+        Bottom right pixel of feDiffuseLighting has the wrong color
+        https://bugs.webkit.org/show_bug.cgi?id=181203
+
+        Reviewed by Antti Koivisto.
+
+        Test that draws an SVG image into a canvas, and scales it up without interpolation.
+
+        * svg/filters/feDiffuseLighting-bottomRightPixel-expected.html: Added.
+        * svg/filters/feDiffuseLighting-bottomRightPixel.html: Added.
+        * svg/filters/resources/feDiffuseLighting-rect.svg: Added.
+
 2017-12-30  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/svg/filters/feSpotLight-color-expected.svg

@@ -6 +6 @@
 </defs>
 <rect x="0" y="00" width="400" height="400" filter="url(#filter)"/>
-<!-- Mask out a small difference in the bottom right corner -->
-<rect x="385" y="385" width="20" height="20" fill="black"/>
 </svg>

trunk/LayoutTests/svg/filters/feSpotLight-color.svg

@@ -8 +8 @@
 </defs>
 <rect x="0" y="0" width="400" height="400" filter="url(#filter)"/>
-<!-- Mask out a small difference in the bottom right corner -->
-<rect x="385" y="385" width="20" height="20" fill="black"/>
 </svg>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2017-12-31  Simon Fraser  <simon.fraser@apple.com>
+
+        Bottom right pixel of feDiffuseLighting has the wrong color
+        https://bugs.webkit.org/show_bug.cgi?id=181203
+
+        Reviewed by Antti Koivisto.
+
+        The lower right pixel of a feDiffuseLighting was the wrong color, because the kernel
+        values didn't match the spec for the bottom right Y values.
+
+        Test: svg/filters/feDiffuseLighting-bottomRightPixel.html
+
+        * platform/graphics/filters/FELighting.cpp:
+        (WebCore::FELighting::LightingData::bottomRightNormal const):
+
 2017-12-30  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/graphics/filters/FELighting.cpp

@@ -234 +234 @@
     return {
         -topLeft + top - 2 * left + 2 * center,
-        topLeft - 2 * top + left + 2 * center
+        -topLeft - 2 * top + left + 2 * center
     };
 }