Changeset 226632 in webkit
- Timestamp:
- Jan 9, 2018 7:22:13 AM (6 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r226630 r226632 1 2018-01-09 Zalan Bujtas <zalan@apple.com> 2 3 [RenderTreeBuilder] Transition Render*::addChild() calls to RenderTreeBuilder::insertChildToRender*() 4 https://bugs.webkit.org/show_bug.cgi?id=181407 5 <rdar://problem/36361176> 6 7 Reviewed by Antti Koivisto. 8 9 Eventually all mutation will be going through the RenderTreeBuilder. 10 11 No change in functionality. 12 13 * rendering/RenderGrid.cpp: 14 (WebCore::RenderGrid::addChild): 15 * rendering/RenderMultiColumnFlow.cpp: 16 (WebCore::RenderMultiColumnFlow::processPossibleSpannerDescendant): 17 * rendering/RenderRubyRun.cpp: 18 (WebCore::RenderRubyRun::rubyBaseSafe): 19 * rendering/updating/RenderTreeBuilderBlockFlow.cpp: 20 (WebCore::RenderTreeBuilder::BlockFlow::insertChild): 21 * rendering/updating/RenderTreeBuilderMultiColumn.cpp: 22 (WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow): 23 * rendering/updating/RenderTreeBuilderRuby.cpp: 24 (WebCore::RenderTreeBuilder::Ruby::findOrCreateParentForChild): 25 1 26 2018-01-09 Philippe Normand <pnormand@igalia.com> 2 27 -
trunk/Source/WebCore/rendering/RenderGrid.cpp
r226007 r226632 36 36 #include "RenderChildIterator.h" 37 37 #include "RenderLayer.h" 38 #include "RenderTreeBuilder.h" 38 39 #include "RenderView.h" 39 40 #include <cstdlib> … … 73 74 { 74 75 auto& child = *newChild; 75 RenderBlock::addChild(builder, WTFMove(newChild), beforeChild);76 builder.insertChildToRenderBlock(*this, WTFMove(newChild), beforeChild); 76 77 77 78 // Positioned grid items do not take up space or otherwise participate in the layout of the grid, -
trunk/Source/WebCore/rendering/RenderMultiColumnFlow.cpp
r226007 r226632 299 299 // This is a guard to stop an ancestor flow thread from processing the spanner. 300 300 gShiftingSpanner = true; 301 multicolContainer->RenderBlock::addChild(*RenderTreeBuilder::current(), WTFMove(takenDescendant), insertBeforeMulticolChild);301 RenderTreeBuilder::current()->insertChildToRenderBlock(*multicolContainer, WTFMove(takenDescendant), insertBeforeMulticolChild); 302 302 gShiftingSpanner = false; 303 303 … … 336 336 newSet->initializeStyle(); 337 337 auto& set = *newSet; 338 multicolContainer->RenderBlock::addChild(*RenderTreeBuilder::current(), WTFMove(newSet), insertBeforeMulticolChild);338 RenderTreeBuilder::current()->insertChildToRenderBlock(*multicolContainer, WTFMove(newSet), insertBeforeMulticolChild); 339 339 invalidateFragments(); 340 340 -
trunk/Source/WebCore/rendering/RenderRubyRun.cpp
r226007 r226632 94 94 auto newBase = createRubyBase(); 95 95 base = newBase.get(); 96 Render BlockFlow::addChild(*RenderTreeBuilder::current(), WTFMove(newBase));96 RenderTreeBuilder::current()->insertChildToRenderBlockFlow(*this, WTFMove(newBase)); 97 97 } 98 98 return base; -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderBlockFlow.cpp
r226537 r226632 43 43 if (auto* containingFragmentedFlow = parent.enclosingFragmentedFlow()) 44 44 beforeChildOrPlaceholder = containingFragmentedFlow->resolveMovedChild(beforeChild); 45 parent.RenderBlock::addChild(m_builder, WTFMove(child), beforeChildOrPlaceholder);45 m_builder.insertChildToRenderBlock(parent, WTFMove(child), beforeChildOrPlaceholder); 46 46 } 47 47 -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderMultiColumn.cpp
r226179 r226632 87 87 newFragmentedFlow->initializeStyle(); 88 88 auto& fragmentedFlow = *newFragmentedFlow; 89 flow.RenderBlock::addChild(m_builder, WTFMove(newFragmentedFlow));89 m_builder.insertChildToRenderBlock(flow, WTFMove(newFragmentedFlow)); 90 90 91 91 // Reparent children preceding the fragmented flow into the fragmented flow. -
trunk/Source/WebCore/rendering/updating/RenderTreeBuilderRuby.cpp
r226537 r226632 233 233 auto newBlock = createAnonymousRubyInlineBlock(parent); 234 234 beforeBlock = newBlock.get(); 235 parent.RenderInline::addChild(m_builder, WTFMove(newBlock), parent.firstChild());235 m_builder.insertChildToRenderInline(parent, WTFMove(newBlock), parent.firstChild()); 236 236 } 237 237 beforeChild = nullptr; … … 248 248 auto newBlock = createAnonymousRubyInlineBlock(parent); 249 249 afterBlock = newBlock.get(); 250 parent.RenderInline::addChild(m_builder, WTFMove(newBlock));250 m_builder.insertChildToRenderInline(parent, WTFMove(newBlock)); 251 251 } 252 252 beforeChild = nullptr; … … 277 277 auto newRun = RenderRubyRun::staticCreateRubyRun(&parent); 278 278 lastRun = newRun.get(); 279 parent.RenderInline::addChild(m_builder, WTFMove(newRun), beforeChild);279 m_builder.insertChildToRenderInline(parent, WTFMove(newRun), beforeChild); 280 280 } 281 281 beforeChild = nullptr;
Note: See TracChangeset
for help on using the changeset viewer.