Changeset 226664 in webkit

Timestamp:

Jan 9, 2018 3:47:37 PM (6 years ago)

Author:

jer.noble@apple.com

Message:

Many CVDisplayLink threads created and destroyed while watching a YouTube video
​https://bugs.webkit.org/show_bug.cgi?id=181396

Reviewed by Simon Fraser.

When watching some YouTube videos (or any video with default controls), event handlers for
the "timeupdate" event which use rAF will cause the underlying platform objects to be
destroyed in between "timeupdate" events being fired, since they occur every 250ms, and rAF
objects are destroyed every 166ms (or 10/60hz). Update this constant to destroy the
underlying objects every 333ms (or 20/60hz) so that this common pattern doesn't lead to
excessive rAF platform object turnover.

• platform/Logging.h:
• platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::shouldBeTerminated const):

• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/DisplayRefreshMonitorManager.cpp:

(WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
(WebCore::DisplayRefreshMonitorManager::displayDidRefresh):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/Logging.h (modified) (1 diff)
• platform/graphics/DisplayRefreshMonitor.cpp (modified) (1 diff)
• platform/graphics/DisplayRefreshMonitor.h (modified) (1 diff)
• platform/graphics/DisplayRefreshMonitorManager.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2018-01-09  Jer Noble  <jer.noble@apple.com>
+
+        Many CVDisplayLink threads created and destroyed while watching a YouTube video
+        https://bugs.webkit.org/show_bug.cgi?id=181396
+
+        Reviewed by Simon Fraser.
+
+        When watching some YouTube videos (or any video with default controls), event handlers for
+        the "timeupdate" event which use rAF will cause the underlying platform objects to be
+        destroyed in between "timeupdate" events being fired, since they occur every 250ms, and rAF
+        objects are destroyed every 166ms (or 10/60hz). Update this constant to destroy the
+        underlying objects every 333ms (or 20/60hz) so that this common pattern doesn't lead to
+        excessive rAF platform object turnover.
+
+        * platform/Logging.h:
+        * platform/graphics/DisplayRefreshMonitor.h:
+        (WebCore::DisplayRefreshMonitor::shouldBeTerminated const):
+        * platform/graphics/DisplayRefreshMonitor.cpp:
+        (WebCore::DisplayRefreshMonitor::displayDidRefresh):
+        * platform/graphics/DisplayRefreshMonitorManager.cpp:
+        (WebCore::DisplayRefreshMonitorManager::createMonitorForClient):
+        (WebCore::DisplayRefreshMonitorManager::displayDidRefresh):
+
 2018-01-09  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/platform/Logging.h

@@ -79 +79 @@
     M(Progress) \
     M(RemoteInspector) \
+    M(RequestAnimationFrame) \
     M(ResourceLoading) \
     M(ResourceLoadObserver) \

trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.cpp

@@ -86 +86 @@
     {
         LockHolder lock(m_mutex);
+        LOG(RequestAnimationFrame, "DisplayRefreshMonitor::displayDidRefresh(%p) - m_scheduled(%d), m_unscheduledFireCount(%d)", this, m_scheduled, m_unscheduledFireCount);
         if (!m_scheduled)
             ++m_unscheduledFireCount;

trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitor.h

@@ -57 +57 @@
     bool shouldBeTerminated() const
     {
-        const int maxInactiveFireCount = 10;
+        const int maxInactiveFireCount = 20;
         return !m_scheduled && m_unscheduledFireCount > maxInactiveFireCount;
     }

trunk/Source/WebCore/platform/graphics/DisplayRefreshMonitorManager.cpp

@@ -31 +31 @@
 #include "DisplayRefreshMonitor.h"
 #include "DisplayRefreshMonitorClient.h"
+#include "Logging.h"
 #include <wtf/CurrentTime.h>
 
@@ -57 +58 @@
         return nullptr;
 
+    LOG(RequestAnimationFrame, "DisplayRefreshMonitorManager::createMonitorForClient() - created monitor %p", monitor.get());
     monitor->addClient(client);
     DisplayRefreshMonitor* result = monitor.get();
@@ -106 +108 @@
     if (!monitor.shouldBeTerminated())
         return;
+    LOG(RequestAnimationFrame, "DisplayRefreshMonitorManager::displayDidRefresh() - destroying monitor %p", &monitor);
 
     size_t monitorIndex = m_monitors.find(&monitor);