Changeset 226819 in webkit

Timestamp:

Jan 11, 2018, 4:19:51 PM (7 years ago)

Author:

Jonathan Bedard

Message:

Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
​https://bugs.webkit.org/show_bug.cgi?id=181561
<rdar://problem/36452652>

Reviewed by Aakash Jain.

BeautifulSoup.find may return None, this case should be gracefully handled.

• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._parse_result_count):
(BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-01-11  Jonathan Bedard  <jbedard@apple.com>
+
+        Commit queue failed to land a bug, 'NoneType' object has no attribute 'strip'
+        https://bugs.webkit.org/show_bug.cgi?id=181561
+        <rdar://problem/36452652>
+
+        Reviewed by Aakash Jain.
+
+        BeautifulSoup.find may return None, this case should be gracefully handled.
+
+        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
+        (BugzillaQueries._parse_result_count):
+        (BugzillaQueries._fetch_bugs_from_advanced_query): Added logging.
+
 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py

@@ -140 +140 @@
     def _parse_result_count(self, results_page):
         result_count_text = BeautifulSoup(results_page).find(attrs={'class': 'bz_result_count'}).string
+        if result_count_text is None:
+            _log.warn("BeautifulSoup returned None while finding class: bz_result_count in:\n{}".format(results_page))
+            return 0
         result_count_parts = result_count_text.strip().split(" ")
         if result_count_parts[0] == "Zarro":
@@ -163 +166 @@
             return [self._fetch_bug(bug_id)]
         if not self._parse_result_count(results_page):
+            _log.warn('Failed to find bugs for {}'.format(results_url))
             return []
         # Bugzilla results pages have an "XML" submit button at the bottom