Changeset 226948 in webkit


Ignore:
Timestamp:
Jan 15, 2018 7:27:23 AM (6 years ago)
Author:
Philippe Normand
Message:

Prevent useless MediaPlayer mute state notifications
​https://bugs.webkit.org/show_bug.cgi?id=181646

Reviewed by Carlos Garcia Campos.

Source/WebCore:

On GTK port the mute change notification was triggering the test
runner to think the whole page mute state had changed and that
media elements were muted. The simplest solution is to propagate
the notification only if the state actually changed.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::muteChanged): Propagate mute notification
only if the mute state actually changed.

LayoutTests:

Unflag tests depending on muted state and media session
restrictions, most of those are now passing.

  • platform/gtk/TestExpectations:
  • platform/gtk/media/video-controls-no-scripting-expected.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r226943 r226948  
     12018-01-15  Philippe Normand  <pnormand@igalia.com>
     2
     3        Prevent useless MediaPlayer mute state notifications
     4        https://bugs.webkit.org/show_bug.cgi?id=181646
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        Unflag tests depending on muted state and media session
     9        restrictions, most of those are now passing.
     10
     11        * platform/gtk/TestExpectations:
     12        * platform/gtk/media/video-controls-no-scripting-expected.txt:
     13
    1142018-01-14  Myles C. Maxfield  <mmaxfield@apple.com>
    215

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r226782 r226948  
    18471847webkit.org/b/173412 fast/scrolling/overflow-scrollable-after-back.html [ Pass Failure ]
    18481848
    1849 webkit.org/b/168373 media/video-multiple-concurrent-playback.html [ Failure Crash ]
    18501849webkit.org/b/168373 media/video-seek-past-end-paused.html [ Failure Pass ]
    18511850
    … …  
    21992198
    22002199webkit.org/b/172816 media/media-source/media-source-paint-to-canvas.html [ Timeout ]
    2201 
    2202 webkit.org/b/174241 media/video-inactive-playback.html [ Timeout ]
    22032200
    22042201webkit.org/b/174242 media/media-fullscreen-pause-inline.html [ Timeout ]
    … …  
    30223019webkit.org/b/163526 media/video-controls-drop-and-restore-timeline.html [ Failure ]
    30233020webkit.org/b/163527 media/video-controls-show-on-kb-or-ax-event.html [ Failure ]
    3024 webkit.org/b/163529 media/video-playback-restriction-play-before-load.html [ Failure ]
    30253021webkit.org/b/163531 media/video-volume-slider-drag.html [ Failure ]
    30263022
    3027 webkit.org/b/163823 media/audio-playback-restriction-autoplay.html [ Failure ]
    3028 webkit.org/b/163823 media/audio-playback-restriction-play-muted.html [ Failure ]
    3029 webkit.org/b/163823 media/context-menu-actions.html [ Failure ]
    3030 webkit.org/b/163823 media/video-defaultmuted.html [ Failure ]
    30313023webkit.org/b/163823 media/video-volume-slider.html [ Failure ]
    30323024
    … …  
    30703062webkit.org/b/168543 http/wpt/resource-timing/rt-nextHopProtocol.worker.html [ Failure ]
    30713063
    3072 webkit.org/b/145260 media/audio-playback-restriction-play.html [ Failure ]
    3073 
    30743064webkit.org/b/168188 fast/events/ime-compositionend-on-selection-change.html [ Failure ]
    30753065
    … …  
    30933083webkit.org/b/168373 fullscreen/video-controls-rtl.html [ Failure ]
    30943084webkit.org/b/168373 media/media-preload-no-delay-loadevent.html [ Failure ]
    3095 webkit.org/b/168373 media/video-background-playback.html [ Failure Timeout ]
    3096 webkit.org/b/168373 media/video-concurrent-playback.html [ Failure Timeout ]
    30973085
    30983086# [GTK] Some reftest fail with only one or two pixel differences in diff image
    … …  
    31573145
    31583146webkit.org/b/172275 imported/w3c/web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-non-integer-screeny.html [ Failure ]
    3159 
    3160 webkit.org/b/172276 media/video-muted.html [ Failure ]
    3161 webkit.org/b/172276 media/video-play-audio-require-user-gesture.html [ Failure ]
    3162 
    3163 webkit.org/b/172277 media/video-restricted-invisible-autoplay-allowed-if-audible.html [ Failure ]
    31643147
    31653148webkit.org/b/172278 fast/html/marquee-child-wrap.html [ ImageOnlyFailure ]
    … …  
    31843167
    31853168webkit.org/b/172812 fast/canvas/webgl/lose-context-on-status-failure.html [ Failure ]
    3186 
    3187 webkit.org/b/172814 media/restricted-audio-playback-with-multiple-settimeouts.html [ Failure ]
    31883169
    31893170webkit.org/b/173410 fast/canvas/canvas-createPattern-video-loading.html [ Failure ]
    … …  
    32803261
    32813262webkit.org/b/144690 editing/spelling/spelling-marker-includes-hyphen.html [ Failure ImageOnlyFailure ]
    3282 
    3283 webkit.org/b/178456 media/audio-playback-volume-changes-with-restrictions.html [ Failure ]
    32843263
    32853264webkit.org/b/178591 http/tests/navigation/keyboard-events-during-provisional-navigation.html [ Failure ]

  • trunk/LayoutTests/platform/gtk/media/video-controls-no-scripting-expected.txt

    r220915 r226948  
    11CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
    22CONSOLE MESSAGE: line 13: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
    3 CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
    43CONSOLE MESSAGE: Blocked script execution in 'video-controls-no-scripting-iframe.html' because the document's frame is sandboxed and the 'allow-scripts' permission is not set.
    54

  • trunk/Source/WebCore/ChangeLog

    r226947 r226948  
     12018-01-15  Philippe Normand  <pnormand@igalia.com>
     2
     3        Prevent useless MediaPlayer mute state notifications
     4        https://bugs.webkit.org/show_bug.cgi?id=181646
     5
     6        Reviewed by Carlos Garcia Campos.
     7
     8        On GTK port the mute change notification was triggering the test
     9        runner to think the whole page mute state had changed and that
     10        media elements were muted. The simplest solution is to propagate
     11        the notification only if the state actually changed.
     12
     13        * platform/graphics/MediaPlayer.cpp:
     14        (WebCore::MediaPlayer::muteChanged): Propagate mute notification
     15        only if the mute state actually changed.
     16
    1172018-01-15  Sebastian Dröge  <sebastian@centricular.com>
    218

  • trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp

    r226349 r226948  
    11961196void MediaPlayer::muteChanged(bool newMuted)
    11971197{
     1198    if (newMuted == m_muted)
     1199        return;
     1200
    11981201    m_muted = newMuted;
    11991202    client().mediaPlayerMuteChanged(this);
Note: See TracChangeset for help on using the changeset viewer.