Changeset 226951 in webkit


Ignore:
Timestamp:
Jan 15, 2018 9:54:00 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

RealtimeMediaSource should be ThreadSafeRefCounted
https://bugs.webkit.org/show_bug.cgi?id=181649

Patch by Youenn Fablet <youenn@apple.com> on 2018-01-15
Reviewed by Eric Carlson.

Difficult to write a test as this is really racy.
RealtimeIncomingVideoSourceCocoa::OnFrame is taking a reference on a background thread
to send a task to the main thread.
This requires it to be thread safe ref counted.

  • platform/mediastream/RealtimeMediaSource.h:
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r226948 r226951  
     12018-01-15  Youenn Fablet  <youenn@apple.com>
     2
     3        RealtimeMediaSource should be ThreadSafeRefCounted
     4        https://bugs.webkit.org/show_bug.cgi?id=181649
     5
     6        Reviewed by Eric Carlson.
     7
     8        Difficult to write a test as this is really racy.
     9        RealtimeIncomingVideoSourceCocoa::OnFrame is taking a reference on a background thread
     10        to send a task to the main thread.
     11        This requires it to be thread safe ref counted.
     12
     13        * platform/mediastream/RealtimeMediaSource.h:
     14
    1152018-01-15  Philippe Normand  <pnormand@igalia.com>
    216
  • trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h

    r225395 r226951  
    4242#include "PlatformLayer.h"
    4343#include "RealtimeMediaSourceCapabilities.h"
    44 #include <wtf/RefCounted.h>
     44#include <wtf/ThreadSafeRefCounted.h>
    4545#include <wtf/Vector.h>
    4646#include <wtf/WeakPtr.h>
     
    6363struct CaptureSourceOrError;
    6464
    65 class WEBCORE_EXPORT RealtimeMediaSource : public RefCounted<RealtimeMediaSource> {
     65class WEBCORE_EXPORT RealtimeMediaSource : public ThreadSafeRefCounted<RealtimeMediaSource> {
    6666public:
    6767    class Observer {
Note: See TracChangeset for help on using the changeset viewer.