Changeset 227850 in webkit

Timestamp:

Jan 30, 2018 2:08:11 PM (6 years ago)

Author:

Antti Koivisto

Message:

StyleBench: Generate more mutation steps
​https://bugs.webkit.org/show_bug.cgi?id=182291

Reviewed by Ryosuke Niwa.

The test should be doing multiple rounds of mutations in a single document to test what is supposed to test (like it did before r227756).
This also makes test results more stable and less dependent on possible first-time costs.

• StyleBench/resources/benchmark-runner.js:

Adjust correctionFactor to match the new steps count. With 1.5 Firefox is ~72rpm.

• StyleBench/resources/tests.js:

(makeSteps):

Generate 10 rounds of class/element mutation steps.
Give each generated step unique name so reporting works.
Make individual steps do fewer mutations.

Location:

trunk/PerformanceTests

Files:

• ChangeLog (modified) (1 diff)
• StyleBench/resources/benchmark-runner.js (modified) (1 diff)
• StyleBench/resources/tests.js (modified) (2 diffs)

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2018-01-30  Antti Koivisto  <antti@apple.com>
+
+        StyleBench: Generate more mutation steps
+        https://bugs.webkit.org/show_bug.cgi?id=182291
+
+        Reviewed by Ryosuke Niwa.
+
+        The test should be doing multiple rounds of mutations in a single document to test what is supposed to test (like it did before r227756).
+        This also makes test results more stable and less dependent on possible first-time costs.
+
+        * StyleBench/resources/benchmark-runner.js:
+
+        Adjust correctionFactor to match the new steps count. With 1.5 Firefox is ~72rpm.
+
+        * StyleBench/resources/tests.js:
+        (makeSteps):
+
+        Generate 10 rounds of class/element mutation steps.
+        Give each generated step unique name so reporting works.
+        Make individual steps do fewer mutations.
+
 2018-01-29  Antti Koivisto  <antti@apple.com>
 

trunk/PerformanceTests/StyleBench/resources/benchmark-runner.js

@@ -287 +287 @@
         var geomean = Math.pow(product, 1 / values.length);
 
-        var correctionFactor = 8; // This factor makes the test score look reasonably fit within 0 to 140.
+        var correctionFactor = 1.5; // This factor makes the test score look reasonably fit within 0 to 140.
         this._measuredValues.total = total;
         this._measuredValues.mean = total / values.length;

trunk/PerformanceTests/StyleBench/resources/tests.js

@@ -2 +2 @@
 {
     const steps = [];
-    steps.push(new BenchmarkTestStep('Adding classes', (bench, contentWindow, contentDocument) => {
-        bench.addClasses(100);
-    }));
-    steps.push(new BenchmarkTestStep('Removing classes', (bench, contentWindow, contentDocument) => {
-        bench.removeClasses(100);
-    }));
-    steps.push(new BenchmarkTestStep('Adding leaf elements', (bench, contentWindow, contentDocument) => {
-        bench.addLeafElements(100);
-    }));
-    steps.push(new BenchmarkTestStep('Removing leaf elements', (bench, contentWindow, contentDocument) => {
-        bench.removeLeafElements(100);
-    }));
+    for (i = 1; i <= count; ++i) {
+        steps.push(new BenchmarkTestStep(`Adding classes - ${i}`, (bench, contentWindow, contentDocument) => {
+            bench.addClasses(25);
+        }));
+        steps.push(new BenchmarkTestStep(`Removing classes - ${i}`, (bench, contentWindow, contentDocument) => {
+            bench.removeClasses(25);
+        }));
+        steps.push(new BenchmarkTestStep(`Adding leaf elements - ${i}`, (bench, contentWindow, contentDocument) => {
+            bench.addLeafElements(25);
+        }));
+        steps.push(new BenchmarkTestStep(`Removing leaf elements - ${i}`, (bench, contentWindow, contentDocument) => {
+            bench.removeLeafElements(25);
+        }));
+    }
     return steps;
 }
@@ -27 +29 @@
             });
         },
-        tests: makeSteps(),
+        tests: makeSteps(10),
     };
 }