Changeset 228711 in webkit

Timestamp:

Feb 19, 2018 2:20:13 PM (6 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r228696.

The API test added with this change is timing out on macOS.

Reverted changeset:

"Null pointer dereference in
WebPageProxy::urlSchemeHandlerForScheme()"
​https://bugs.webkit.org/show_bug.cgi?id=182905
​https://trac.webkit.org/changeset/228696

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/WebPageProxy.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r228696.
+
+        The API test added with this change is timing out on macOS.
+
+        Reverted changeset:
+
+        "Null pointer dereference in
+        WebPageProxy::urlSchemeHandlerForScheme()"
+        https://bugs.webkit.org/show_bug.cgi?id=182905
+        https://trac.webkit.org/changeset/228696
+
 2018-02-19  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -7200 +7200 @@
 WebURLSchemeHandler* WebPageProxy::urlSchemeHandlerForScheme(const String& scheme)
 {
-    return scheme.isNull() ? nullptr : m_urlSchemeHandlersByScheme.get(scheme);
+    return m_urlSchemeHandlersByScheme.get(scheme);
 }
 

trunk/Tools/ChangeLog

@@ +1 @@
+2018-02-19  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r228696.
+
+        The API test added with this change is timing out on macOS.
+
+        Reverted changeset:
+
+        "Null pointer dereference in
+        WebPageProxy::urlSchemeHandlerForScheme()"
+        https://bugs.webkit.org/show_bug.cgi?id=182905
+        https://trac.webkit.org/changeset/228696
+
 2018-02-16  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm

@@ -562 +562 @@
 }
 
-@interface DecidePolicyForNavigationActionForMalformedURLDelegate : NSObject <WKNavigationDelegate>
-@end
-
-@implementation DecidePolicyForNavigationActionForMalformedURLDelegate
-
-- (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
-{
-    finishedNavigation = true;
-}
-
-@end
-
-TEST(WebKit, DecidePolicyForNavigationActionForMalformedURL)
-{
-    auto webView = adoptNS([[WKWebView alloc] init]);
-    auto controller = adoptNS([[DecidePolicyForNavigationActionForMalformedURLDelegate alloc] init]);
-    [webView setNavigationDelegate:controller.get()];
-
-    finishedNavigation = false;
-    [webView loadRequest:[NSURLRequest requestWithURL:[NSURL URLWithString:@"N"]]];
-    TestWebKitAPI::Util::run(&finishedNavigation);
-}
-
 #endif