Changeset 228712 in webkit
- Timestamp:
- Feb 19, 2018 2:29:38 PM (6 years ago)
- Location:
- trunk/Source
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r228710 r228712 1 2018-02-19 Eric Carlson <eric.carlson@apple.com> 2 3 [Extra zoom mode] Don't allow PiP media playback 4 https://bugs.webkit.org/show_bug.cgi?id=182930 5 <rdar://problem/37676259> 6 7 Reviewed by Andy Estes. 8 9 * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: 10 (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer): Don't call setPIPModeEnabled: 11 if it isn't implemented. 12 (WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenMode): Ditto. 13 1 14 2018-02-19 Antoine Quint <graouts@apple.com> 2 15 -
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
r228709 r228712 709 709 710 710 #if PLATFORM(IOS) 711 [m_videoLayer setPIPModeEnabled:(player()->fullscreenMode() & MediaPlayer::VideoFullscreenModePictureInPicture)]; 711 if ([m_videoLayer respondsToSelector:@selector(setPIPModeEnabled:)]) 712 [m_videoLayer setPIPModeEnabled:(player()->fullscreenMode() & MediaPlayer::VideoFullscreenModePictureInPicture)]; 712 713 #endif 713 714 #else … … 1229 1230 { 1230 1231 #if PLATFORM(IOS) 1231 [m_videoLayer setPIPModeEnabled:(mode & MediaPlayer::VideoFullscreenModePictureInPicture)]; 1232 if ([m_videoLayer respondsToSelector:@selector(setPIPModeEnabled:)]) 1233 [m_videoLayer setPIPModeEnabled:(mode & MediaPlayer::VideoFullscreenModePictureInPicture)]; 1232 1234 updateDisableExternalPlayback(); 1233 1235 #else -
trunk/Source/WebKit/ChangeLog
r228711 r228712 1 2018-02-19 Eric Carlson <eric.carlson@apple.com> 2 3 [Extra zoom mode] Don't allow PiP media playback 4 https://bugs.webkit.org/show_bug.cgi?id=182930 5 <rdar://problem/37676259> 6 7 Reviewed by Andy Estes. 8 9 * UIProcess/API/Cocoa/WKWebViewConfiguration.mm: 10 (-[WKWebViewConfiguration init]): Don't enable PiP mode. Require user interaction for 11 all media types. 12 1 13 2018-02-19 Ryan Haddad <ryanhaddad@apple.com> 2 14 -
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
r227984 r228712 175 175 176 176 #if PLATFORM(IOS) 177 #if !ENABLE(EXTRA_ZOOM_MODE) 177 178 _allowsPictureInPictureMediaPlayback = YES; 179 #endif 178 180 _allowsInlineMediaPlayback = WebCore::deviceClass() == MGDeviceClassiPad; 179 181 _inlineMediaPlaybackRequiresPlaysInlineAttribute = !_allowsInlineMediaPlayback; 180 182 _allowsInlineMediaPlaybackAfterFullscreen = !_allowsInlineMediaPlayback; 181 183 _mediaDataLoadsAutomatically = NO; 184 #if !ENABLE(EXTRA_ZOOM_MODE) 182 185 if (WebKit::linkedOnOrAfter(WebKit::SDKVersion::FirstWithMediaTypesRequiringUserActionForPlayback)) 183 186 _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAudio; 184 187 else 188 #endif 185 189 _mediaTypesRequiringUserActionForPlayback = WKAudiovisualMediaTypeAll; 186 190 _ignoresViewportScaleLimits = NO;
Note: See TracChangeset
for help on using the changeset viewer.