Changeset 229054 in webkit


Ignore:
Timestamp:
Feb 26, 2018 11:50:54 PM (6 years ago)
Author:
mark.lam@apple.com
Message:

Modernize FINALIZE_CODE and peer macros to use VA_ARGS arguments.
https://bugs.webkit.org/show_bug.cgi?id=183159
<rdar://problem/37930837>

Reviewed by Keith Miller.

Source/JavaScriptCore:

  • assembler/LinkBuffer.h:
  • assembler/testmasm.cpp:

(JSC::compile):

  • b3/B3Compile.cpp:

(JSC::B3::compile):

  • b3/air/testair.cpp:
  • b3/testb3.cpp:

(JSC::B3::testEntrySwitchSimple):
(JSC::B3::testEntrySwitchNoEntrySwitch):
(JSC::B3::testEntrySwitchWithCommonPaths):
(JSC::B3::testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
(JSC::B3::testEntrySwitchLoop):

  • bytecode/InlineAccess.cpp:

(JSC::linkCodeInline):
(JSC::InlineAccess::rewireStubAsJump):

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGThunks.cpp:

(JSC::DFG::osrExitThunkGenerator):
(JSC::DFG::osrExitGenerationThunkGenerator):
(JSC::DFG::osrEntryThunkGenerator):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLazySlowPath.cpp:

(JSC::FTL::LazySlowPath::generate):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLThunks.cpp:

(JSC::FTL::genericGenerationThunkGenerator):
(JSC::FTL::slowPathCallThunkGenerator):

  • jit/ExecutableAllocator.cpp:
  • jit/JIT.cpp:

(JSC::JIT::link):

  • jit/JITMathIC.h:

(JSC::isProfileEmpty):

  • jit/JITOpcodes.cpp:

(JSC::JIT::privateCompileHasIndexedProperty):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileHasIndexedProperty):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::stringGetByValStubGenerator):
(JSC::JIT::privateCompileGetByVal):
(JSC::JIT::privateCompileGetByValWithCachedId):
(JSC::JIT::privateCompilePutByVal):
(JSC::JIT::privateCompilePutByValWithCachedId):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::stringGetByValStubGenerator):

  • jit/JITStubRoutine.h:
  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

  • jit/SpecializedThunkJIT.h:

(JSC::SpecializedThunkJIT::finalize):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkPolymorphicCallThunkGenerator):
(JSC::virtualThunkFor):
(JSC::nativeForGenerator):
(JSC::arityFixupGenerator):
(JSC::unreachableGenerator):
(JSC::boundThisNoArgsFunctionCallGenerator):

  • llint/LLIntThunks.cpp:

(JSC::LLInt::generateThunkWithJumpTo):

  • wasm/WasmBBQPlan.cpp:

(JSC::Wasm::BBQPlan::complete):

  • wasm/WasmBinding.cpp:

(JSC::Wasm::wasmToWasm):

  • wasm/WasmOMGPlan.cpp:

(JSC::Wasm::OMGPlan::work):

  • wasm/WasmThunks.cpp:

(JSC::Wasm::throwExceptionFromWasmThunkGenerator):
(JSC::Wasm::throwStackOverflowFromWasmThunkGenerator):
(JSC::Wasm::triggerOMGTierUpThunkGenerator):

  • wasm/js/WasmToJS.cpp:

(JSC::Wasm::handleBadI64Use):
(JSC::Wasm::wasmToJS):

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::compile):

Source/WebCore:

No new tests needed because this is just a refactoring patch.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::compile):

Location:
trunk/Source
Files:
35 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r229053 r229054  
     12018-02-26  Mark Lam  <mark.lam@apple.com>
     2
     3        Modernize FINALIZE_CODE and peer macros to use __VA_ARGS__ arguments.
     4        https://bugs.webkit.org/show_bug.cgi?id=183159
     5        <rdar://problem/37930837>
     6
     7        Reviewed by Keith Miller.
     8
     9        * assembler/LinkBuffer.h:
     10        * assembler/testmasm.cpp:
     11        (JSC::compile):
     12        * b3/B3Compile.cpp:
     13        (JSC::B3::compile):
     14        * b3/air/testair.cpp:
     15        * b3/testb3.cpp:
     16        (JSC::B3::testEntrySwitchSimple):
     17        (JSC::B3::testEntrySwitchNoEntrySwitch):
     18        (JSC::B3::testEntrySwitchWithCommonPaths):
     19        (JSC::B3::testEntrySwitchWithCommonPathsAndNonTrivialEntrypoint):
     20        (JSC::B3::testEntrySwitchLoop):
     21        * bytecode/InlineAccess.cpp:
     22        (JSC::linkCodeInline):
     23        (JSC::InlineAccess::rewireStubAsJump):
     24        * bytecode/PolymorphicAccess.cpp:
     25        (JSC::PolymorphicAccess::regenerate):
     26        * dfg/DFGJITFinalizer.cpp:
     27        (JSC::DFG::JITFinalizer::finalize):
     28        (JSC::DFG::JITFinalizer::finalizeFunction):
     29        * dfg/DFGOSRExit.cpp:
     30        (JSC::DFG::OSRExit::compileOSRExit):
     31        * dfg/DFGThunks.cpp:
     32        (JSC::DFG::osrExitThunkGenerator):
     33        (JSC::DFG::osrExitGenerationThunkGenerator):
     34        (JSC::DFG::osrEntryThunkGenerator):
     35        * ftl/FTLJITFinalizer.cpp:
     36        (JSC::FTL::JITFinalizer::finalizeCommon):
     37        * ftl/FTLLazySlowPath.cpp:
     38        (JSC::FTL::LazySlowPath::generate):
     39        * ftl/FTLOSRExitCompiler.cpp:
     40        (JSC::FTL::compileStub):
     41        * ftl/FTLThunks.cpp:
     42        (JSC::FTL::genericGenerationThunkGenerator):
     43        (JSC::FTL::slowPathCallThunkGenerator):
     44        * jit/ExecutableAllocator.cpp:
     45        * jit/JIT.cpp:
     46        (JSC::JIT::link):
     47        * jit/JITMathIC.h:
     48        (JSC::isProfileEmpty):
     49        * jit/JITOpcodes.cpp:
     50        (JSC::JIT::privateCompileHasIndexedProperty):
     51        * jit/JITOpcodes32_64.cpp:
     52        (JSC::JIT::privateCompileHasIndexedProperty):
     53        * jit/JITPropertyAccess.cpp:
     54        (JSC::JIT::stringGetByValStubGenerator):
     55        (JSC::JIT::privateCompileGetByVal):
     56        (JSC::JIT::privateCompileGetByValWithCachedId):
     57        (JSC::JIT::privateCompilePutByVal):
     58        (JSC::JIT::privateCompilePutByValWithCachedId):
     59        * jit/JITPropertyAccess32_64.cpp:
     60        (JSC::JIT::stringGetByValStubGenerator):
     61        * jit/JITStubRoutine.h:
     62        * jit/Repatch.cpp:
     63        (JSC::linkPolymorphicCall):
     64        * jit/SpecializedThunkJIT.h:
     65        (JSC::SpecializedThunkJIT::finalize):
     66        * jit/ThunkGenerators.cpp:
     67        (JSC::throwExceptionFromCallSlowPathGenerator):
     68        (JSC::linkCallThunkGenerator):
     69        (JSC::linkPolymorphicCallThunkGenerator):
     70        (JSC::virtualThunkFor):
     71        (JSC::nativeForGenerator):
     72        (JSC::arityFixupGenerator):
     73        (JSC::unreachableGenerator):
     74        (JSC::boundThisNoArgsFunctionCallGenerator):
     75        * llint/LLIntThunks.cpp:
     76        (JSC::LLInt::generateThunkWithJumpTo):
     77        * wasm/WasmBBQPlan.cpp:
     78        (JSC::Wasm::BBQPlan::complete):
     79        * wasm/WasmBinding.cpp:
     80        (JSC::Wasm::wasmToWasm):
     81        * wasm/WasmOMGPlan.cpp:
     82        (JSC::Wasm::OMGPlan::work):
     83        * wasm/WasmThunks.cpp:
     84        (JSC::Wasm::throwExceptionFromWasmThunkGenerator):
     85        (JSC::Wasm::throwStackOverflowFromWasmThunkGenerator):
     86        (JSC::Wasm::triggerOMGTierUpThunkGenerator):
     87        * wasm/js/WasmToJS.cpp:
     88        (JSC::Wasm::handleBadI64Use):
     89        (JSC::Wasm::wasmToJS):
     90        * yarr/YarrJIT.cpp:
     91        (JSC::Yarr::YarrGenerator::compile):
     92
    1932018-02-25  Yusuke Suzuki  <utatane.tea@gmail.com>
    294
  • trunk/Source/JavaScriptCore/assembler/LinkBuffer.h

    r225363 r229054  
    11/*
    2  * Copyright (C) 2009-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2009-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    308308};
    309309
    310 #define FINALIZE_CODE_IF(condition, linkBufferReference, dataLogFArgumentsForHeading)  \
     310#define FINALIZE_CODE_IF(condition, linkBufferReference, ...)  \
    311311    (UNLIKELY((condition))                                              \
    312      ? ((linkBufferReference).finalizeCodeWithDisassembly dataLogFArgumentsForHeading) \
    313      : (linkBufferReference).finalizeCodeWithoutDisassembly())
     312        ? (linkBufferReference).finalizeCodeWithDisassembly(__VA_ARGS__) \
     313        : (linkBufferReference).finalizeCodeWithoutDisassembly())
    314314
    315315bool shouldDumpDisassemblyFor(CodeBlock*);
    316316
    317 #define FINALIZE_CODE_FOR(codeBlock, linkBufferReference, dataLogFArgumentsForHeading)  \
    318     FINALIZE_CODE_IF(shouldDumpDisassemblyFor(codeBlock) || Options::asyncDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)
     317#define FINALIZE_CODE_FOR(codeBlock, linkBufferReference, ...)  \
     318    FINALIZE_CODE_IF((shouldDumpDisassemblyFor(codeBlock) || Options::asyncDisassembly()), linkBufferReference, __VA_ARGS__)
    319319
    320320// Use this to finalize code, like so:
    321321//
    322 // CodeRef code = FINALIZE_CODE(linkBuffer, ("my super thingy number %d", number));
     322// CodeRef code = FINALIZE_CODE(linkBuffer, "my super thingy number %d", number);
    323323//
    324324// Which, in disassembly mode, will print:
     
    331331// ... and so on.
    332332//
    333 // Note that the dataLogFArgumentsForHeading are only evaluated when dumpDisassembly
     333// Note that the format string and print arguments are only evaluated when dumpDisassembly
    334334// is true, so you can hide expensive disassembly-only computations inside there.
    335335
    336 #define FINALIZE_CODE(linkBufferReference, dataLogFArgumentsForHeading)  \
    337     FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)
    338 
    339 #define FINALIZE_DFG_CODE(linkBufferReference, dataLogFArgumentsForHeading)  \
    340     FINALIZE_CODE_IF(JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly() || Options::dumpDFGDisassembly(), linkBufferReference, dataLogFArgumentsForHeading)
     336#define FINALIZE_CODE(linkBufferReference, ...)  \
     337    FINALIZE_CODE_IF((JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly()), linkBufferReference, __VA_ARGS__)
     338
     339#define FINALIZE_DFG_CODE(linkBufferReference, ...)  \
     340    FINALIZE_CODE_IF((JSC::Options::asyncDisassembly() || JSC::Options::dumpDisassembly() || Options::dumpDFGDisassembly()), linkBufferReference, __VA_ARGS__)
    341341
    342342} // namespace JSC
  • trunk/Source/JavaScriptCore/assembler/testmasm.cpp

    r225778 r229054  
    11/*
    2  * Copyright (C) 2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2017-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    149149    generate(jit);
    150150    LinkBuffer linkBuffer(jit, nullptr);
    151     return FINALIZE_CODE(linkBuffer, ("testmasm compilation"));
     151    return FINALIZE_CODE(linkBuffer, "testmasm compilation");
    152152}
    153153
  • trunk/Source/JavaScriptCore/b3/B3Compile.cpp

    r214901 r229054  
    11/*
    2  * Copyright (C) 2016 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    4949    LinkBuffer linkBuffer(jit, nullptr);
    5050
    51     return Compilation(FINALIZE_CODE(linkBuffer, ("B3::Compilation")), proc.releaseByproducts());
     51    return Compilation(FINALIZE_CODE(linkBuffer, "B3::Compilation"), proc.releaseByproducts());
    5252}
    5353
  • trunk/Source/JavaScriptCore/b3/air/testair.cpp

    r225778 r229054  
    11/*
    2  * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    9191
    9292    return std::make_unique<B3::Compilation>(
    93         FINALIZE_CODE(linkBuffer, ("testair compilation")), proc.releaseByproducts());
     93        FINALIZE_CODE(linkBuffer, "testair compilation"), proc.releaseByproducts());
    9494}
    9595
  • trunk/Source/JavaScriptCore/b3/testb3.cpp

    r228533 r229054  
    1329513295    CodeLocationLabel labelThree = linkBuffer.locationOf(proc.entrypointLabel(2));
    1329613296   
    13297     MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, ("testb3 compilation"));
     13297    MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, "testb3 compilation");
    1329813298   
    1329913299    CHECK(invoke<int>(labelOne, 1, 2) == 3);
     
    1332813328    CodeLocationLabel labelThree = linkBuffer.locationOf(proc.entrypointLabel(2));
    1332913329   
    13330     MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, ("testb3 compilation"));
     13330    MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, "testb3 compilation");
    1333113331   
    1333213332    CHECK_EQ(invoke<int>(labelOne, 1, 2), 3);
     
    1341513415    CodeLocationLabel labelThree = linkBuffer.locationOf(proc.entrypointLabel(2));
    1341613416   
    13417     MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, ("testb3 compilation"));
     13417    MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, "testb3 compilation");
    1341813418   
    1341913419    CHECK_EQ(invoke<int>(labelOne, 1, 2, 10), 3);
     
    1353213532    CodeLocationLabel labelThree = linkBuffer.locationOf(proc.entrypointLabel(2));
    1353313533   
    13534     MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, ("testb3 compilation"));
     13534    MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, "testb3 compilation");
    1353513535   
    1353613536    CHECK_EQ(invoke<int>(labelOne, 1, 2, 10, false), 3);
     
    1360913609    CodeLocationLabel labelTwo = linkBuffer.locationOf(proc.entrypointLabel(1));
    1361013610   
    13611     MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, ("testb3 compilation"));
     13611    MacroAssemblerCodeRef codeRef = FINALIZE_CODE(linkBuffer, "testb3 compilation");
    1361213612
    1361313613    CHECK(invoke<int>(labelOne, 0) == 1);
  • trunk/Source/JavaScriptCore/bytecode/InlineAccess.cpp

    r224564 r229054  
    11/*
    2  * Copyright (C) 2016 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    136136        ASSERT(linkBuffer.isValid());
    137137        function(linkBuffer);
    138         FINALIZE_CODE(linkBuffer, ("InlineAccessType: '%s'", name));
     138        FINALIZE_CODE(linkBuffer, "InlineAccessType: '%s'", name);
    139139        return true;
    140140    }
     
    291291    linkBuffer.link(jump, target);
    292292
    293     FINALIZE_CODE(linkBuffer, ("InlineAccess: linking constant jump"));
     293    FINALIZE_CODE(linkBuffer, "InlineAccess: linking constant jump");
    294294}
    295295
  • trunk/Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp

    r224258 r229054  
    11/*
    2  * Copyright (C) 2014-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2014-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    570570    MacroAssemblerCodeRef code = FINALIZE_CODE_FOR(
    571571        codeBlock, linkBuffer,
    572         ("%s", toCString("Access stub for ", *codeBlock, " ", stubInfo.codeOrigin, " with return point ", successLabel, ": ", listDump(cases)).data()));
     572        "%s", toCString("Access stub for ", *codeBlock, " ", stubInfo.codeOrigin, " with return point ", successLabel, ": ", listDump(cases)).data());
    573573
    574574    bool doesCalls = false;
  • trunk/Source/JavaScriptCore/dfg/DFGJITFinalizer.cpp

    r220556 r229054  
    5858{
    5959    m_jitCode->initializeCodeRef(
    60         FINALIZE_DFG_CODE(*m_linkBuffer, ("DFG JIT code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::DFGJIT)).data())),
     60        FINALIZE_DFG_CODE(*m_linkBuffer, "DFG JIT code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::DFGJIT)).data()),
    6161        MacroAssemblerCodePtr());
    6262   
     
    7272    RELEASE_ASSERT(!m_withArityCheck.isEmptyValue());
    7373    m_jitCode->initializeCodeRef(
    74         FINALIZE_DFG_CODE(*m_linkBuffer, ("DFG JIT code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::DFGJIT)).data())),
     74        FINALIZE_DFG_CODE(*m_linkBuffer, "DFG JIT code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::DFGJIT)).data()),
    7575        m_withArityCheck);
    7676    m_plan.codeBlock->setJITCode(m_jitCode.copyRef());
  • trunk/Source/JavaScriptCore/dfg/DFGOSRExit.cpp

    r223875 r229054  
    11/*
    2  * Copyright (C) 2011-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    10701070            shouldDumpDisassembly() || Options::verboseOSR() || Options::verboseDFGOSRExit(),
    10711071            patchBuffer,
    1072             ("DFG OSR exit #%u (%s, %s) from %s, with operands = %s",
     1072            "DFG OSR exit #%u (%s, %s) from %s, with operands = %s",
    10731073                exitIndex, toCString(exit.m_codeOrigin).data(),
    10741074                exitKindToString(exit.m_kind), toCString(*codeBlock).data(),
    1075                 toCString(ignoringContext<DumpContext>(operands)).data()));
     1075                toCString(ignoringContext<DumpContext>(operands)).data());
    10761076    }
    10771077
  • trunk/Source/JavaScriptCore/dfg/DFGThunks.cpp

    r225360 r229054  
    11/*
    2  * Copyright (C) 2011-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    4646    jit.probe(OSRExit::executeOSRExit, vm);
    4747    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    48     return FINALIZE_CODE(patchBuffer, ("DFG OSR exit thunk"));
     48    return FINALIZE_CODE(patchBuffer, "DFG OSR exit thunk");
    4949}
    5050
     
    106106    patchBuffer.link(functionCall, OSRExit::compileOSRExit);
    107107   
    108     return FINALIZE_CODE(patchBuffer, ("DFG OSR exit generation thunk"));
     108    return FINALIZE_CODE(patchBuffer, "DFG OSR exit generation thunk");
    109109}
    110110
     
    147147   
    148148    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    149     return FINALIZE_CODE(patchBuffer, ("DFG OSR entry thunk"));
     149    return FINALIZE_CODE(patchBuffer, "DFG OSR entry thunk");
    150150}
    151151
  • trunk/Source/JavaScriptCore/ftl/FTLJITFinalizer.cpp

    r221954 r229054  
    11/*
    2  * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2013-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    7777        FINALIZE_CODE_IF(
    7878            dumpDisassembly, *b3CodeLinkBuffer,
    79             ("FTL B3 code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::FTLJIT)).data())));
     79            "FTL B3 code for %s", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::FTLJIT)).data()));
    8080
    8181    if (entrypointLinkBuffer) {
     
    8383            FINALIZE_CODE_IF(
    8484                dumpDisassembly, *entrypointLinkBuffer,
    85                 ("FTL entrypoint thunk for %s with B3 generated code at %p", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::FTLJIT)).data(), function)));
     85                "FTL entrypoint thunk for %s with B3 generated code at %p", toCString(CodeBlockWithJITType(m_plan.codeBlock, JITCode::FTLJIT)).data(), function));
    8686    }
    8787   
  • trunk/Source/JavaScriptCore/ftl/FTLLazySlowPath.cpp

    r214571 r229054  
    11/*
    2  * Copyright (C) 2015 Apple Inc. All rights reserved.
     2 * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    6868    if (m_exceptionTarget)
    6969        linkBuffer.link(exceptionJumps, m_exceptionTarget);
    70     m_stub = FINALIZE_CODE_FOR(codeBlock, linkBuffer, ("Lazy slow path call stub"));
     70    m_stub = FINALIZE_CODE_FOR(codeBlock, linkBuffer, "Lazy slow path call stub");
    7171
    7272    MacroAssembler::repatchJump(m_patchableJump, CodeLocationLabel(m_stub.code()));
  • trunk/Source/JavaScriptCore/ftl/FTLOSRExitCompiler.cpp

    r223875 r229054  
    11/*
    2  * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2013-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    496496        shouldDumpDisassembly() || Options::verboseOSR() || Options::verboseFTLOSRExit(),
    497497        patchBuffer,
    498         ("FTL OSR exit #%u (%s, %s) from %s, with operands = %s",
     498        "FTL OSR exit #%u (%s, %s) from %s, with operands = %s",
    499499            exitID, toCString(exit.m_codeOrigin).data(),
    500500            exitKindToString(exit.m_kind), toCString(*codeBlock).data(),
    501             toCString(ignoringContext<DumpContext>(exit.m_descriptor->m_values)).data())
     501            toCString(ignoringContext<DumpContext>(exit.m_descriptor->m_values)).data()
    502502        );
    503503}
  • trunk/Source/JavaScriptCore/ftl/FTLThunks.cpp

    r220219 r229054  
    11/*
    2  * Copyright (C) 2013-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2013-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    120120    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    121121    patchBuffer.link(functionCall, generationFunction);
    122     return FINALIZE_CODE(patchBuffer, ("%s", name));
     122    return FINALIZE_CODE(patchBuffer, "%s", name);
    123123}
    124124
     
    225225    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    226226    patchBuffer.link(call, FunctionPtr(key.callTarget()));
    227     return FINALIZE_CODE(patchBuffer, ("FTL slow path call thunk for %s", toCString(key).data()));
     227    return FINALIZE_CODE(patchBuffer, "FTL slow path call thunk for %s", toCString(key).data());
    228228}
    229229
  • trunk/Source/JavaScriptCore/jit/ExecutableAllocator.cpp

    r227168 r229054  
    11/*
    2  * Copyright (C) 2008-2009, 2015, 2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2008-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
  • trunk/Source/JavaScriptCore/jit/JIT.cpp

    r228533 r229054  
    871871    CodeRef result = FINALIZE_CODE(
    872872        patchBuffer,
    873         ("Baseline JIT code for %s", toCString(CodeBlockWithJITType(m_codeBlock, JITCode::BaselineJIT)).data()));
     873        "Baseline JIT code for %s", toCString(CodeBlockWithJITType(m_codeBlock, JITCode::BaselineJIT)).data());
    874874   
    875875    m_vm->machineCodeBytesPerBytecodeWordForBaselineJIT->add(
  • trunk/Source/JavaScriptCore/jit/JITMathIC.h

    r226806 r229054  
    140140            RELEASE_ASSERT(linkBuffer.isValid());
    141141            linkBuffer.link(jump, CodeLocationLabel(m_code.code()));
    142             FINALIZE_CODE(linkBuffer, ("JITMathIC: linking constant jump to out of line stub"));
     142            FINALIZE_CODE(linkBuffer, "JITMathIC: linking constant jump to out of line stub");
    143143        };
    144144
     
    167167
    168168                    m_code = FINALIZE_CODE_FOR(
    169                         codeBlock, linkBuffer, ("JITMathIC: generating out of line fast IC snippet"));
     169                        codeBlock, linkBuffer, "JITMathIC: generating out of line fast IC snippet");
    170170
    171171                    if (!generationState.shouldSlowPathRepatch) {
     
    209209
    210210            m_code = FINALIZE_CODE_FOR(
    211                 codeBlock, linkBuffer, ("JITMathIC: generating out of line IC snippet"));
     211                codeBlock, linkBuffer, "JITMathIC: generating out of line IC snippet");
    212212        }
    213213
  • trunk/Source/JavaScriptCore/jit/JITOpcodes.cpp

    r228500 r229054  
    10831083    byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    10841084        m_codeBlock, patchBuffer,
    1085         ("Baseline has_indexed_property stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value()));
     1085        "Baseline has_indexed_property stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value());
    10861086   
    10871087    MacroAssembler::repatchJump(byValInfo->badTypeJump, CodeLocationLabel(byValInfo->stubRoutine->code().code()));
  • trunk/Source/JavaScriptCore/jit/JITOpcodes32_64.cpp

    r228500 r229054  
    934934    byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    935935        m_codeBlock, patchBuffer,
    936         ("Baseline has_indexed_property stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value()));
     936        "Baseline has_indexed_property stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value());
    937937   
    938938    MacroAssembler::repatchJump(byValInfo->badTypeJump, CodeLocationLabel(byValInfo->stubRoutine->code().code()));
  • trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp

    r228193 r229054  
    9191   
    9292    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    93     return FINALIZE_CODE(patchBuffer, ("String get_by_val stub"));
     93    return FINALIZE_CODE(patchBuffer, "String get_by_val stub");
    9494}
    9595
     
    12631263    byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    12641264        m_codeBlock, patchBuffer,
    1265         ("Baseline get_by_val stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value()));
     1265        "Baseline get_by_val stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value());
    12661266   
    12671267    MacroAssembler::repatchJump(byValInfo->badTypeJump, CodeLocationLabel(byValInfo->stubRoutine->code().code()));
     
    12951295    byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    12961296        m_codeBlock, patchBuffer,
    1297         ("Baseline get_by_val with cached property name '%s' stub for %s, return point %p", propertyName.impl()->utf8().data(), toCString(*m_codeBlock).data(), returnAddress.value()));
     1297        "Baseline get_by_val with cached property name '%s' stub for %s, return point %p", propertyName.impl()->utf8().data(), toCString(*m_codeBlock).data(), returnAddress.value());
    12981298    byValInfo->stubInfo = gen.stubInfo();
    12991299
     
    13501350        byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    13511351            m_codeBlock, patchBuffer,
    1352             ("Baseline put_by_val stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value()));
     1352            "Baseline put_by_val stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value());
    13531353       
    13541354    } else {
    13551355        byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    13561356            m_codeBlock, patchBuffer,
    1357             ("Baseline put_by_val_direct stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value()));
     1357            "Baseline put_by_val_direct stub for %s, return point %p", toCString(*m_codeBlock).data(), returnAddress.value());
    13581358    }
    13591359    MacroAssembler::repatchJump(byValInfo->badTypeJump, CodeLocationLabel(byValInfo->stubRoutine->code().code()));
     
    13851385    byValInfo->stubRoutine = FINALIZE_CODE_FOR_STUB(
    13861386        m_codeBlock, patchBuffer,
    1387         ("Baseline put_by_val%s with cached property name '%s' stub for %s, return point %p", (putKind == Direct) ? "_direct" : "", propertyName.impl()->utf8().data(), toCString(*m_codeBlock).data(), returnAddress.value()));
     1387        "Baseline put_by_val%s with cached property name '%s' stub for %s, return point %p", (putKind == Direct) ? "_direct" : "", propertyName.impl()->utf8().data(), toCString(*m_codeBlock).data(), returnAddress.value());
    13881388    byValInfo->stubInfo = gen.stubInfo();
    13891389
  • trunk/Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp

    r224626 r229054  
    11/*
    2  * Copyright (C) 2008-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2008-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    179179   
    180180    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    181     return FINALIZE_CODE(patchBuffer, ("String get_by_val stub"));
     181    return FINALIZE_CODE(patchBuffer, "String get_by_val stub");
    182182}
    183183
  • trunk/Source/JavaScriptCore/jit/JITStubRoutine.h

    r218867 r229054  
    11/*
    2  * Copyright (C) 2012, 2014 Apple Inc. All rights reserved.
     2 * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    115115
    116116// Helper for the creation of simple stub routines that need no help from the GC.
    117 #define FINALIZE_CODE_FOR_STUB(codeBlock, patchBuffer, dataLogFArguments) \
    118     (adoptRef(new JITStubRoutine(FINALIZE_CODE_FOR((codeBlock), (patchBuffer), dataLogFArguments))))
     117#define FINALIZE_CODE_FOR_STUB(codeBlock, patchBuffer, ...) \
     118    (adoptRef(new JITStubRoutine(FINALIZE_CODE_FOR((codeBlock), (patchBuffer), __VA_ARGS__))))
    119119
    120120} // namespace JSC
  • trunk/Source/JavaScriptCore/jit/Repatch.cpp

    r228420 r229054  
    11/*
    2  * Copyright (C) 2011-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2011-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    10801080        FINALIZE_CODE_FOR(
    10811081            callerCodeBlock, patchBuffer,
    1082             ("Polymorphic call stub for %s, return point %p, targets %s",
     1082            "Polymorphic call stub for %s, return point %p, targets %s",
    10831083                isWebAssembly ? "WebAssembly" : toCString(*callerCodeBlock).data(), callLinkInfo.callReturnLocation().labelAtOffset(0).executableAddress(),
    1084                 toCString(listDump(callCases)).data())),
     1084                toCString(listDump(callCases)).data()),
    10851085        vm, owner, exec->callerFrame(), callLinkInfo, callCases,
    10861086        WTFMove(fastCounts)));
  • trunk/Source/JavaScriptCore/jit/SpecializedThunkJIT.h

    r225632 r229054  
    11/*
    2  * Copyright (C) 2010-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2010-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    171171            for (unsigned i = 0; i < m_calls.size(); i++)
    172172                patchBuffer.link(m_calls[i].first, m_calls[i].second);
    173             return FINALIZE_CODE(patchBuffer, ("Specialized thunk for %s", thunkKind));
     173            return FINALIZE_CODE(patchBuffer, "Specialized thunk for %s", thunkKind);
    174174        }
    175175
  • trunk/Source/JavaScriptCore/jit/ThunkGenerators.cpp

    r228420 r229054  
    7676
    7777    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    78     return FINALIZE_CODE(patchBuffer, ("Throw exception from call slow path thunk"));
     78    return FINALIZE_CODE(patchBuffer, "Throw exception from call slow path thunk");
    7979}
    8080
     
    142142   
    143143    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    144     return FINALIZE_CODE(patchBuffer, ("Link call slow path thunk"));
     144    return FINALIZE_CODE(patchBuffer, "Link call slow path thunk");
    145145}
    146146
     
    154154   
    155155    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    156     return FINALIZE_CODE(patchBuffer, ("Link polymorphic call slow path thunk"));
     156    return FINALIZE_CODE(patchBuffer, "Link polymorphic call slow path thunk");
    157157}
    158158
     
    243243    return FINALIZE_CODE(
    244244        patchBuffer,
    245         ("Virtual %s slow path thunk",
    246         callLinkInfo.callMode() == CallMode::Regular ? "call" : callLinkInfo.callMode() == CallMode::Tail ? "tail call" : "construct"));
     245        "Virtual %s slow path thunk",
     246        callLinkInfo.callMode() == CallMode::Regular ? "call" : callLinkInfo.callMode() == CallMode::Tail ? "tail call" : "construct");
    247247}
    248248
     
    428428
    429429    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    430     return FINALIZE_CODE(patchBuffer, ("%s %s%s trampoline", thunkFunctionType == ThunkFunctionType::JSFunction ? "native" : "internal", entryType == EnterViaJumpWithSavedTags ? "Tail With Saved Tags " : entryType == EnterViaJumpWithoutSavedTags ? "Tail Without Saved Tags " : "", toCString(kind).data()));
     430    return FINALIZE_CODE(patchBuffer, "%s %s%s trampoline", thunkFunctionType == ThunkFunctionType::JSFunction ? "native" : "internal", entryType == EnterViaJumpWithSavedTags ? "Tail With Saved Tags " : entryType == EnterViaJumpWithoutSavedTags ? "Tail Without Saved Tags " : "", toCString(kind).data());
    431431}
    432432
     
    585585
    586586    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    587     return FINALIZE_CODE(patchBuffer, ("fixup arity"));
     587    return FINALIZE_CODE(patchBuffer, "fixup arity");
    588588}
    589589
     
    595595
    596596    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    597     return FINALIZE_CODE(patchBuffer, ("unreachable thunk"));
     597    return FINALIZE_CODE(patchBuffer, "unreachable thunk");
    598598}
    599599
     
    11911191    linkBuffer.link(noCode, CodeLocationLabel(vm->jitStubs->ctiNativeTailCallWithoutSavedTags(vm)));
    11921192    return FINALIZE_CODE(
    1193         linkBuffer, ("Specialized thunk for bound function calls with no arguments"));
     1193        linkBuffer, "Specialized thunk for bound function calls with no arguments");
    11941194}
    11951195
  • trunk/Source/JavaScriptCore/llint/LLIntThunks.cpp

    r223738 r229054  
    11/*
    2  * Copyright (C) 2012-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2012-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    6161   
    6262    LinkBuffer patchBuffer(jit, GLOBAL_THUNK_ID);
    63     return FINALIZE_CODE(patchBuffer, ("LLInt %s prologue thunk", thunkKind));
     63    return FINALIZE_CODE(patchBuffer, "LLInt %s prologue thunk", thunkKind);
    6464}
    6565
  • trunk/Source/JavaScriptCore/wasm/WasmBBQPlan.cpp

    r225363 r229054  
    11/*
    2  * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    309309
    310310                m_wasmInternalFunctions[functionIndex]->entrypoint.compilation = std::make_unique<B3::Compilation>(
    311                     FINALIZE_CODE(linkBuffer, ("WebAssembly function[%i] %s", functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data())),
     311                    FINALIZE_CODE(linkBuffer, "WebAssembly function[%i] %s", functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data()),
    312312                    WTFMove(context.wasmEntrypointByproducts));
    313313            }
     
    321321
    322322                embedderToWasmInternalFunction->entrypoint.compilation = std::make_unique<B3::Compilation>(
    323                     FINALIZE_CODE(linkBuffer, ("Embedder->WebAssembly entrypoint[%i] %s", functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data())),
     323                    FINALIZE_CODE(linkBuffer, "Embedder->WebAssembly entrypoint[%i] %s", functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data()),
    324324                    WTFMove(context.embedderEntrypointByproducts));
    325325            }
  • trunk/Source/JavaScriptCore/wasm/WasmBinding.cpp

    r228966 r229054  
    11/*
    2  * Copyright (C) 2016-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2016-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    8383        return makeUnexpected(BindingFailure::OutOfMemory);
    8484
    85     return FINALIZE_CODE(patchBuffer, ("WebAssembly->WebAssembly import[%i]", importIndex));
     85    return FINALIZE_CODE(patchBuffer, "WebAssembly->WebAssembly import[%i]", importIndex);
    8686}
    8787
  • trunk/Source/JavaScriptCore/wasm/WasmOMGPlan.cpp

    r225363 r229054  
    11/*
    2  * Copyright (C) 2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2017-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    9999
    100100    omgEntrypoint.compilation = std::make_unique<B3::Compilation>(
    101         FINALIZE_CODE(linkBuffer, ("WebAssembly OMG function[%i] %s", m_functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data())),
     101        FINALIZE_CODE(linkBuffer, "WebAssembly OMG function[%i] %s", m_functionIndex, SignatureInformation::get(signatureIndex).toString().ascii().data()),
    102102        WTFMove(context.wasmEntrypointByproducts));
    103103
  • trunk/Source/JavaScriptCore/wasm/WasmThunks.cpp

    r228491 r229054  
    11/*
    2  * Copyright (C) 2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2017-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    6060    LinkBuffer linkBuffer(jit, GLOBAL_THUNK_ID);
    6161    linkBuffer.link(call, FunctionPtr(throwWasmException));
    62     return FINALIZE_CODE(linkBuffer, ("Throw exception from Wasm"));
     62    return FINALIZE_CODE(linkBuffer, "Throw exception from Wasm");
    6363}
    6464
     
    7474    LinkBuffer linkBuffer(jit, GLOBAL_THUNK_ID);
    7575    linkBuffer.link(jumpToExceptionHandler, CodeLocationLabel(Thunks::singleton().stub(locker, throwExceptionFromWasmThunkGenerator).code()));
    76     return FINALIZE_CODE(linkBuffer, ("Throw stack overflow from Wasm"));
     76    return FINALIZE_CODE(linkBuffer, "Throw stack overflow from Wasm");
    7777}
    7878
     
    100100    jit.ret();
    101101    LinkBuffer linkBuffer(jit, GLOBAL_THUNK_ID);
    102     return FINALIZE_CODE(linkBuffer, ("Trigger OMG tier up"));
     102    return FINALIZE_CODE(linkBuffer, "Trigger OMG tier up");
    103103}
    104104
  • trunk/Source/JavaScriptCore/wasm/js/WasmToJS.cpp

    r227527 r229054  
    117117
    118118        linkBuffer.link(call, throwBadI64);
    119         return FINALIZE_CODE(linkBuffer, ("WebAssembly->JavaScript invalid i64 use in import[%i]", importIndex));
     119        return FINALIZE_CODE(linkBuffer, "WebAssembly->JavaScript invalid i64 use in import[%i]", importIndex);
    120120    }
    121121   
     
    343343        linkBuffer.link(exceptionCall, doUnwinding);
    344344
    345         return FINALIZE_CODE(linkBuffer, ("WebAssembly->JavaScript import[%i] %s", importIndex, signature.toString().ascii().data()));
     345        return FINALIZE_CODE(linkBuffer, "WebAssembly->JavaScript import[%i] %s", importIndex, signature.toString().ascii().data());
    346346    }
    347347
     
    655655    callLinkInfo->setCallLocations(callReturnLocation, hotPathBegin, hotPathOther);
    656656
    657     return FINALIZE_CODE(patchBuffer, ("WebAssembly->JavaScript import[%i] %s", importIndex, signature.toString().ascii().data()));
     657    return FINALIZE_CODE(patchBuffer, "WebAssembly->JavaScript import[%i] %s", importIndex, signature.toString().ascii().data());
    658658}
    659659
  • trunk/Source/JavaScriptCore/yarr/YarrJIT.cpp

    r228481 r229054  
    11/*
    2  * Copyright (C) 2009-2017 Apple Inc. All rights reserved.
     2 * Copyright (C) 2009-2018 Apple Inc. All rights reserved.
    33 *
    44 * Redistribution and use in source and binary forms, with or without
     
    34893489        if (compileMode == MatchOnly) {
    34903490            if (m_charSize == Char8)
    3491                 jitObject.set8BitCodeMatchOnly(FINALIZE_CODE(linkBuffer, ("Match-only 8-bit regular expression")));
     3491                jitObject.set8BitCodeMatchOnly(FINALIZE_CODE(linkBuffer, "Match-only 8-bit regular expression"));
    34923492            else
    3493                 jitObject.set16BitCodeMatchOnly(FINALIZE_CODE(linkBuffer, ("Match-only 16-bit regular expression")));
     3493                jitObject.set16BitCodeMatchOnly(FINALIZE_CODE(linkBuffer, "Match-only 16-bit regular expression"));
    34943494        } else {
    34953495            if (m_charSize == Char8)
    3496                 jitObject.set8BitCode(FINALIZE_CODE(linkBuffer, ("8-bit regular expression")));
     3496                jitObject.set8BitCode(FINALIZE_CODE(linkBuffer, "8-bit regular expression"));
    34973497            else
    3498                 jitObject.set16BitCode(FINALIZE_CODE(linkBuffer, ("16-bit regular expression")));
     3498                jitObject.set16BitCode(FINALIZE_CODE(linkBuffer, "16-bit regular expression"));
    34993499        }
    35003500        if (m_failureReason)
  • trunk/Source/WebCore/ChangeLog

    r229051 r229054  
     12018-02-26  Mark Lam  <mark.lam@apple.com>
     2
     3        Modernize FINALIZE_CODE and peer macros to use __VA_ARGS__ arguments.
     4        https://bugs.webkit.org/show_bug.cgi?id=183159
     5        <rdar://problem/37930837>
     6
     7        Reviewed by Keith Miller.
     8
     9        No new tests needed because this is just a refactoring patch.
     10
     11        * cssjit/SelectorCompiler.cpp:
     12        (WebCore::SelectorCompiler::SelectorCodeGenerator::compile):
     13
    1142018-02-26  Dan Bernstein  <mitz@apple.com>
    215
  • trunk/Source/WebCore/cssjit/SelectorCompiler.cpp

    r226011 r229054  
    11/*
    2  * Copyright (C) 2013-2016 Apple Inc. All rights reserved.
     2 * Copyright (C) 2013-2018 Apple Inc. All rights reserved.
    33 * Copyright (C) 2014 Yusuke Suzuki <utatane.tea@gmail.com>
    44 *
     
    12391239    codeRef = linkBuffer.finalizeCodeWithDisassembly("CSS Selector JIT for \"%s\"", m_originalSelector->selectorText().utf8().data());
    12401240#else
    1241     codeRef = FINALIZE_CODE(linkBuffer, ("CSS Selector JIT"));
     1241    codeRef = FINALIZE_CODE(linkBuffer, "CSS Selector JIT");
    12421242#endif
    12431243
Note: See TracChangeset for help on using the changeset viewer.