Changeset 229377 in webkit


Ignore:
Timestamp:
Mar 7, 2018 3:09:00 PM (6 years ago)
Author:
webkit@devinrousso.com
Message:

Web Inspector: Canvas tab: ensure that the Recording TreeOutline has a specified height for virtualization
https://bugs.webkit.org/show_bug.cgi?id=183015

Reviewed by Matt Baker.

  • UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel):

  • UserInterface/Views/CanvasSidebarPanel.css:

(.sidebar > .panel.navigation.canvas > .content):
(.sidebar > .panel.navigation.canvas > .content > .navigation-bar):
(.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
(.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,):
(.sidebar > .panel.navigation.canvas > .content > .recording-content > .navigation-bar): Deleted.
(.sidebar > .panel.navigation.canvas.has-recordings > .content > .tree-outline.canvas): Deleted.

  • UserInterface/Views/TreeElement.js:

(WI.TreeElement.prototype._detach):

Location:
trunk/Source/WebInspectorUI
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r229044 r229377  
     12018-03-07  Devin Rousso  <webkit@devinrousso.com>
     2
     3        Web Inspector: Canvas tab: ensure that the Recording TreeOutline has a specified height for virtualization
     4        https://bugs.webkit.org/show_bug.cgi?id=183015
     5
     6        Reviewed by Matt Baker.
     7
     8        * UserInterface/Views/CanvasSidebarPanel.js:
     9        (WI.CanvasSidebarPanel):
     10
     11        * UserInterface/Views/CanvasSidebarPanel.css:
     12        (.sidebar > .panel.navigation.canvas > .content):
     13        (.sidebar > .panel.navigation.canvas > .content > .navigation-bar):
     14        (.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content):
     15        (.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,):
     16        (.sidebar > .panel.navigation.canvas > .content > .recording-content > .navigation-bar): Deleted.
     17        (.sidebar > .panel.navigation.canvas.has-recordings > .content > .tree-outline.canvas): Deleted.
     18
     19        * UserInterface/Views/TreeElement.js:
     20        (WI.TreeElement.prototype._detach):
     21
    1222018-02-26  Devin Rousso  <webkit@devinrousso.com>
    223
  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.css

    r228362 r229377  
    2525
    2626.sidebar > .panel.navigation.canvas > .content {
     27    display: flex;
     28    flex-direction: column;
    2729    top: var(--navigation-bar-height);
     30    overflow-y: hidden;
    2831}
    2932
     
    4144}
    4245
    43 .sidebar > .panel.navigation.canvas > .content > .recording-content > .navigation-bar {
     46.sidebar > .panel.navigation.canvas > .content > .navigation-bar {
    4447    border-top: 1px solid var(--border-color);
    4548}
    4649
    47 .sidebar > .panel.navigation.canvas.has-recordings > .content > .tree-outline.canvas {
    48     max-height: 50%;
     50.sidebar > .panel.navigation.canvas.has-recordings > .content > .recording-content {
    4951    overflow-y: scroll;
    5052}
    5153
    5254.sidebar > .panel.navigation.canvas:not(.has-recordings) > .filter-bar,
    53 .sidebar > .panel.navigation.canvas:not(.has-recordings) > .content > .recording-content {
     55.sidebar > .panel.navigation.canvas:not(.has-recordings) > .content > :matches(.navigation-bar, .recording-content) {
    5456    display: none;
    5557}
  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js

    r228722 r229377  
    4949        this._canvasTreeOutline.element.classList.add("canvas");
    5050
     51        this._recordingNavigationBar = new WI.NavigationBar;
     52        this._recordingNavigationBar.element.classList.add("hidden");
     53        this.contentView.addSubview(this._recordingNavigationBar);
     54
    5155        let recordingContent = this.contentView.element.appendChild(document.createElement("div"));
    5256        recordingContent.className = "recording-content";
    53 
    54         this._recordingNavigationBar = new WI.NavigationBar;
    55         this._recordingNavigationBar.element.classList.add("hidden");
    56         recordingContent.appendChild(this._recordingNavigationBar.element);
    5757
    5858        this._recordingTreeOutline = this.contentTreeOutline;
  • trunk/Source/WebInspectorUI/UserInterface/Views/TreeElement.js

    r225259 r229377  
    272272        if (this._childrenListNode && this._childrenListNode.parentNode)
    273273            this._childrenListNode.parentNode.removeChild(this._childrenListNode);
     274
     275        if (this.treeOutline)
     276            this.treeOutline.soon.updateVirtualizedElements();
    274277    }
    275278
Note: See TracChangeset for help on using the changeset viewer.