Changeset 229669 in webkit


Ignore:
Timestamp:
Mar 16, 2018 10:06:03 AM (6 years ago)
Author:
Michael Catanzaro
Message:

Improve error message when Gigacage cannot allocate virtual memory
https://bugs.webkit.org/show_bug.cgi?id=183329

Reviewed by Filip Pizlo.

We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
That will have to be fixed by Deja Dup, but there is concern that other applications might
try this, or that users will set a virtual memory limit for the entire desktop session. Of
particular concern is the possibility that users might have copypasted a ulimit line into
a session startup script without understanding it. Let's try to make it slightly easier to
understand what's going wrong.

  • bmalloc/Gigacage.cpp:

(Gigacage::ensureGigacage):

Location:
trunk/Source/bmalloc
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/bmalloc/ChangeLog

    r229591 r229669  
     12018-03-16  Michael Catanzaro  <mcatanzaro@igalia.com>
     2
     3        Improve error message when Gigacage cannot allocate virtual memory
     4        https://bugs.webkit.org/show_bug.cgi?id=183329
     5
     6        Reviewed by Filip Pizlo.
     7
     8        We've discovered that Deja Dup monitor sets a virtual memory limit, breaking Gigacage. Since
     9        it runs in the background on a fresh out-of-the-box install of Ubuntu, this is not good.
     10        That will have to be fixed by Deja Dup, but there is concern that other applications might
     11        try this, or that users will set a virtual memory limit for the entire desktop session. Of
     12        particular concern is the possibility that users might have copypasted a ulimit line into
     13        a session startup script without understanding it. Let's try to make it slightly easier to
     14        understand what's going wrong.
     15
     16        * bmalloc/Gigacage.cpp:
     17        (Gigacage::ensureGigacage):
     18
    1192018-03-13  Tim Horton  <timothy_horton@apple.com>
    220
  • trunk/Source/bmalloc/bmalloc/Gigacage.cpp

    r228108 r229669  
    152152                    return;
    153153                fprintf(stderr, "FATAL: Could not allocate gigacage memory with maxAlignment = %lu, totalSize = %lu.\n", maxAlignment, totalSize);
     154                fprintf(stderr, "(Make sure you have not set a virtual memory limit.)\n");
    154155                BCRASH();
    155156            }
Note: See TracChangeset for help on using the changeset viewer.