Changeset 229736 in webkit

Timestamp:

Mar 19, 2018 7:34:25 PM (6 years ago)

Author:

Chris Dumez

Message:

WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
​https://bugs.webkit.org/show_bug.cgi?id=181546
<rdar://problem/36444327>

Reviewed by Ryosuke Niwa.

in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
to originIdentifiersToDelete if we cannot determine the last modification
time of the database file. This likely means the database file does not
exist. However, we still needs to make sure the origin gets removed from
the origins database and there may be *.wal / *.shm variants of the database
that are still on disk and need to be deleted.

• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-03-19  Chris Dumez  <cdumez@apple.com>
+
+        WKWebView.ClearAppCache is a flaky API test failure on High Sierra.
+        https://bugs.webkit.org/show_bug.cgi?id=181546
+        <rdar://problem/36444327>
+
+        Reviewed by Ryosuke Niwa.
+
+        in LocalStorageDatabaseTracker::deleteDatabasesModifiedSince(), add origin
+        to originIdentifiersToDelete if we cannot determine the last modification
+        time of the database file. This likely means the database file does not
+        exist. However, we still needs to make sure the origin gets removed from
+        the origins database and there may be *.wal / *.shm variants of the database
+        that are still on disk and need to be deleted.
+
+        * UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp:
+        (WebKit::LocalStorageDatabaseTracker::deleteDatabasesModifiedSince):
+
 2018-03-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp

@@ -153 +153 @@
 
         auto modificationTime = FileSystem::getFileModificationTime(filePath);
-        if (!modificationTime)
-            continue;
-
-        if (modificationTime.value() >= time)
+        if (!modificationTime || modificationTime.value() >= time)
             originIdentifiersToDelete.append(origin);
     }