Changeset 230466 in webkit

Timestamp:

Apr 9, 2018 8:03:28 PM (6 years ago)

Author:

Alan Bujtas

Message:

[LayoutReloaded] Remove Layout.InitialContainingBlock class
​https://bugs.webkit.org/show_bug.cgi?id=184436

Reviewed by Antti Koivisto.

• LayoutReloaded/LayoutTree/Box.js:

(Layout.Box.prototype.establishesBlockFormattingContext):

• LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
• LayoutReloaded/TreeBuilder.js:

(TreeBuilder.prototype.createTree):

• LayoutReloaded/test/index.html:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• LayoutReloaded/LayoutTree/Box.js (modified) (1 diff)
• LayoutReloaded/LayoutTree/InitialBlockContainer.js (deleted)
• LayoutReloaded/TreeBuilder.js (modified) (1 diff)
• LayoutReloaded/test/index.html (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2018-04-09  Zalan Bujtas  <zalan@apple.com>
+
+        [LayoutReloaded] Remove Layout.InitialContainingBlock class
+        https://bugs.webkit.org/show_bug.cgi?id=184436
+
+        Reviewed by Antti Koivisto.
+
+        * LayoutReloaded/LayoutTree/Box.js:
+        (Layout.Box.prototype.establishesBlockFormattingContext):
+        * LayoutReloaded/LayoutTree/InitialBlockContainer.js: Removed.
+        * LayoutReloaded/TreeBuilder.js:
+        (TreeBuilder.prototype.createTree):
+        * LayoutReloaded/test/index.html:
+
 2018-04-09  Zalan Bujtas  <zalan@apple.com>
 

trunk/Tools/LayoutReloaded/LayoutTree/Box.js

@@ -151 +151 @@
 
     establishesBlockFormattingContext() {
+        // Initial Containing Block always creates a new (inital) block formatting context.
+        if (!this.parent())
+            return true;
         // 9.4.1 Block formatting contexts
         // Floats, absolutely positioned elements, block containers (such as inline-blocks, table-cells, and table-captions)

trunk/Tools/LayoutReloaded/TreeBuilder.js

@@ -29 +29 @@
     createTree(document, renderTreeDump) {
         // Root.
-        let initialBlockContainer = new Layout.InitialBlockContainer(document, parseInt(renderTreeDump.substring(0, renderTreeDump.indexOf("("))));
+        let initialBlockContainer = new Layout.BlockContainer(document, parseInt(renderTreeDump.substring(0, renderTreeDump.indexOf("("))));
         initialBlockContainer.setRendererName("RenderView");
         renderTreeDump = renderTreeDump.substring(renderTreeDump.indexOf("|") + 1);

trunk/Tools/LayoutReloaded/test/index.html

@@ -100 +100 @@
 addJS("../LayoutTree/Container.js");
 addJS("../LayoutTree/BlockContainer.js");
-addJS("../LayoutTree/InitialBlockContainer.js");
 addJS("../LayoutTree/InlineContainer.js");
 addJS("../LayoutTree/InlineBox.js");