Changeset 230499 in webkit


Ignore:
Timestamp:
Apr 10, 2018 4:06:05 PM (6 years ago)
Author:
Keith Rollin
Message:

http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
​https://bugs.webkit.org/show_bug.cgi?id=155634
<rdar://problem/39326489>

Reviewed by Youenn Fablet.

These tests no longer appear to be flaky. I believe they were
addressed in <​https://trac.webkit.org/changeset/217069/webkit>. After
enabling the test and rebasing the results, I ran run-webkit-tests
with --repeat-each=20 --iterations=20, and then I wrapped the
run-webkit-tests command in a loop that invoked it 20 times.

  • TestExpectations:
  • http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
  • http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
  • http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
  • http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:
Location:
trunk/LayoutTests
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r230495 r230499  
     12018-04-10  Keith Rollin  <krollin@apple.com>
     2
     3        http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
     4        https://bugs.webkit.org/show_bug.cgi?id=155634
     5        <rdar://problem/39326489>
     6
     7        Reviewed by Youenn Fablet.
     8
     9        These tests no longer appear to be flaky. I believe they were
     10        addressed in <https://trac.webkit.org/changeset/217069/webkit>. After
     11        enabling the test and rebasing the results, I ran run-webkit-tests
     12        with --repeat-each=20 --iterations=20, and then I wrapped the
     13        run-webkit-tests command in a loop that invoked it 20 times.
     14
     15        * TestExpectations:
     16        * http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
     17        * http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
     18        * http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
     19        * http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:
     20
    1212018-04-10  Youenn Fablet  <youenn@apple.com>
    222

  • trunk/LayoutTests/TestExpectations

    r230495 r230499  
    11771177webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ]
    11781178
    1179 webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-1.html [ Pass Failure ]
    1180 webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-2.html [ Pass Failure ]
    1181 webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-3.html [ Pass Failure ]
    1182 webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-4.html [ Pass Failure ]
    1183 
    11841179# Content Security Policy failures
    11851180webkit.org/b/111869 http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html

  • trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt

    r198395 r230499  
    1 CONSOLE MESSAGE: Unsafe attempt to load URL http://127.0.0.1:8000/resources/redirect.php?url=http%3A%2F%2Flocalhost%3A8080%2Fsecurity%2Fresources%2Fimage-access-control.php%3Ffile%3D..%2F..%2Fresources%2Fsquare100.png%26allow%3Dfalse.
     1CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
    22Verify the error message in console in case of CORS failing checks.
    33

  • trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt

    r198395 r230499  
    1 CONSOLE MESSAGE: Unsafe attempt to load URL http://localhost:8080/security/resources/redirect-allow-star.php?url=http%3A%2F%2Flocalhost%3A8080%2Fsecurity%2Fresources%2Fimage-access-control.php%3Ffile%3D..%2F..%2Fresources%2Fsquare100.png%26allow%3Dfalse.
     1CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
    22Verify the error message in console in case of CORS failing checks.
    33

  • trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt

    r198395 r230499  
    1 CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
     1CONSOLE MESSAGE: Cross-origin redirection to http://localhost:8080/security/resources/image-access-control.php?file=../../resources/square100.png&allow=true denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
    22Verify the error message in console in case of CORS failing checks.
    33

  • trunk/LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt

    r198395 r230499  
    1 CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Redirected to either a non-HTTP URL or a URL that contains credentials.
     1CONSOLE MESSAGE: Cross-origin redirection to mailto://example.com denied by Cross-Origin Resource Sharing policy: URL is either a non-HTTP URL or contains credentials.
    22Verify the error message in console in case of CORS failing checks.
    33
Note: See TracChangeset for help on using the changeset viewer.