Changeset 230745 in webkit

Timestamp:

Apr 17, 2018 6:03:22 PM (6 years ago)

Author:

Megan Gardner

Message:

Don't activate selection on become first responder
​https://bugs.webkit.org/show_bug.cgi?id=184719

Reviewed by Tim Horton.

If we activate the selection immediately on becoming first responder, we cause the selection view to delete itself
since it is not guaranteed to have selection rects immediately due to async/two process architecture. The selection
is activated already when the selection rects change, so there is no reason to activate it now. This has likely worked
in the past because this selection assistant was only for editable text, which would immediately set a caret, which
is a selection. Now that this is for non-editable text as well, activating the selection is problematic.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView becomeFirstResponderForWebView]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2018-04-17  Megan Gardner  <megan_gardner@apple.com>
+
+        Don't activate selection on become first responder
+        https://bugs.webkit.org/show_bug.cgi?id=184719
+
+        Reviewed by Tim Horton.
+        
+        If we activate the selection immediately on becoming first responder, we cause the selection view to delete itself
+        since it is not guaranteed to have selection rects immediately due to async/two process architecture. The selection
+        is activated already when the selection rects change, so there is no reason to activate it now. This has likely worked
+        in the past because this selection assistant was only for editable text, which would immediately set a caret, which 
+        is a selection. Now that this is for non-editable text as well, activating the selection is problematic.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView becomeFirstResponderForWebView]):
+
 2018-04-11  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -938 +938 @@
         didBecomeFirstResponder = [super becomeFirstResponder];
     }
-    if (didBecomeFirstResponder && !self.suppressAssistantSelectionView)
-        [_textSelectionAssistant activateSelection];
 
     return didBecomeFirstResponder;