Changeset 230939 in webkit

Timestamp:

Apr 23, 2018, 7:30:20 PM (7 years ago)

Author:

Chris Dumez

Message:

Unreviewed, fix a few tests that became flaky after r230919.

• fast/events/beforeunload-alert-handled-keydown.html:
• fast/events/beforeunload-alert-no-user-interaction.html:
• fast/events/beforeunload-alert-user-interaction.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/beforeunload-alert-handled-keydown.html (modified) (1 diff)
• fast/events/beforeunload-alert-no-user-interaction.html (modified) (1 diff)
• fast/events/beforeunload-alert-user-interaction.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2018-04-23  Chris Dumez  <cdumez@apple.com>
+
+        Unreviewed, fix a few tests that became flaky after r230919.
+
+        * fast/events/beforeunload-alert-handled-keydown.html:
+        * fast/events/beforeunload-alert-no-user-interaction.html:
+        * fast/events/beforeunload-alert-user-interaction.html:
+
 2018-04-23  Commit Queue  <commit-queue@webkit.org>
 

trunk/LayoutTests/fast/events/beforeunload-alert-handled-keydown.html

@@ -21 +21 @@
     setTimeout(function() {
         shouldBeEqualToString("testInput.value", "a");
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };

trunk/LayoutTests/fast/events/beforeunload-alert-no-user-interaction.html

@@ -13 +13 @@
     };
     setTimeout(function() {
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };

trunk/LayoutTests/fast/events/beforeunload-alert-user-interaction.html

@@ -18 +18 @@
         eventSender.keyDown("a");
     setTimeout(function() {
+        testFrame.onload = finishJSTest;
         testFrame.src = "about:blank";
-        setTimeout(finishJSTest, 0);
     }, 0);
 };