Changeset 231299 in webkit


Ignore:
Timestamp:
May 3, 2018, 1:50:09 AM (8 years ago)
Author:
timothy_horton@apple.com
Message:

REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
​https://bugs.webkit.org/show_bug.cgi?id=185241

Reviewed by Dan Bernstein.

  • Configurations/BaseXPCService.xcconfig:
  • Configurations/WebContentService.Development.xcconfig:
  • Configurations/WebContentService.xcconfig:
Location:
trunk/Source/WebKit
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r231298 r231299  
     12018-05-03  Tim Horton  <timothy_horton@apple.com>
     2
     3        REGRESSION (r231014): Entitlements are not applied to XPC services on macOS
     4        https://bugs.webkit.org/show_bug.cgi?id=185241
     5
     6        Reviewed by Dan Bernstein.
     7
     8        * Configurations/BaseXPCService.xcconfig:
     9        * Configurations/WebContentService.Development.xcconfig:
     10        * Configurations/WebContentService.xcconfig:
     11
    1122018-05-03  Carlos Garcia Campos  <cgarcia@igalia.com>
    213

  • trunk/Source/WebKit/Configurations/BaseXPCService.xcconfig

    r231014 r231299  
    5454WK_PATH_FROM_SERVICE_EXECUTABLE_TO_FRAMEWORK_SHALLOW_BUNDLE_YES = ../..;
    5555
    56 CODE_SIGN_ENTITLEMENTS = $(CODE_SIGN_ENTITLEMENTS_$(WK_COCOA_TOUCH));
    57 CODE_SIGN_ENTITLEMENTS_cocoatouch = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL));
     56CODE_SIGN_ENTITLEMENTS = $(CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_$(WK_IS_COCOA_TOUCH));
     57CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_YES = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_$(SKIP_INSTALL));
    5858
    5959CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_ = $(CODE_SIGN_ENTITLEMENTS_IOS_SKIP_INSTALL_NO);

  • trunk/Source/WebKit/Configurations/WebContentService.Development.xcconfig

    r230778 r231299  
    2727SKIP_INSTALL[sdk=macosx*] = $(WK_RELOCATABLE_FRAMEWORKS);
    2828
    29 CODE_SIGN_ENTITLEMENTS_macosx = Configurations/WebContent.Development.entitlements;
     29CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = Configurations/WebContent.Development.entitlements;
    3030
    3131WK_XPC_SERVICE_VARIANT = Development;

  • trunk/Source/WebKit/Configurations/WebContentService.xcconfig

    r231205 r231299  
    3333WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE_iphoneminimalsimulator = WebContent-iOS-minimalsimulator;
    3434
    35 CODE_SIGN_ENTITLEMENTS_macosx = $(CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_$(WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT));
     35CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO = $(CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_$(WK_WEBCONTENT_SERVICE_NEEDS_XPC_DOMAIN_EXTENSION_ENTITLEMENT));
    3636CODE_SIGN_ENTITLEMENTS_OSX_WITH_XPC_DOMAIN_EXTENSION_YES = Configurations/WebContent-OSX.entitlements;
    3737OTHER_CODE_SIGN_FLAGS = $(WK_LIBRARY_VALIDATION_CODE_SIGN_FLAGS);
Note: See TracChangeset for help on using the changeset viewer.